[Bug 2074467] New: Review Request: yq - Portable command-line YAML, JSON and XML processor
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Bug ID: 2074467 Summary: Review Request: yq - Portable command-line YAML, JSON and XML processor Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jrische@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pagure.io/rpm-yq/raw/rawhide/f/yq.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide...
Description: Lightweight and portable command-line YAML, JSON and XML processor. yq uses jq like syntax but works with yaml files as well as json and xml. It doesn't yet support everything jq does - but it does support the most common operations and functions, and more is being added continuously.
Fedora Account System Username: jrische
Source RPM repo: https://pagure.io/rpm-yq
Copr: https://copr.fedorainfracloud.org/coprs/jrische/yq/
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Julien Rische jrische@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2074405, 2074406, 2074412, | |1946151, 2074438, 2031922, | |1270054, 2074452, 2074458, | |2074463
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1270054 [Bug 1270054] Review Request: golang-github-magiconair-properties - Java properties scanner for Go https://bugzilla.redhat.com/show_bug.cgi?id=1946151 [Bug 1946151] Review Request: golang-github-pkg-diff - Create, modify, and print diffs https://bugzilla.redhat.com/show_bug.cgi?id=2031922 [Bug 2031922] Review Request: golang-github-jinzhu-copier - Copier for golang, copy value from struct to struct and more https://bugzilla.redhat.com/show_bug.cgi?id=2074405 [Bug 2074405] Review Request: golang-github-timtadh-data-structures - Extra Go data structures https://bugzilla.redhat.com/show_bug.cgi?id=2074406 [Bug 2074406] Review Request: golang-github-a8m-envsubst - Environment variables substitution for Go https://bugzilla.redhat.com/show_bug.cgi?id=2074412 [Bug 2074412] Review Request: golang-github-elliotchance-orderedmap - An ordered map in Go with O(1) for Set, Get, Delete and Len https://bugzilla.redhat.com/show_bug.cgi?id=2074438 [Bug 2074438] Review Request: golang-github-goccy-yaml - YAML support for the Go language https://bugzilla.redhat.com/show_bug.cgi?id=2074452 [Bug 2074452] Review Request: golang-github-timtadh-getopt - Yet another getopt library for Go https://bugzilla.redhat.com/show_bug.cgi?id=2074458 [Bug 2074458] Review Request: golang-github-timtadh-lexmachine - Lex machinary for Go https://bugzilla.redhat.com/show_bug.cgi?id=2074463 [Bug 2074463] Review Request: golang-gopkg-op-logging-1 - Golang logging library
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
--- Comment #1 from Julien Rische jrische@redhat.com --- Re-generate spec file using go2rpm:
Spec URL: https://pagure.io/rpm-yq/raw/rawhide/f/yq.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide...
Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide...
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
--- Comment #2 from Julien Rische jrische@redhat.com --- I removed the glob for the executable file in %files.
Spec URL: https://pagure.io/rpm-yq/raw/rawhide/f/yq.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide...
Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide...
https://bugzilla.redhat.com/show_bug.cgi?id=2074467 Bug 2074467 depends on bug 2074406, which changed state.
Bug 2074406 Summary: Review Request: golang-github-a8m-envsubst - Environment variables substitution for Go https://bugzilla.redhat.com/show_bug.cgi?id=2074406
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2074467 Bug 2074467 depends on bug 2074438, which changed state.
Bug 2074438 Summary: Review Request: golang-github-goccy-yaml - YAML support for the Go language https://bugzilla.redhat.com/show_bug.cgi?id=2074438
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2074467 Bug 2074467 depends on bug 2074463, which changed state.
Bug 2074463 Summary: Review Request: golang-gopkg-op-logging-1 - Golang logging library https://bugzilla.redhat.com/show_bug.cgi?id=2074463
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2107472
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2107472 [Bug 2107472] Review Request: golang-github-jinzhu-copier - Copier for golang, copy value from struct to struct and more
https://bugzilla.redhat.com/show_bug.cgi?id=2074467 Bug 2074467 depends on bug 2031922, which changed state.
Bug 2031922 Summary: Review Request: golang-github-jinzhu-copier - Copier for golang, copy value from struct to struct and more https://bugzilla.redhat.com/show_bug.cgi?id=2031922
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gotmax@e.email
--- Comment #3 from Maxwell G gotmax@e.email --- https://github.com/mikefarah/yq/releases/tag/v4.26.1 has been released. There have been some dependency changes upstream, so make sure to open new review requests for those. I would close the review requests for the dependencies that have been removed, as we generally try to avoid packaging libraries that aren't actually needed for anything, but I won't object if you feel strongly about keeping them.
https://bugzilla.redhat.com/show_bug.cgi?id=2074467 Bug 2074467 depends on bug 2074412, which changed state.
Bug 2074412 Summary: Review Request: golang-github-elliotchance-orderedmap - An ordered map in Go with O(1) for Set, Get, Delete and Len https://bugzilla.redhat.com/show_bug.cgi?id=2074412
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
--- Comment #4 from Julien Rische jrische@redhat.com --- The current version is v4.27.2. There is no dependency on github.com/timtadh/lexmachine, github.com/timtadh/data-structures, and github.com/timtadh/getopt any more.
There are 2 new dependencies that are already packaged: github.com/alecthomas/repr[1] and github.com/goccy/go-json[2].
Lexmachine was replaced by github.com/alecthomas/participle, which is not packaged. I am working on it, but the fact the version that is currently required by yq (2.0.0-beta.4) is containing a dash character is causing a conflict with Fedora's version format. Version 2.0.0 is not released yet.
[1] https://src.fedoraproject.org/rpms/golang-github-alecthomas-repr [2] https://src.fedoraproject.org/rpms/golang-github-goccy-json
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Julien Rische jrische@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2074452 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2074452 [Bug 2074452] Review Request: golang-github-timtadh-getopt - Yet another getopt library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Julien Rische jrische@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2074458 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2074458 [Bug 2074458] Review Request: golang-github-timtadh-lexmachine - Lex machinary for Go
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Julien Rische jrische@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2074405 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2074405 [Bug 2074405] Review Request: golang-github-timtadh-data-structures - Extra Go data structures
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
--- Comment #5 from Maxwell G gotmax@e.email ---
Lexmachine was replaced by github.com/alecthomas/participle, which is not packaged. I am working on it, but the fact the version that is currently required by yq (2.0.0-beta.4) is containing a dash character is causing a conflict with Fedora's version format. Version 2.0.0 is not released yet.
Try adding `%global tag %(tr '~' '-' <<< %{version}) (with the proper indentation) right below Version and set Version to `2.0.0~beta.4`.
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jrische@redhat.co | |m)
--- Comment #6 from Maxwell G gotmax@e.email --- Are you interested in updating the package and proceeding with this review?
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Julien Rische jrische@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG |--- Keywords| |Reopened
--- Comment #8 from Julien Rische jrische@redhat.com --- I am still working on this package. There have been more dependencies changes. I will be opening other packages review requests for these.
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW) | Whiteboard| |NotReady Status|ASSIGNED |NEW
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2074467 Bug 2074467 depends on bug 2107472, which changed state.
Bug 2107472 Summary: Review Request: golang-github-jinzhu-copier - Copier for golang, copy value from struct to struct and more https://bugzilla.redhat.com/show_bug.cgi?id=2107472
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info
--- Comment #9 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
%global goipath github.com/mikefarah/yq
Should be github.com/mikefarah/yq/v4
It would be interesting to add shell completions:
https://mikefarah.gitbook.io/yq/commands/shell-completion
Check doctl's spec as example.
Similar with man pages:
https://github.com/mikefarah/yq/blob/master/debian/rules#L51
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2263790
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2263790 [Bug 2263790] Review Request: python-yq - Command-line YAML/XML processor - jq wrapper for YAML/XML documents
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@redhat.com
--- Comment #10 from Petr Menšík pemensik@redhat.com --- There would be conflict if both this review and bug #2263790 pass, because both provide tool named %_bindir/yq. Any idea how that should be solved?
I thought about naming those tools by pyq, meaning python yq. Possible alternative would be gyq, golang yq (this package). Still not long enough, but different from upstream. Of course alternative is also yq.python and yq.go and customizable alternative via Alternatives [1]. But I doubt those implementations are similar enough. But target functionality is basically the same.
It seems Debian has chosen bug #2263790, but has alternative name xq-python for xq tool. I have not found any clear attempt to resolve the conflict on upstream side. Issue #141 [2] references the problem on python upstream, but haven't found similar note at mikefarah. Except for pip version issue #193 [3].
Would you consider using alternatives to share yq name? Would you have any other idea, how to solve it?
1. https://docs.fedoraproject.org/en-US/packaging-guidelines/Alternatives/ 2. https://github.com/kislyuk/yq/issues/141 3. https://github.com/mikefarah/yq/issues/193
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2263790 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2263790 [Bug 2263790] Review Request: python-yq - Command-line YAML/XML processor - jq wrapper for YAML/XML documents
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
--- Comment #11 from Petr Menšík pemensik@redhat.com --- It seems this package variant has already been imported under bug #2276522. If the reviewer wants access to it, need to request it from current maintainer.
https://src.fedoraproject.org/rpms/yq
https://bugzilla.redhat.com/show_bug.cgi?id=2074467
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |CLOSED Last Closed|2022-11-26 00:45:29 |2024-06-11 16:13:55
--- Comment #12 from Petr Menšík pemensik@redhat.com ---
*** This bug has been marked as a duplicate of bug 2276522 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com