https://bugzilla.redhat.com/show_bug.cgi?id=1157302
Bug ID: 1157302 Summary: Review Request: oldkilim - A generic configuration framework for Java Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: wei.d.chen@intel.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/chendave/OAT2.X-fedora21-Dependencies/blob/master/oldkili... SRPM URL: https://github.com/chendave/OAT2.X-fedora21-Dependencies/blob/master/oldkili...
Could anyone give some review on this package, appreciate for any comments you drop by.
https://bugzilla.redhat.com/show_bug.cgi?id=1157302
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Blocks| |652183 (FE-JAVASIG)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1157302
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it
--- Comment #1 from gil cattaneo puntogil@libero.it --- The spec file should be cleanup, please remove:
Group: Development/Libraries/Java #Vendor: JPackage Project #Distribution: JPackage
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
Group: Development/Documentation
rm -rf $RPM_BUILD_ROOT in %install section
%clean rm -rf $RPM_BUILD_ROOT
%post javadoc
%postun javadoc
%defattr(0644,root,root,0755)
* jar and javadoc must be without version, e.g.
# jars install -d -m 755 $RPM_BUILD_ROOT%{_javadir} install -pm 644 distrib/kilim.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar install -pm 644 distrib/kilim-tools.jar $RPM_BUILD_ROOT%{_javadir}/%{name}-tools.jar
# javadoc install -p -d -m 755 $RPM_BUILD_ROOT%{_javadocdir}/%{name} cp -pr doc/apis/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}
%files javadoc %{_javadocdir}/%{name}
https://bugzilla.redhat.com/show_bug.cgi?id=1157302
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1157302
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it, | |wei.d.chen@intel.com Flags| |needinfo?(wei.d.chen@intel. | |com)
https://bugzilla.redhat.com/show_bug.cgi?id=1157302
Dave Chen wei.d.chen@intel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CANTFIX Flags|needinfo?(wei.d.chen@intel. | |com) | Last Closed| |2016-10-09 21:43:25
--- Comment #2 from Dave Chen wei.d.chen@intel.com --- Thanks gil for the review, no one is working on this anymore, will close the request.
https://bugzilla.redhat.com/show_bug.cgi?id=1157302
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
package-review@lists.fedoraproject.org