[Bug 2131199] New: Review Request: perl-Alien-m4 - Find GNU m4

https://bugzilla.redhat.com/show_bug.cgi?id=2131199

Bug ID: 2131199
           Summary: Review Request: perl-Alien-m4 - Find GNU m4
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-m4/perl-Alien-m4.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Alien-m4/perl-Alien-m4-0.21-1.fc38.src....
Description: This package can be used by other Perl modules that require GNU
m4.

Fedora Account System Username: ppisar

[Bug 2131199] Review Request: perl-Alien-m4 - Find GNU m4

https://bugzilla.redhat.com/show_bug.cgi?id=2131199

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-m4-0.21-1.fc38.x86_64.rpm | sort | uniq -c |
grep -v rpmlib
      1 m4 = 1.4.19
      1 perl(Alien::Base) >= 0.038
      1 perl(alienfile) >= 0.32
      1 perl(base)
      1 perl(Capture::Tiny)
      1 perl(Config)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Path::Tiny)
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.
$ rpm -qp --requires perl-Alien-m4-tests-0.21-1.fc38.noarch.rpm | sort | uniq
-c | grep -v rpmlib
      1 perl(Alien::m4)
      1 perl-Alien-m4 = 0.21-1.fc38
      1 perl(Config)
      1 perl(strict)
      1 perl(Test::Alien)
      1 perl-Test-Harness
      1 perl(warnings)
      1 /usr/bin/perl
      1 /usr/bin/sh
FIX: 'perl(Test2::V0)' and 'perl(Test::More)' should be listed as
     run-requires not build-requires.

$ rpm -qp --provides perl-Alien-m4-0.21-1.fc38.x86_64.rpm | sort | uniq -c
      1 perl(Alien::m4) = 0.21
      1 perl-Alien-m4 = 0.21-1.fc38
      1 perl-Alien-m4(x86-64) = 0.21-1.fc38
$ rpm -qp --provides perl-Alien-m4-tests-0.21-1.fc38.noarch.rpm | sort | uniq
-c
      1 perl-Alien-m4-tests = 0.21-1.fc38
Binary provides are Ok.

$ rpmlint ./perl-Alien-m4*
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4
perl-Alien-m4-tests.noarch: W: no-documentation
perl-Alien-m4.spec:39: W: comparison-operator-in-deptoken 2>/dev/null)
perl-Alien-m4.spec:39: W: comparison-operator-in-deptoken 2>/dev/null)
 3 packages and 1 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken
0.3 s 
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' item.

Resolution:
Approved

[Bug 2131199] Review Request: perl-Alien-m4 - Find GNU m4

https://bugzilla.redhat.com/show_bug.cgi?id=2131199

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 2131199] Review Request: perl-Alien-m4 - Find GNU m4

https://bugzilla.redhat.com/show_bug.cgi?id=2131199

--- Comment #2 from Petr Pisar  ---
Thanks for the review. You are right. The two dependencies was a copy-and-paste
mistake. I corrected them.

https://pagure.io/releng/fedora-scm-requests/issue/47990

[Bug 2131199] Review Request: perl-Alien-m4 - Find GNU m4

https://bugzilla.redhat.com/show_bug.cgi?id=2131199

--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Alien-m4

[Bug 2131199] Review Request: perl-Alien-m4 - Find GNU m4

https://bugzilla.redhat.com/show_bug.cgi?id=2131199

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED
   Fixed In Version|                            |perl-Alien-m4-0.21-1.fc38

[Bug 2131199] Review Request: perl-Alien-m4 - Find GNU m4

https://bugzilla.redhat.com/show_bug.cgi?id=2131199

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2022-10-07 07:32:23