[Bug 1475483] New: Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

Bug ID: 1475483
           Summary: Review Request: qbs - Cross platform build tool
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://smani.fedorapeople.org/review/qbs.spec
SRPM URL: https://smani.fedorapeople.org/review/qbs-1.8.1-1.fc27.src.rpm
Description: Cross platform build tool
Fedora Account System Username: smani

This package used to be built out of the qt-creator SRPM, but upstream notified
me that this is the wrong approach, in particular the version should not be the
one of qt-creator, but the actual qbs version (which is currently 1.8.1, hence
the epoch bump to obsolete the qbs using the qt-creator version, currently
4.3.2).

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20772211

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

Sandro Mani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1466775

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1466775
[Bug 1466775] qt-creator-v4.4.0-beta1 is available

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
http://wiki.qt.io/Qbs → https://
http://download.qt.io/official_releases/ → https://
> LGPLv2 and LGPLv3, with exceptions

I think this should be "LGPLv2 with exceptions and LGPLv3 with exceptions"
(following
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List).
> # qbs was previously packaged as part of qt-creator, using the qt-creator version
> Obsoletes:      %{name} < 0:4.4.0

Shouldn't this be "qt-creator < 0:4.4.0" instead?
Also, note that the new qt-creator package should have Obsoletes: %{name} <
0:4.4.0, so called self-obsoletes, so that both packages are installed during
upgrade.

s/Examples for projects/Example projects/

https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries are
needed.

Looks good otherwise.

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #2 from Sandro Mani  ---
Thanks for the comments and sorry for the late reply, I was trying to get the
tests working with upstream - still having some issues.

Uhm why obsoletes qt-creator? Qbs is currently a subpackage of qt-creator, it's
that package that should be obsoleted, not the entire qt-creator. Or am I
missing something?

Current version:
SPEC: https://smani.fedorapeople.org/review/qbs.spec
SRPM: https://smani.fedorapeople.org/review/qbs-1.8.1-2.fc27.src.rpm

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
dnf does not care which srpm a subpackage is built from. But there's no qbs
package with a version < 0:4.4.0, so the Obsoletes line right now does nothing.

But there's a different consideration: when upgrading, users who had
qt-creator-4.2.rpm installed, should get *both* qt-creator-4.4.rpm and qbs.rpm.
For that to happen, you make both packages obsolete the old name:

qt-creator: Obsoletes: %{name} < 0:4.4.0
qbs: Obsoletes: qt-creator < 0:4.4.0

Then when upgrading, dnf should install both subpackages. At least that's what
happened at some time with yum and should happen with dnf. There are bugs open
for some corner cases, it seems it doesn't always work, but doing this better
than nothing: https://bugzilla.redhat.com/show_bug.cgi?id=1261034, "Scenario
C".
> http://wiki.qt.io/Qbs → https://
> http://download.qt.io/official_releases/ → https://

Still there.

Package is APPROVED. Please fix the http URL when uploading. I think you should
add the Obsoletes, push qt-creator-4.4 and qbs in a single bodhi update, and
test if the upgrades work as expected.

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #4 from Sandro Mani  ---
The qbs subpackage is only f27+ with qt-creator-4.3.x, see [1]. This actually
makes it tricky now that I think of it though, since Obsoleting qbs will work
fine for current rawhide users, but users updating from f26 to f27 will indeed
hit the scenario you describe. So I think I actually have to obsolete both
qt-creator and qbs?

[1] https://koji.fedoraproject.org/koji/packageinfo?packageID=8039

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
OK, I wasn't aware of the subpackage in rawhide. But this doesn't really change
anything: dnf doesn't care from what srpm a binary subpackage originates. So
when you just move the subpackage from qt-creator to a new srpm, nothing needs
to be done (and the Obsoletes is not useful but harmless). So yeah, I still
think you need to add the two Obsoletes as described for F26→F27+ upgrades.

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #6 from Sandro Mani  ---
Okay, thanks for the review!

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #7 from Sandro Mani  ---
Uhm,

Problem 1: both package qbs-1:1.9.0-0.1.gita2fd0f3.fc27.x86_64 and
qt-creator-4.4.0-0.1.beta1.fc27.x86_64 obsolete qt-creator < 4.4.0
  - cannot install the best update candidate for package
qbs-4.3.1-2.fc27.x86_64

Would that be one of the issues in #1261034?

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
What was the command that gave this error?

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #9 from Sandro Mani  ---
Just a plain

# dnf update

By the way, since there is a DSO dependency

/usr/lib64/qtcreator/plugins/libQbsProjectManager.so -> libqbscore.so.1.8

it is already taken care of that updating qt-creator will also install the new
qbs. So actually I think no Obsoletes are even necessary.

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

--- Comment #10 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/qbs

[Bug 1475483] Review Request: qbs - Cross platform build tool

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

Sandro Mani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2017-08-02 07:33:32