https://bugzilla.redhat.com/show_bug.cgi?id=1907017
Bug ID: 1907017 Summary: Review Request: rust_libnotcurses_sys - rust wrappers for notcurses Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dank@qemfd.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec SRPM URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys-2.0.10-1.f... Description: Rust wrappers for the Notcurses TUI library Fedora Account System Username: nickblack
Created with rust2rpm.
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
Nick Black dank@qemfd.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Link ID| |Red Hat Bugzilla 1907016 | |Red Hat Bugzilla 1907014 Doc Type|--- |If docs needed, set a value
--- Comment #1 from Nick Black dank@qemfd.net --- Depends on 1907016 and 1907014.
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Summary|Review Request: |Review Request: |rust_libnotcurses_sys - |rust-libnotcurses-sys - |rust wrappers for notcurses |Rust wrappers for the | |Notcurses TUI library
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Corrected bug title for correct package name and summary. Also no longer depends on rust-serial_test, it is already packaged.
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
--- Comment #3 from Nick Black dank@qemfd.net --- I've updated the spec to include %license, which was missing in 1907014. I've rebuilt the SRPM against f34, and updated to the current upstream version 2.1.7.
https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys-2.0.10-1.f...
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
Igor Raits igor.raits@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |igor.raits@gmail.com
--- Comment #4 from Igor Raits igor.raits@gmail.com --- I think you still have copied wrong version :)
~ via 🐍 v3.9.1 ❯ curl https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec -s | grep %license
~ via 🐍 v3.9.1 ❯
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
--- Comment #5 from Nick Black dank@qemfd.net --- augh, i missed the 'fedora-rust' :/
[dank@localhost ~]$ curl https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec | grep -i license % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1972 100 1972 0 0 89636 0 --:--:-- --:--:-- --:--:-- 89636 # Upstream license specification: Apache-2.0 License: ASL 2.0 %license LICENSE-APACHE [dank@localhost ~]$
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #6 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- License is not in the crate:
+ cp -pr LICENSE-APACHE /builddir/build/BUILDROOT/rust-libnotcurses-sys-2.1.7-1.fc34.x86_64/usr/share/licenses/rust-libnotcurses-sys-devel cp: cannot stat 'LICENSE-APACHE': No such file or directory + : + RPM_EC=0 ++ jobs -p + exit 0 error: File not found: /builddir/build/BUILDROOT/rust-libnotcurses-sys-2.1.7-1.fc34.x86_64/usr/share/licenses/rust-libnotcurses-sys-devel/LICENSE-APACHE RPM build errors: File not found: /builddir/build/BUILDROOT/rust-libnotcurses-sys-2.1.7-1.fc34.x86_64/usr/share/licenses/rust-libnotcurses-sys-devel/LICENSE-APACHE
Upstream license file is LICENSE and it is not included in the crate. Ask upstream to do so.
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
--- Comment #7 from Nick Black dank@qemfd.net --- Good catch regarding the `LICENSE`, thanks. I've added it to the crate, and it will be present with the 2.1.8 release. I'm expecting that any day now, so I'll go ahead and push a new spec/SRPM when it drops.
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
--- Comment #8 from Nick Black dank@qemfd.net --- I've:
1) released a new 2.1.8 upstream crate, containing `LICENSE` 2) amended the spec file to point at `LICENSE` rather than `LICENSE-APACHE` 3) updated the spec file for 2.1.8 4) rebuilt the SRPM
Spec URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec SRPM URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys-2.1.8-1.fc...
The dep is now on libnotcurses 2.1.8, which is slated for rollout to f34.
Feel free to PTAL, and thanks for your patience!
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #9 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - There is a typo here, I assume you meant "Feb"
Wed Fed 03 09:37:51 EST 2021 nick black dankamongmen@gmail.com - 2.1.8-1
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
--- Comment #10 from Nick Black dank@qemfd.net --- Fixed the typo. Thanks so much!
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
--- Comment #11 from Nick Black dank@qemfd.net --- Module requested at https://pagure.io/releng/fedora-scm-requests/issue/32031
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
--- Comment #12 from Mohan Boddu mboddu@bhujji.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libnotcurses-sys
https://bugzilla.redhat.com/show_bug.cgi?id=1907017
Mattia Verga mattia.verga@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|POST |CLOSED Last Closed| |2022-02-21 09:50:04
--- Comment #13 from Mattia Verga mattia.verga@protonmail.com --- Package is in repositories (although it is FTB), closing review.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com