Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-aruba - CLI Steps for Cucumber, hand-crafted for you in Aruba
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Summary: Review Request: rubygem-aruba - CLI Steps for Cucumber, hand-crafted for you in Aruba Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bkabrda@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://bkabrda.fedorapeople.org/pkgs/aruba/rubygem-aruba.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/aruba/rubygem-aruba-0.4.11-1.fc17.src.r... Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4004597 Aruba is Cucumber extension for Command line applications written in any programming language.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@redhat.com AssignedTo|nobody@fedoraproject.org |vondruch@redhat.com Flag| |fedora-review?
--- Comment #1 from Vít Ondruch vondruch@redhat.com 2012-04-19 06:44:36 EDT --- I'll take it for a review ride.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
--- Comment #2 from Vít Ondruch vondruch@redhat.com 2012-04-19 07:18:04 EDT --- Seems that the gem dependencies are not fulfilled:
Error: Package: rubygem-aruba-0.4.11-1.fc18.noarch (/rubygem-aruba-0.4.11-1.fc18.noarch) Requires: rubygem(ffi) >= 1.0.11 Installed: rubygem-ffi-1.0.9-4.fc17.i686 (@fedora) rubygem(ffi) = 1.0.9
However, I am wondering why there is the FFI dependency at all, since there doesn't seems to be any code which uses it
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
--- Comment #3 from Vít Ondruch vondruch@redhat.com 2012-04-19 07:18:41 EDT --- Otherwise, the package looks good, I almost approved it ;)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
--- Comment #4 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com 2012-04-19 07:25:05 EDT --- I have asked upstream about the ffi dependency [1]. Basically, they only wanted the ffi version 1.0.10 not to be drawn in by childprocess. So I'll patch the gemspec and specfile properly.
[1] https://github.com/cucumber/aruba/issues/114
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
--- Comment #5 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com 2012-04-19 07:55:41 EDT --- Ok, so I have removed the ffi dependency, because it's not dependency of childprocess, not aruba itself. I added a "[Build]Conflicts: rubygem(ffi) = 1.0.10" so that the package won't install with this broken version of ffi.
SPEC: http://bkabrda.fedorapeople.org/pkgs/aruba/rubygem-aruba.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/aruba/rubygem-aruba-0.4.11-2.fc17.src.r... Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4005183
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Vít Ondruch vondruch@redhat.com 2012-04-19 08:18:31 EDT --- Thank you. While I don't like the "conflicts", I have no better solution on the other hand. So I APPROVE the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com 2012-04-19 08:40:09 EDT --- Thanks for your review!
New Package SCM Request ======================= Package Name: rubygem-aruba Short Description: CLI Steps for Cucumber, hand-crafted for you in Aruba Owners: bkabrda Branches: f17 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
--- Comment #8 from Jon Ciesla limburgher@gmail.com 2012-04-19 08:41:13 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2012-04-19 09:08:19 EDT --- rubygem-aruba-0.4.11-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-aruba-0.4.11-2.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-04-19 22:27:07 EDT --- rubygem-aruba-0.4.11-2.fc17 has been pushed to the Fedora 17 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |rubygem-aruba-0.4.11-2.fc17 Resolution| |ERRATA Last Closed| |2012-05-02 00:44:59
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2012-05-02 00:44:59 EDT --- rubygem-aruba-0.4.11-2.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Troy Dawson tdawson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tdawson@redhat.com Flags|fedora-cvs+ |fedora-cvs?
--- Comment #12 from Troy Dawson tdawson@redhat.com --- Package Change Request ====================== Package Name: rubygem-aruba New Branches: epel7 Owners: tdawson
https://bugzilla.redhat.com/show_bug.cgi?id=814071
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=814071
--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org