https://bugzilla.redhat.com/show_bug.cgi?id=2060710
Bug ID: 2060710 Summary: Review Request: golang-github-bep-goat - C bindings and an API for generating diagrams from ASCII art Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@flyn.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-goat.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-goat-0.5.0-1.fc35.src.rpm Description: C bindings and an API for generating diagrams from ASCII art. Fedora Account System Username: mikep
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Blocks| |1930952
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1930952 [Bug 1930952] hugo-0.93.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
Fabio Alessandro Locati me@fale.io changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |me@fale.io
--- Comment #1 from Fabio Alessandro Locati me@fale.io --- Trying to build this from SPEC against F37, I receive:
canvas_test.go:7:2: cannot find package "github.com/frankban/quicktest" in any of: /usr/lib/golang/src/github.com/frankban/quicktest (from $GOROOT)
/builddir/build/BUILD/goat-0.5.0/_build/src/github.com/frankban/quicktest (from $GOPATH) /usr/share/gocode/src/github.com/frankban/quicktest
I do not see the `%go_generate_buildrequires` nor explicit dependencies.
If rebuilt with go2rpm 1.6.0, I think it will self-fix
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #2 from W. Michael Petullo mike@flyn.org --- I rebuilt using go2rpm 1.6.1.
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
Fabio Alessandro Locati me@fale.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |me@fale.io
--- Comment #3 from Fabio Alessandro Locati me@fale.io --- Nice job!
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #4 from Fabio Alessandro Locati me@fale.io --- go2rpm package, fedora-review is correct:
- The specfile is sane. - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #5 from W. Michael Petullo mike@flyn.org --- Thank you, Fabio! Requested Git module: https://pagure.io/releng/fedora-scm-requests/issue/43649.
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-goat
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-175463cc01 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-175463cc01
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-04-13 17:25:55
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-175463cc01 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4a6ff273cf has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4a6ff273cf
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-e340b00ea4 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e340b00ea4
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4a6ff273cf has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4a6ff273cf *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4a6ff273cf
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-e340b00ea4 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-e340b00ea4 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e340b00ea4
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4a6ff273cf has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2060710
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-e340b00ea4 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org