Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: vim-perl-support - Perl-IDE for VIM
https://bugzilla.redhat.com/show_bug.cgi?id=473447
Summary: Review Request: vim-perl-support - Perl-IDE for VIM Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: iarnell@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://iarnell.fedorapeople.org/vim-perl-support.spec SRPM URL: http://iarnell.fedorapeople.org/vim-perl-support-3.9.1-1.fc11.src.rpm Description: Perl Support implements a Perl-IDE for Vim/gVim. It is written to considerably speed up writing code in a consistent style. This is done by inserting complete statements, comments, idioms, code snippets, templates, and POD documentation. Reading perldoc is integrated. Syntax checking, running a script, running perltidy, running perlcritics, starting a debugger and a profiler can be done with a keystroke.
note that rpmlint reports a false error:
vim-perl-support.noarch: E: non-executable-script /usr/share/vim/vimfiles/perl-support/templates/perl-file-header 0644
perl-file-header is a template for a perl script; the shebang is required, but the file should not be executable.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mmaslano@redhat.com
--- Comment #1 from Marcela Maslanova mmaslano@redhat.com 2008-12-03 09:50:09 EDT --- OK source files match upstream OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. ? license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package isn't need. OK rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. ? %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings.
Shouldn't you install %{vimfiles}/doc/perlsupport.txt into %doc?
I didn't find license anywhere in the package. Where could I check it?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
--- Comment #2 from Iain Arnell iarnell@gmail.com 2008-12-03 10:49:41 EDT --- %{vimfiles}/doc/perlsupport.txt needs to be where it is so that vim can make it available as part of its online help (just as vim itself has a bunch of documentation in /usr/share/vim/vim72/doc directory).
The license is in the header of plugin/perl-support.vim file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
Marcela Maslanova mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #3 from Marcela Maslanova mmaslano@redhat.com 2008-12-03 10:55:43 EDT --- Ok. The review was accepted.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Iain Arnell iarnell@gmail.com 2008-12-03 11:27:44 EDT --- New Package CVS Request ======================= Package Name: vim-perl-support Short Description: Perl-IDE for VIM Owners: iarnell Branches: F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2008-12-03 19:48:57 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2008-12-04 12:31:42 EDT --- vim-perl-support-3.9.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/vim-perl-support-3.9.1-1.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2008-12-04 12:31:45 EDT --- vim-perl-support-3.9.1-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/vim-perl-support-3.9.1-1.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2008-12-06 23:14:01 EDT --- vim-perl-support-3.9.1-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473447
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2008-12-06 23:30:39 EDT --- vim-perl-support-3.9.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org