Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-googlevoice - Python language bindings for the Google Voice API
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Summary: Review Request: python-googlevoice - Python language bindings for the Google Voice API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jeff@ocjtech.us QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://jcollie.fedorapeople.org/python-googlevoice.spec SRPM URL: http://jcollie.fedorapeople.org/python-googlevoice-0.4-1.fc12.src.rpm Description:
This project aims to bring the power of the Google Voice API to the Python language in a simple, easy-to-use manner. Currently it allows you to place calls, send sms, download voicemails/recorded messages, and search the various folders of your Google Voice Accounts. You can use the Python API or command line script to schedule calls, check for new received calls/sms, or even sync your recorded voicemails/calls. Works for Python 2 and Python 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@fedoraproject.org
--- Comment #1 from Thomas Spura tomspur@fedoraproject.org 2009-11-01 07:26:28 EDT --- Just a few comments:
- Can you remove the first unneed comment line? in %build the comment is also unneeded and CFLAGS="$RPM_OPT_FLAGS" can be removed
- When installed, there are 2 directories owed by googlevoice: 100K /usr/lib/python2.6/site-packages/googlevoice/ 776K /usr/share/doc/python-googlevoice-0.4
Could you split the doc into a subpackage, because if you just want to install the python files and no examples/documentation, you can save 88.6% with 2 extra packages. Possibly, that's why there are 2 sources, the normal tar.gz and the *-extras.zip. Upstream also wants to save space ;)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #2 from Jeffrey C. Ollie jeff@ocjtech.us 2009-11-01 14:50:08 EDT --- Spec URL: http://jcollie.fedorapeople.org/python-googlevoice.spec SRPM URL: http://jcollie.fedorapeople.org/python-googlevoice-0.4-2.fc12.src.rpm
I've removed the unneeded comments and the CFLAGS settings. However, I don't think that it really makes sense to split a package that's < 1MB installed and only 71KB uninstalled, even if it's mostly docs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Rakesh Pandit rpandit@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |rpandit@redhat.com Flag| |fedora-review?
--- Comment #3 from Rakesh Pandit rpandit@redhat.com 2010-01-08 05:42:55 EDT --- [x] - Ok, [-] Needs input, [na] - Not Applicable [-] Update to latest
That will include rename docs to doc and including: /usr/bin/asterisk-gvoice-setup /usr/bin/gvi
in %files section
[x] name fine [x] spec file name fine [x] egg files are getting generated [x] python-setuptools-devel included [x] rpmlint is happy [x] docs and examples are included [-] license fine, but neither source nor license copy present. May you tell upstream to mention about it some place in source tarball also and if possible in source files. BSD is okay. [x] byte compiled files included [x] source ok 835f3631192fa586341ac3da8b847812d5fd4cf1 pygooglevoice-0.4.tar.gz 4a1f19313812d4cc078e39ac9f40e9b4ab8ed432 pygooglevoice-0.4-extras.zip sha1sum matches [x] spec fields fine [x] %files section and permissions fine [x] American english and spec legible [x] File names in package valid UTF-8 [x] permissions file
Summary:
May you inform upstream about license bits and update the package to latest. Everything else seems to be fine.
Thanks,
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #4 from Rakesh Pandit rpandit@redhat.com 2010-05-11 10:05:07 EDT --- In case there is no response in a week, I will close this ticket as deferred.
Regards, Rakesh Pandit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #5 from Jeffrey C. Ollie jeff@ocjtech.us 2010-05-11 10:23:50 EDT --- Spec URL: http://jcollie.fedorapeople.org/python-googlevoice.spec SRPM URL: http://jcollie.fedorapeople.org/python-googlevoice-0.5-1.fc12.src.rpm
Sorry about taking so long with this, it just slipped my mind...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #6 from R P Herrold herrold@owlriver.com 2010-05-11 12:47:04 EDT --- looks as though the URL for at least part has rotted:
[herrold@centos-5 python-googlevoice]$ wget http://pygooglevoice.googlecode.com/files/pygooglevoice-0.5.extras.zip --2010-05-11 12:45:55-- http://pygooglevoice.googlecode.com/files/pygooglevoice-0.5.extras.zip Resolving pygooglevoice.googlecode.com... 74.125.115.82 Connecting to pygooglevoice.googlecode.com|74.125.115.82|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2010-05-11 12:45:55 ERROR 404: Not Found.
looking:
The requested URL /files/ was not found on this server.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #7 from Jeffrey C. Ollie jeff@ocjtech.us 2010-05-11 14:30:00 EDT --- Hmm, I'm not sure where you came up with that URL, but the last part should be "pygooglevoice-0.5-extras.zip" not "pygooglevoice-0.5.extras.zip".
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #8 from R P Herrold herrold@owlriver.com 2010-05-11 14:41:51 EDT --- /me: growl -- mutter, mutter -- lovely -- just ANOTHER naming scheme, burying a version mid file name
Thank you
-- Russ herrold
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Rakesh Pandit rpandit@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #9 from Rakesh Pandit rpandit@redhat.com 2010-05-12 02:19:59 EDT --- Every issue has been addressed.
So this package is APPROVED.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2181975
Thanks,
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Jeffrey C. Ollie jeff@ocjtech.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Jeffrey C. Ollie jeff@ocjtech.us 2010-05-12 07:47:09 EDT --- New Package CVS Request ======================= Package Name: python-googlevoice Short Description: Python language bindings for the Google Voice API Owners: jcollie Branches: devel F-13 F-12 EL-6 EL-5 InitialCC: jcollie
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #11 from Kevin Fenzi kevin@tummy.com 2010-05-12 13:13:33 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-05-13 11:18:44 EDT --- python-googlevoice-0.5-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-googlevoice-0.5-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-05-13 14:38:09 EDT --- python-googlevoice-0.5-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-googlevoice-0.5-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-05-13 14:52:03 EDT --- python-googlevoice-0.5-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-googlevoice-0.5-1.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-05-13 21:05:27 EDT --- python-googlevoice-0.5-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-googlevoice'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-googlevoice-0.5-1.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-05-15 16:20:10 EDT --- python-googlevoice-0.5-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-googlevoice'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-googlevoice-0.5-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-05-15 16:41:32 EDT --- python-googlevoice-0.5-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-googlevoice'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-googlevoice-0.5-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2010-05-21 21:45:29 EDT --- python-googlevoice-0.5-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-googlevoice-0.5-1.fc | |12 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2010-05-21 21:48:44 EDT --- python-googlevoice-0.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-googlevoice-0.5-1.fc |python-googlevoice-0.5-1.fc |12 |13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2010-06-03 10:59:01 EDT --- python-googlevoice-0.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-googlevoice-0.5-1.fc |python-googlevoice-0.5-1.el |13 |5
package-review@lists.fedoraproject.org