[Bug 2176837] New: Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

Bug ID: 2176837
           Summary: Review Request: godot3 - Godot 3.x compatibility
                    package, adapted from godot package
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://akien.fedorapeople.org/srpms/godot3.spec
SRPM URL: https://akien.fedorapeople.org/srpms/godot3-3.5.2-1.mga9.src.rpm=
Description: Multi-platform 2D and 3D game engine with a feature-rich editor
(version 3)
Fedora Account System Username: akien
Existing `godot` package: https://src.fedoraproject.org/rpms/godot
Diff of changes between godot-3.4.5-4 and godot3-3.5.2-1:
https://akien.fedorapeople.org/srpms/godot-to-godot3.diff

This follows bug 1552767 where the `godot` package was approved in 2018, and
I'm its current maintainer (as well as upstream project maintainer).

We just released Godot 4.0 as a major, compatibility breaking update, and we
would like to provide both versions in parallel to Fedora users, so they can
choose to stay on Godot 3.x for their existing projects, or port their projects
to Godot 4.x.

So this new package request is basically forking `godot` to `godot3`, with
appropriate renames, and updating the package from 3.4.5 to 3.5.2 while at it.

The main `godot` package will be upgraded to 4.0.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #2 from Neal Gompa  ---
This package is effectively a rename, and the diff is concentrated to that.

The package data is comprehensive, follows our guidelines, builds and installs,
and otherwise looks good.

PACKAGE APPROVED.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #3 from Neal Gompa  ---
I did notice that you have a note about bundling wslay because it's not
packaged. Can you put up a package review for that so we can unbundle it?

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #4 from Rémi Verschelde  ---
(In reply to Neal Gompa from comment #3)
> I did notice that you have a note about bundling wslay because it's not
> packaged. Can you put up a package review for that so we can unbundle it?

Yes I can :) Here we go: bug 2176889.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #5 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at https://src.fedoraproject.org/rpms/godot3

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #6 from Fedora Update System  ---
FEDORA-2023-1dddf8b462 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-1dddf8b462

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #7 from Fedora Update System  ---
FEDORA-2023-c2cf0d8528 has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2cf0d8528

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #8 from Fedora Update System  ---
FEDORA-2023-6d3bbb9b6d has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6d3bbb9b6d

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-c2cf0d8528 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-c2cf0d8528`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2cf0d8528

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-6d3bbb9b6d has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-6d3bbb9b6d`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6d3bbb9b6d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #11 from Fedora Update System  ---
FEDORA-2023-1dddf8b462 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-1dddf8b462

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|ON_QA                       |CLOSED
        Last Closed|                            |2023-03-15 00:17:06

--- Comment #12 from Fedora Update System  ---
FEDORA-2023-1dddf8b462 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #13 from Fedora Update System  ---
FEDORA-2023-6d3bbb9b6d has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2176837] Review Request: godot3 - Godot 3.x compatibility package, adapted from godot package

https://bugzilla.redhat.com/show_bug.cgi?id=2176837

--- Comment #14 from Fedora Update System  ---
FEDORA-2023-c2cf0d8528 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.