[Bug 996186] New: Review Request: python-argh - Unobtrusive argparse wrapper with natural syntax
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Bug ID: 996186 Summary: Review Request: python-argh - Unobtrusive argparse wrapper with natural syntax Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: bjoern.esser@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Description:
Building a command-line interface? Found yourself uttering “argh!” while struggling with the API of argparse? Don’t want to lose its power but don’t need the complexity?
python-argh provides a wrapper for argparse. Argparse is a very powerful tool; python-argh just makes it easy to use.
Koji Builds:
el5: no builds for RHEL5, guys; this needs Python >= 2.6 el6: http://koji.fedoraproject.org/koji/taskinfo?taskID=5808832 F18: http://koji.fedoraproject.org/koji/taskinfo?taskID=5808834 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5808836 Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=5808838
rpmlint (installed pkgs, rawhide):
python-argh.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python-argh.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse python-argh.noarch: W: spelling-error %description -l en_US Argparse -> Sparse, Parsec, Parse 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
fedora-review:
no issues found by automatic tests
Fedora Account System Username:
besser82
Urls:
Spec URL: http://besser82.fedorapeople.org/review/python-argh.spec SRPM URL: http://besser82.fedorapeople.org/review/python-argh-0.23.2-1.fc19.src.rpm
#####
Thanks for review in advance!
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Björn Esser bjoern.esser@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |python-argh
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Robert Rati rrati@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rrati@redhat.com Assignee|nobody@fedoraproject.org |rrati@redhat.com Flags| |fedora-review+
--- Comment #1 from Robert Rati rrati@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v3 or later)", "Unknown or generated". 19 files have unknown license. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-argh-0.23.2-1.fc20.noarch.rpm python-argh.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python-argh.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse python-argh.noarch: W: spelling-error %description -l en_US Argparse -> Sparse, Parsec, Parse 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint python-argh python-argh.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python-argh.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse python-argh.noarch: W: spelling-error %description -l en_US Argparse -> Sparse, Parsec, Parse 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:'
Requires -------- python-argh (rpmlib, GLIBC filtered): python(abi)
Provides -------- python-argh: python-argh
Source checksums ---------------- https://pypi.python.org/packages/source/a/argh/argh-0.23.2.tar.gz : CHECKSUM(SHA256) this package : 7e7b41f7d6156da42e9643deea78fff09adb80672cd4d7e3da6d12a27d94407b CHECKSUM(SHA256) upstream package : 7e7b41f7d6156da42e9643deea78fff09adb80672cd4d7e3da6d12a27d94407b
Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 996186 -m fedora-rawhide-x86_64
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Björn Esser bjoern.esser@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-cvs?
--- Comment #2 from Björn Esser bjoern.esser@gmail.com --- Thanks for the review, Rob!
#####
New Package SCM Request ======================= Package Name: python-argh Short Description: Unobtrusive argparse wrapper with natural syntax Owners: besser82 Branches: el6 f18 f19 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=996186
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=996186
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- python-argh-0.23.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-argh-0.23.2-1.el6
https://bugzilla.redhat.com/show_bug.cgi?id=996186
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-argh-0.23.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-argh-0.23.2-1.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=996186
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-argh-0.23.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-argh-0.23.2-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-argh-0.23.2-1.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-argh-0.23.2-1.fc19 Resolution|--- |ERRATA Last Closed| |2013-08-23 19:54:33
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-argh-0.23.2-1.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-argh-0.23.2-1.fc19 |python-argh-0.23.2-1.fc18
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-argh-0.23.2-1.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-argh-0.23.2-1.fc18 |python-argh-0.23.2-1.el6
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-argh-0.23.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=996186
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|python-argh |
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla