[Bug 1665614] New: Review Request: libsecp256k1 - Optimized C library for EC operations on curve secp256k1
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
Bug ID: 1665614 Summary: Review Request: libsecp256k1 - Optimized C library for EC operations on curve secp256k1 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: hegjon@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fedorapeople.org/~jonny/libsecp256k1/libsecp256k1.spec SRPM URL: https://fedorapeople.org/~jonny/libsecp256k1/libsecp256k1-0-0.20181126gite34... Description: Optimized C library for EC operations on curve secp256k1 Fedora Account System Username: jonny
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
--- Comment #1 from Jonny Heggheim hegjon@gmail.com --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31970520
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - Please don't use a glob for the major soname version to avoid unintentional soname bump:
%{_libdir}/%{name}.so.0*
- Pre-Release should start at 0.1
- Please add the Version-Release info in your %changelog entry:
* Fri Jan 11 2019 Jonny Heggheim hegjon@gmail.com - 0-0.1.20181126gite34ceb3
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "FSF All Permissive License", "Expat License", "Unknown or generated", "Apache License (v2.0)". 81 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/libsecp256k1/review- libsecp256k1/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libsecp256k1-debuginfo , libsecp256k1-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: libsecp256k1-0-0.20181126gite34ceb3.fc30.x86_64.rpm libsecp256k1-devel-0-0.20181126gite34ceb3.fc30.x86_64.rpm libsecp256k1-debuginfo-0-0.20181126gite34ceb3.fc30.x86_64.rpm libsecp256k1-debugsource-0-0.20181126gite34ceb3.fc30.x86_64.rpm libsecp256k1-0-0.20181126gite34ceb3.fc30.src.rpm libsecp256k1.x86_64: W: no-version-in-last-changelog libsecp256k1-devel.x86_64: W: no-version-in-last-changelog libsecp256k1-debuginfo.x86_64: W: no-version-in-last-changelog libsecp256k1-debugsource.x86_64: W: no-version-in-last-changelog libsecp256k1.src: W: no-version-in-last-changelog 5 packages and 0 specfiles checked; 0 errors, 5 warnings
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
--- Comment #3 from Jonny Heggheim hegjon@gmail.com --- Thanks for the review. I have updated the files.
(In reply to Robert-André Mauchin from comment #2)
- Please don't use a glob for the major soname version to avoid
unintentional soname bump:
%{_libdir}/%{name}.so.0*
Great, I did not consider that.
- Pre-Release should start at 0.1
I would not classify it as a pre-release, upstream have never released a version and there are no signs that they are planning a release.
I feel it falls between: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_upstr...
and
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snaps...
- Please add the Version-Release info in your %changelog entry:
- Fri Jan 11 2019 Jonny Heggheim hegjon@gmail.com -
0-0.1.20181126gite34ceb3
Thanks, missed that one.
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Package is approved.
Sorry for the delay.
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
--- Comment #5 from Jonny Heggheim hegjon@gmail.com --- (In reply to Robert-André Mauchin from comment #4)
Package is approved.
Sorry for the delay.
Thanks, no worries, I have been busy recently.
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libsecp256k1
https://bugzilla.redhat.com/show_bug.cgi?id=1665614
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2019-04-02 07:54:55
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com