[Bug 1201325] New: Review Request: python-oslo-context - OpenStack Oslo context library - package-review

List overview All Threads
Download

newer

[Bug 1201325] New: Review Request: python-oslo-context - OpenStack Oslo context library

older

[Bug 1121358] New: Review Request:...

[Bug 1207847] New: Review Request:...

Red Hat Bugzilla

12 Mar 2015 12 Mar '15

8:52 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Bug ID: 1201325 Summary: Review Request: python-oslo-context - OpenStack Oslo context library Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: chkumar246@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://chandankumar.fedorapeople.org/python-oslo-context.spec SRPM URL: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-1.fc21.src.r... Description: The OpenStack Oslo context library has helpers to maintain useful information about a request context. The request context is usually populated in the WSGI pipeline and used by various modules such as logging.

Fedora Account System Username: chandankumar

Successful Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9210068

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

13 Mar 13 Mar

3:46 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Parag AN(पराग) panemade@gmail.com changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:27 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Suggestions: 1) Group tag is optional in Fedora and is only needed if you want this package to be built for EPEL5. See http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag. You can remove Group tag.

2) from https://pypi.python.org/pypi/oslo.context page, this module looks compatible with python3 also. Therefore, add python3 subpackage.

3) Remove last unnecessary changelog entry

4) in %files Following is wrong %doc %{license} This should be written as %doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog %license LICENSE

Then, using following lines you are installing files twice. %{python2_sitelib}/ %{python2_sitelib}/oslo_context Change this to just %{python2_sitelib}/oslo_context

5) Add -doc subpackage like other python-oslo-* packages are providing in Fedora. you can build documentation in %install using

pushd doc sphinx-build -b html -d build/doctrees source build/html popd

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:24 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- just found there is no python-pytz package available but only pytz. Change the dependency.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

24 Mar 24 Mar

4:37 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #3 from Chandan Kumar chkumar246@gmail.com --- Hello Parag,

Thanks for the review. Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-2.fc21.src.r...

and koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9309575

Please have a look.

Thanks,

Chandan Kumar

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:51 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #4 from Chandan Kumar chkumar246@gmail.com --- Hi Parag,

I have again updated the SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-3.fc21.src.r... and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9309651

Please have a look.

Thanks,

Chandan Kumar

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:57 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- Hi Chandan, Thanks for the updated package and sorry for confusing you about using sphinx-build in %install. I asked on packaging list and got the confirmation that it should be used in %build. Actually, I got confused by other oslo library packaging. E.g. See http://pkgs.fedoraproject.org/cgit/python-oslo-config.git/tree/python-oslo-c... http://pkgs.fedoraproject.org/cgit/python-oslo-messaging.git/tree/python-osl...

Can you please provide one last update here and I will approve this package. Move the documentation building to %build.

Thanks.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

25 Mar 25 Mar

1:35 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #6 from Chandan Kumar chkumar246@gmail.com --- Hello Parag,

Thanks for the review, Here is my updated SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec SPRM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-4.fc21.src.r...

and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9318185

Thanks,

Chandan Kumar

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:50 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- Looks good now.

APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Mar 27 Mar

3:22 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Chandan Kumar chkumar@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |chkumar@redhat.com

--- Comment #8 from Chandan Kumar chkumar@redhat.com --- Hello Parag,

Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-5.fc21.src.r...

and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9345006

Thanks,

Chandan Kumar

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:24 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #9 from Chandan Kumar chkumar@redhat.com --- Done review of following package review requests: https://bugzilla.redhat.com/show_bug.cgi?id=1206067 and https://bugzilla.redhat.com/show_bug.cgi?id=1206086

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:40 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #10 from Parag AN(पराग) panemade@gmail.com --- update looks good again :)

Thanks for the reviews.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:46 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:15 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Chandan Kumar chkumar246@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #11 from Chandan Kumar chkumar246@gmail.com --- New Package SCM Request ======================= Package Name: python-oslo-context Short Description: OpenStack Oslo context library Upstream URL: https://pypi.python.org/pypi/oslo.context Owners: chandankumar Branches: f22 InitialCC: apevec

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:32 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:32 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Mar 30 Mar

12:16 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:16 a.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-oslo-context-0.2.0-5.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-oslo-context-0.2.0-5.fc22

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

31 Mar 31 Mar

5:01 p.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-oslo-context-0.2.0-5.fc22 has been pushed to the Fedora 22 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Jun 5 Jun

7:13 p.m.

New subject: [Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library

https://bugzilla.redhat.com/show_bug.cgi?id=1201325

Fedora Update System updates@fedoraproject.org changed:

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-oslo-context-0.2.0-5.fc22 has been pushed to the Fedora 22 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3699

Age (days ago)

3785

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla