[Bug 187243] Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

https://bugzilla.redhat.com/show_bug.cgi?id=187243

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-06-02 20:24 EST -------
Actually that package seems to build OK for me in current rawhide, except that
things crap out at the very end of the process:

extracting debug info from
/var/tmp/lazarus-0.9.24-3.fc10-root-mockbuild/usr/lib64/lazarus/tools/svn2revisioninc
extracting debug info from
/var/tmp/lazarus-0.9.24-3.fc10-root-mockbuild/usr/lib64/lazarus/lazarus
/usr/lib/rpm/debugedit:
canonicalization unexpectedly shrank by one character

which is completely bewildering, but according to comments in bug 304121 it's
caused by a doubled slash somewhere making it into the debug data.  I removed
the trailing slash from the FPCDIR export in the %build section and it builds
fine now.

Honestly all of my complaints have been taken care of.  The newly-enabled
debuginfo package doesn't actually include the source, probably due to many
complaints like the following:

/usr/lib/rpm/debugedit:
/var/tmp/lazarus-0.9.24-3.fc10-root-mockbuild/usr/lib64/lazarus/lazarus: Wrong
directory table index 3

but honestly I'm not going to hold this up because fpc and rpm-build disagree on
how to extract debuginfo data.  Maybe you can figure out what's going on after
this is imported.

Honestly, the only issue I can see is that trailing slash, which you can
trivially fix up when you check in.

APPROVED