[Bug 570627] New: Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cppi - C preprocessor directive indenter

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Summary: Review Request: cppi - C preprocessor directive
                    indenter
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://kalev.fedorapeople.org/cppi.spec
SRPM URL: http://kalev.fedorapeople.org/cppi-1.14-1.fc14.src.rpm
Description:
Cppi indents the C preprocessor directives to reflect their nesting and ensures
that there is exactly one space character between each #if, #elif, #define
directive and the following token.

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Jim Meyering  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Jim Meyering  2010-03-13 05:58:25 EST ---
rpmlint passed:

cppi.src: W: spelling-error Summary(en_US) preprocessor -> processor,
teleprocessing, processional
cppi.src: W: spelling-error Summary(en_US) indenter -> indented, ind enter,
ind-enter
cppi.src: W: spelling-error %description -l en_US preprocessor -> processor,
teleprocessing, processional
cppi.src: W: spelling-error %description -l en_US elif -> elf, lief, life
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

But "rpmbuild -ba cppi.spec" fails like this:

+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id
/home/j/rpmbuild/BUILD/cppi-1.14
extracting debug info from
/home/j/rpmbuild/BUILDROOT/cppi-1.14-1.fc12.x86_64/usr/bin/cppi
*** ERROR: No build ID note found in
/home/j/rpmbuild/BUILDROOT/cppi-1.14-1.fc12.x86_64/usr/bin/cppi
error: Bad exit status from /var/tmp/rpm-tmp.lqEfeN (%install)

Is there a better way?

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #2 from Kalev Lember  2010-03-13 09:03:46 EST ---
This is strange. I don't get this error on my local machine and koji scratch
build (F-12, so that results are comparable with your machine) also succeeds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2050634

See this build log for example (F-12 x86_64):
http://koji.fedoraproject.org/koji/getfile?taskID=2050636&name=build.log

When gcc is used as a linker, it should pass --build-id option to ld. Perhaps
you have modified gcc or binutils installed on your machine which don't support
that?

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #3 from Jim Meyering  2010-03-13 10:09:44 EST ---
Good!  It's my fault after all.

I had confirmed that I was using F12's /usr/bin/gcc, but I had a stray
x86_64-unknown-linux-gnu-gcc earlier in my path.  Removing that solved the
problem.

Will resume on Monday.

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #4 from Jim Meyering  2010-03-18 05:34:54 EDT ---
I've gone through the must and should checklists
(the latter prompted me to make a new upstream release:
http://lists.gnu.org/archive/html/bug-cppi/2010-03/msg00010.html)
and everything looks like it's in order, so when you update your spec for 1.15,
let me know and I'll take one final look and set the flag here.

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Kalev Lember  2010-03-18 06:53:24 EDT ---
* Thu Mar 18 2010 Kalev Lember  - 1.15-1
- Updated to cppi 1.15

Spec URL: http://kalev.fedorapeople.org/cppi.spec
SRPM URL: http://kalev.fedorapeople.org/cppi-1.15-1.fc14.src.rpm
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2060492

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #6 from Jim Meyering  2010-03-18 08:22:27 EDT ---
Thanks, I've confirmed that this too builds.
spec diffs are trivial, as expected.  ACK!

Odd... I'm currently unable to set fedora‑review = +

http://thread.gmane.org/gmane.linux.redhat.fedora.devel/130810/focus=130811

even though I've just changed my FAS email address to match the BZ one.

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Jim Meyering  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #7 from Kalev Lember  2010-03-18 09:26:15 EDT ---
Thank you for the review!

New Package CVS Request
=======================
Package Name: cppi
Short Description: C preprocessor directive indenter
Owners: kalev meyering
Branches: F-11 F-12 F-13
InitialCC:

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #8 from Kevin Fenzi  2010-03-19 15:51:52 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #10 from Fedora Update System  2010-03-19 17:36:44 EDT ---
cppi-1.15-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/cppi-1.15-1.fc11

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #9 from Fedora Update System  2010-03-19 17:36:39 EDT ---
cppi-1.15-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/cppi-1.15-1.fc12

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #11 from Fedora Update System  2010-03-19 17:36:48 EDT ---
cppi-1.15-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/cppi-1.15-1.fc13

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #12 from Fedora Update System  2010-03-22 21:57:06 EDT ---
cppi-1.15-1.fc13 has been pushed to the Fedora 13 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cppi'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/cppi-1.15-1.fc13

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #13 from Fedora Update System  2010-03-22 22:01:51 EDT ---
cppi-1.15-1.fc11 has been pushed to the Fedora 11 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cppi'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/cppi-1.15-1.fc11

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #14 from Fedora Update System  2010-03-22 22:06:54 EDT ---
cppi-1.15-1.fc12 has been pushed to the Fedora 12 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cppi'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/cppi-1.15-1.fc12

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #15 from Fedora Update System  2010-03-26 20:59:04 EDT ---
cppi-1.15-1.fc12 has been pushed to the Fedora 12 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |cppi-1.15-1.fc12
         Resolution|                            |ERRATA

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #16 from Fedora Update System  2010-03-26 20:59:45 EDT ---
cppi-1.15-1.fc11 has been pushed to the Fedora 11 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|cppi-1.15-1.fc12            |cppi-1.15-1.fc11

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #17 from Eric Blake  2010-04-02 13:07:28 EDT ---
Any reason cppi was removed from F13:

http://lists.fedoraproject.org/pipermail/test/2010-April/089871.html

even though it is now in F11 and F12?

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #18 from Kalev Lember  2010-04-03 14:55:21 EDT ---
F-13 is in Beta freeze, and the packages that were removed were actually F-12
packages that had inherited into F-13 through F-12 updates. See Jesse Keating's
mail for more explanations:
http://lists.fedoraproject.org/pipermail/devel/2010-April/134347.html

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

--- Comment #19 from Fedora Update System  2010-04-09 00:27:08 EDT ---
cppi-1.15-1.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 570627] Review Request: cppi - C preprocessor directive indenter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=570627

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|cppi-1.15-1.fc11            |cppi-1.15-1.fc13