https://bugzilla.redhat.com/show_bug.cgi?id=1868602
Bug ID: 1868602 Summary: Review Request: clevis-pin-tpm2 - Clevis PIN for unlocking with TPM2 supporting Authorized Policies Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pbrobinson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC: https://pbrobinson.fedorapeople.org/clevis-pin-tpm2.spec SRPM: https://pbrobinson.fedorapeople.org/clevis-pin-tpm2-0.1.1-1.fc32.src.rpm
Description: Clevis PIN for unlocking with TPM2 supporting Authorized Policies
FAS: pbrobinson
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1269538 (IoT) Depends On| |1862965 (rust-tpm2-policy), | |1862554 (rust-biscuit), | |1847906 (rust-tss-esapi) Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1847906 [Bug 1847906] Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API https://bugzilla.redhat.com/show_bug.cgi?id=1862554 [Bug 1862554] Review Request: rust-biscuit - Library to work with Javascript Object Signing and Encryption(JOSE) https://bugzilla.redhat.com/show_bug.cgi?id=1862965 [Bug 1862965] Review Request: rust-tpm2-policy - Specify and send TPM2 policies to satisfy object authorization
https://bugzilla.redhat.com/show_bug.cgi?id=1868602 Bug 1868602 depends on bug 1862965, which changed state.
Bug 1862965 Summary: Review Request: rust-tpm2-policy - Specify and send TPM2 policies to satisfy object authorization https://bugzilla.redhat.com/show_bug.cgi?id=1862965
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The license needs to be approved. There's a thread of fedora-legal from June about it. I sent a reminder.
Then, the license will need to be added to rust2rpm so it is translated properly from the SPDX tag. That isn't blocking, it can be adjusted manually until rust2rpm is updated.
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|unspecified |high Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The license has been approved.
+ package name is OK + license is acceptable for Fedora (EUPL-1.2) - license is specified correctly: needs to be "EUPL 1.2" + builds and installs OK + spec file is generated by rust2rpm, so it should be OK
rpmlint: clevis-pin-tpm2-debuginfo.x86_64: W: invalid-license EUPL-1.2 See above.
clevis-pin-tpm2-debuginfo.x86_64: W: invalid-url URL: https://github.com/fedora-iot/clevis-pin-tpm2/ <urlopen error [Errno -3] Temporary failure in name resolution> False positive.
clevis-pin-tpm2.x86_64: W: incoherent-version-in-changelog 0.0.1-1 ['0.1.1-1.fc34', '0.1.1-1'] Please fix.
clevis-pin-tpm2.x86_64: W: ldd-failed /usr/bin/clevis-pin-tpm2 I guess it's related to rust and static linking. Probably not an issue.
clevis-pin-tpm2.x86_64: W: no-documentation clevis-pin-tpm2.x86_64: E: non-standard-executable-perm /usr/bin/clevis-pin-tpm2 555 Yeah, 0755 is expected.
clevis-pin-tpm2.x86_64: W: no-manual-page-for-binary clevis-pin-tpm2 3 packages and 0 specfiles checked; 1 errors, 10 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
clevis-pin-tpm2.x86_64: W: ldd-failed /usr/bin/clevis-pin-tpm2 I guess it's related to rust and static linking. Probably not an issue.
Actually it's the mock/systemd-nspawn/glibc-2.32 issue. The binary is OK.
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
--- Comment #4 from Peter Robinson pbrobinson@gmail.com --- Seeing a build fail on 32 bit arches, filed bug for upstream: https://koji.fedoraproject.org/koji/taskinfo?taskID=49639122 https://github.com/fedora-iot/clevis-pin-tpm2/issues/2
https://bugzilla.redhat.com/show_bug.cgi?id=1868602 Bug 1868602 depends on bug 1862554, which changed state.
Bug 1862554 Summary: Review Request: rust-biscuit - Library to work with Javascript Object Signing and Encryption(JOSE) https://bugzilla.redhat.com/show_bug.cgi?id=1862554
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
--- Comment #5 from Peter Robinson pbrobinson@gmail.com --- SPEC: https://pbrobinson.fedorapeople.org/clevis-pin-tpm2.spec SRPM: https://pbrobinson.fedorapeople.org/clevis-pin-tpm2-0.1.2-1.fc32.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=49786522
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- License is still wrong, should be "EUPL 1.2", please fix before uploading.
$ rpmlint clevis-pin-tpm2-0.1.2-1.fc34.x86_64.rpm clevis-pin-tpm2.x86_64: W: invalid-license EUPL-1.2 clevis-pin-tpm2.x86_64: W: no-documentation clevis-pin-tpm2.x86_64: W: no-manual-page-for-binary clevis-pin-tpm2 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/clevis-pin-tpm2
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-08-25 10:36:53
https://bugzilla.redhat.com/show_bug.cgi?id=1868602
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2030272
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2030272 [Bug 2030272] Review Request: rust-josekit - JOSE (Javascript Object Signing and Encryption) library for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1868602 Bug 1868602 depends on bug 2030272, which changed state.
Bug 2030272 Summary: Review Request: rust-josekit - JOSE (Javascript Object Signing and Encryption) library for Rust https://bugzilla.redhat.com/show_bug.cgi?id=2030272
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
package-review@lists.fedoraproject.org