https://bugzilla.redhat.com/show_bug.cgi?id=970436
Bug ID: 970436 Summary: Review Request: mingw-kde-filesystem - KDE filesystem layout Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: ulatekh@yahoo.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: https://www.box.com/s/oynq8j01fzcmpt8fwjxq SRPM URL: https://www.box.com/s/oms01ttdehwg835zvppu Description: This package provides some directories that are required/used by KDE. This is the MinGW version of a package that Fedora already has in its repository. Fedora Account System Username: ulatekh
https://bugzilla.redhat.com/show_bug.cgi?id=970436
Steve ulatekh@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
https://bugzilla.redhat.com/show_bug.cgi?id=970436
Steve ulatekh@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |970438
https://bugzilla.redhat.com/show_bug.cgi?id=970436
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |msuchy@redhat.com Assignee|nobody@fedoraproject.org |msuchy@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=970436
--- Comment #1 from Miroslav Suchý msuchy@redhat.com --- Please use macros consistently I.e. instead of $RPM_BUILD_ROOT please use %{buildroot}.
%defattr(-,root,root,-) This is not needed since rpm 4.2
mingw-kde-filesystem.spec:182: W: mixed-use-of-spaces-and-tabs (spaces: line 64, tab: line 182)
# teamnames (locales) borrowed from kde-i18n packaging Source1: teamnames
Do you use it somewhere. It seems to me, that it is not used at all.
The same goes for:
Source2: macros.kde4
And then you are creating dynamically cat >$RPM_BUILD_ROOT%{mingw32_sysconfdir}/rpm/macros.kde4<<EOF
So I would suggest to put your content in macros.kde4 which you include as SourceX and the just do: cp -a macros.kde4 %{buildroot}%{mingw32_sysconfdir}/rpm/macros.kde4
https://bugzilla.redhat.com/show_bug.cgi?id=970436
--- Comment #2 from Miroslav Suchý msuchy@redhat.com --- Ping! Any progress?
https://bugzilla.redhat.com/show_bug.cgi?id=970436
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |DEFERRED Last Closed| |2016-01-07 08:25:19
--- Comment #3 from Miroslav Suchý msuchy@redhat.com --- Still no progress. Closing for now. If you ever want to continue, feel free to reopen this bug or file new one.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org