Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239
Summary: Review Request: arrows - Neat little maze game Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/arrows.spec SRPM URL: http://people.atrpms.net/~hdegoede/arrows-0.6-1.fc7.src.rpm Description: It's a maze game of sorts. Guide the spinning blue thing through the maze of arrows, creating and destroying arrows as necessary to collect the green things.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: arrows - Neat little maze game Alias: arrows
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |chris.stone@gmail.com OtherBugsDependingO|163776 |163778 nThis| | Alias| |arrows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: arrows - Neat little maze game Alias: arrows
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239
------- Additional Comments From chris.stone@gmail.com 2006-11-25 12:41 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec filename matches %{name} - package meets Packaging Guidelines - package licensed with open source compatible license - license matches actual license - license file included in %doc - spec written in American english - spec is legible - sources match upstream d6cf52ff319c295b9fb6982c023ec7f0 arrows-0.6.tar.gz - successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates X package uses a directory it doesnt create and I cannot determine if its pulled in from Requires packages. This package puts an icon in /usr/share/icons/hicolor/24x24/apps/ - no duplicates in %files - file permissions set properly - package contains proper %clean - macro usage consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files O desktop file installed properly (although see my comment in SHOULD fix) - package does not own files or directories owned by other packages
==== MUST FIX ==== - Shouldn't this require some package to get the icon dir? If not, please tell me how I determine which Requires would pull this in. Perhaps Require: gnome-icon-theme? Or hicolor-icon-theme if you decide to move this out of the GNOME menu (see SHOULD FIX section).
==== SHOULD FIX ==== - I'm not sure I agree all games compiled with gtk2 should be placed under GNOME->Games. I think GNOME->Games should be for games that are distributed with GNOME much like KDE has their kde-games package. This may require further discussion on the fedora-games-list. Not a blocker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: arrows - Neat little maze game Alias: arrows
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-25 15:37 EST ------- (In reply to comment #1)
==== MUST FIX ====
- Shouldn't this require some package to get the icon dir? If not, please tell
me how I determine which Requires would pull this in. Perhaps Require: gnome-icon-theme? Or hicolor-icon-theme if you decide to move this out of the GNOME menu (see SHOULD FIX section).
Yes it should have a "Requires: hicolor-icon-theme", my bad , fixed.
==== SHOULD FIX ====
- I'm not sure I agree all games compiled with gtk2 should be placed under
GNOME->Games. I think GNOME->Games should be for games that are distributed with GNOME much like KDE has their kde-games package. This may require further discussion on the fedora-games-list. Not a blocker.
I took that GNOME entry in the .desktop over from the package on which I based mine, but I agree it isn't a gnome app, dropped.
New version here: Spec URL: http://people.atrpms.net/~hdegoede/arrows.spec SRPM URL: http://people.atrpms.net/~hdegoede/arrows-0.6-2.fc7.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: arrows - Neat little maze game Alias: arrows
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From chris.stone@gmail.com 2006-11-25 15:57 EST ------- All MUST/SHOULD items fixed.
Please re-check scummvm spec for icon issue mentioned here, I might have missed this on my review of scummvm.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: arrows - Neat little maze game Alias: arrows
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-25 16:17 EST ------- Thanks, imported and build, closing.
p.s.
scummvm is fine.
package-review@lists.fedoraproject.org