[Bug 2338639] New: Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Bug ID: 2338639
           Summary: Review Request: rust-imago - Virtual machine disk
                    image access library
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://copr-dist-git.fedorainfracloud.org/cgit/hczenczek/rust-imago/rust-im...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/hczenczek/rust-imago/srpm...
Description: This package contains library source for building other packages
which use the "imago" crate (specifically libkrun)
Fedora Account System Username: hczenczek

Alternative spec URL (copr-dist-git is down right now):
https://czenczek.de/rust-imago.spec

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Hanna Czenczek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

--- Comment #1 from Hanna Czenczek  ---
Note a potential ix86 issue: The vm-memory feature package
(rust-imago+vm-memory-devel) depends on rust-vm-memory-devel, which is not
available for ix86. As far as I understand, I don’t need to explicitly exclude
ix86 in this package, though, right?

(FWIW, this package can be built successfully for i386:
https://copr.fedorainfracloud.org/coprs/hczenczek/rust-imago/build/8512815/)

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/im
                   |                            |ago
           Keywords|                            |AutomationTriaged

--- Comment #2 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8528110
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Cole Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?
                   |                            |needinfo?([e-mail]
                   |                            |)

--- Comment #3 from Cole Robinson  ---
I'll take this, and I can sponsor you too.

src.rpm link is broken too but I found spec and src.rpm here:
https://download.copr.fedorainfracloud.org/results/hczenczek/rust-imago/fedo...

nothing here looks surprising but I didn't do a deep dive yet. couple bits up
front:

can you convert this package to use rust2rpm.toml, and post the contents of
that file? this rust crates easier to review: I can manually regenerate the
package to make sure nothing weird is going on. makes it easier to maintain in
dist-git too.

the manual dep tweaks should be described in a comment. rust2rpm.toml has
support for this, see cargo-toml-patch-comments example here:
https://bugzilla.redhat.com/show_bug.cgi?id=2326979#c14

(In reply to Hanna Czenczek from comment #1)
> Note a potential ix86 issue: The vm-memory feature package
> (rust-imago+vm-memory-devel) depends on rust-vm-memory-devel, which is not
> available for ix86. As far as I understand, I don’t need to explicitly
> exclude ix86 in this package, though, right?
>
> (FWIW, this package can be built successfully for i386:
> https://copr.fedorainfracloud.org/coprs/hczenczek/rust-imago/build/8512815/)

AFAIK if it builds, it's fine :)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Hanna Czenczek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |)                           |

--- Comment #4 from Hanna Czenczek  ---
> I'll take this, and I can sponsor you too.

Thanks a lot!
> can you convert this package to use rust2rpm.toml, and post the contents of that file?

I’m not sure I follow.  I did use rust2rpm, but actually without any config
file (just `rust2rpm -t fedora -o spec imago`).  That is to say, the
rust2rpm.toml would currently be empty.
> the manual dep tweaks should be described in a comment.

It’s not a manual tweak, it’s been auto-generated by rust2rpm.  Adding such a
`package.cargo-toml-patch-comments` section to rust2rpm.toml makes it complain
that “Cargo.toml was not patched” (the Cargo.toml it wants me to modify already
has the Windows section removed as per that auto-generated patch).

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

--- Comment #5 from Cole Robinson  ---
(In reply to Hanna Czenczek from comment #4)
> I’m not sure I follow.  I did use rust2rpm, but actually without any config
> file (just `rust2rpm -t fedora -o spec imago`).  That is to say, the
> rust2rpm.toml would currently be empty.
> > the manual dep tweaks should be described in a comment.
>
> It’s not a manual tweak, it’s been auto-generated by rust2rpm.  Adding such
> a `package.cargo-toml-patch-comments` section to rust2rpm.toml makes it
> complain that “Cargo.toml was not patched” (the Cargo.toml it wants me to
> modify already has the Windows section removed as per that auto-generated
> patch).

Ah, I did not realize rust2rpm autogenerated a patch sometimes!
I should have looked closer at the spec comment.
I thought that patch came from `rust2rpm --patch`.
So I've learned something new :)

Indeed I see `rust2rpm -t fedora -o spec imago` generates spec
identical to yours. So I'll do full review now.

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Cole Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Cole Robinson  ---
Everything looks good to me. Template courtesy of decathorpe:

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

I've sponsored you into the packager group now as well

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

--- Comment #7 from Hanna Czenczek  ---
Thanks a lot!

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #8 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-imago

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #9 from Fedora Update System  ---
FEDORA-2025-a61fc2ecbe (rust-imago-0.1.3-1.fc42) has been submitted as an
update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a61fc2ecbe

[Bug 2338639] Review Request: rust-imago - Virtual machine disk image access library

https://bugzilla.redhat.com/show_bug.cgi?id=2338639

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2025-01-30 17:34:51

--- Comment #10 from Fedora Update System  ---
FEDORA-2025-a61fc2ecbe (rust-imago-0.1.3-1.fc42) has been pushed to the Fedora
42 stable repository.
If problem still persists, please make note of it in this bug report.