[Bug 1785982] New: Review Request: python-qdarkstyle - A dark stylesheet for Python and Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Bug ID: 1785982 Summary: Review Request: python-qdarkstyle - A dark stylesheet for Python and Qt applications Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nonamedotc@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdar... SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdar...
Description: A dark stylesheet for Qt applications (Qt4, Qt5, PySide, PySide2, PyQt4, PyQt5, QtPy, PyQtGraph).
Fedora Account System Username: nonamedotc
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1785977, 1785974 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785974 [Bug 1785974] Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets https://bugzilla.redhat.com/show_bug.cgi?id=1785977 [Bug 1785977] Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
--- Comment #1 from Mukundan Ragavan nonamedotc@gmail.com --- This package is complicated by python-watchdog required pathtools, which has been retired.
Also, python-importlib-metadata is missing in rawhide at the moment.
https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder4_rawhide/build/113...
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1785977 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785977 [Bug 1785977] Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1785977
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785977 [Bug 1785977] Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- I'll review this once the two reviews this depends on move forward.
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 Bug 1785982 depends on bug 1785977, which changed state.
Bug 1785977 Summary: Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily https://bugzilla.redhat.com/show_bug.cgi?id=1785977
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Hmm, builds fails with:
+ /usr/bin/python3 setup.py test running test WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. running egg_info writing QDarkStyle.egg-info/PKG-INFO writing dependency_links to QDarkStyle.egg-info/dependency_links.txt writing entry points to QDarkStyle.egg-info/entry_points.txt writing requirements to QDarkStyle.egg-info/requires.txt writing top-level names to QDarkStyle.egg-info/top_level.txt reading manifest file 'QDarkStyle.egg-info/SOURCES.txt' reading manifest template 'MANIFEST.in' warning: no files found matching 'PRODUCTION.md' writing manifest file 'QDarkStyle.egg-info/SOURCES.txt' running build_ext pyside_style_rc (unittest.loader._FailedTest) ... ERROR
====================================================================== ERROR: pyside_style_rc (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: pyside_style_rc Traceback (most recent call last): File "/usr/lib64/python3.8/unittest/loader.py", line 154, in loadTestsFromName module = __import__(module_name) File "/builddir/build/BUILD/QDarkStyle-2.7/qdarkstyle/pyside_style_rc.py", line 10, in <module> from PySide import QtCore ModuleNotFoundError: No module named 'PySide'
python3-pyside has been retired ;( https://src.fedoraproject.org/rpms/python-pyside/c/73d32307db2c8b1d56c6705f4...
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 Bug 1785982 depends on bug 1785974, which changed state.
Bug 1785974 Summary: Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets https://bugzilla.redhat.com/show_bug.cgi?id=1785974
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
--- Comment #4 from Mukundan Ragavan nonamedotc@gmail.com --- Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdar... SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdar...
- Packaged latest upstream version (v2.8)
It would be best to use tox for testing. But, not sure how to get this to work. Open to suggestions. Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
Ran 0 tests in 0.000s
Yep, current test invocation doesn't seem to work.
I tried running the tests in mock, and I couldn't get it to work either. %tox expands to "... tox --current-env ...", and tox doesn't seem to know this option.
When I remove the option, it can't find virtualenv: + tox -q --recreate -e py38 ... ERROR: No matching distribution found for virtualenv
but the python3-virtualenv is installed.
+ package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly (according to setup.py) + builds and install OK + latest version + R/P/BR look OK
Package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
--- Comment #6 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-qdarkstyle
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-03-19 20:06:17
--- Comment #7 from Mukundan Ragavan nonamedotc@gmail.com --- Thanks for the review. Built on rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Timothy Redaelli tredaelli@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1906117
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1906117 [Bug 1906117] python3-qdarkstyle should not requires stuff only used as build dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1785982
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1666513 CC| |hegjon@gmail.com
--- Comment #8 from Jonny Heggheim hegjon@gmail.com --- *** Bug 1666545 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1666513 [Bug 1666513] nothing provides python3.6dist(qdarkstyle) < 3.0 needed by electrum-3.2.4-1.fc28.noarch
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 Bug 1785982 depends on bug 1906117, which changed state.
Bug 1906117 Summary: python3-qdarkstyle should not requires stuff only used as build dependencies https://bugzilla.redhat.com/show_bug.cgi?id=1906117
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |EOL
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com