[Bug 1288645] New: Review Request: teem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Bug ID: 1288645
           Summary: Review Request: teem
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/teem.git/pla...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...

Description:

Teem is a coordinated group of libraries for representing, processing, and
visualizing scientific raster data. Teem includes command-line tools that
permit the library functions to be quickly applied to files and streams,
without having to write any code. The most important and useful libraries in
Teem are:

- Nrrd (and the unu command-line tool on top of it) supports a range of
operations for transforming N-dimensional raster data (resample, crop, slice,
project, histogram, etc.), as well as the NRRD file format for storing arrays
and their meta-information.
- Gage: fast convolution-based measurements at arbitrary point locations in
volume datasets (scalar, vector, tensor, etc.)
- Mite: a multi-threaded ray-casting volume render with transfer functions
based on any quantity Gage can measure
- Ten: for estimating, processing, and visualizing diffusion tensor fields,
including fiber tractography methods.

This library is required to build 3D-Slicer that I'm going to package.

[Bug 1288645] Review Request: teem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1288645] Review Request: teem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1276941 (fedora-neuro)
              Alias|                            |teem

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Review Request: teem        |Review Request: teem -
                   |                            |Libraries for scientific
                   |                            |raster data processing and
                   |                            |visualizing

--- Comment #1 from Igor Gnatenko  ---
-> Libraries for scientific raster data processing and visualizing
for main package not correlates with %files, you have only tools, not libraries
in main pkg.

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
During build:

1: /builddir/build/BUILD/teem-1.11.0-src/build/bin/nrrdSanity: formats
supported in this build:
1: nrrd: yes
1: pnm: yes
1: png: not available
1: vtk: yes
1: text: yes
1: eps: yes
1: /builddir/build/BUILD/teem-1.11.0-src/build/bin/nrrdSanity: encodings
supported in this build:
1: raw: yes
1: ascii: yes
1: hex: yes
1: gz: not available
1: bz2: not available

It looks like some build dependencies are missing.

Tests fail on x86_64 with:
33: /builddir/build/BUILD/teem-1.11.0-src/build/bin/test_probeSS: trouble
creating volumes:
33: [probeSS] engageGenTensor: trouble loading from new vol tmp-ten.nrrd
...
28/35 Test #33: probeSS_ctmr02 ...................***Failed    0.41 sec
...
35/35 Test #26: kernall ..........................   Passed    7.61 sec
97% tests passed, 1 tests failed out of 35
Total Test time (real) =   8.18 sec
The following tests FAILED:
         33 - probeSS_ctmr02 (Failed)
Errors while running CTest

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Created attachment 1112962
  --> https://bugzilla.redhat.com/attachment.cgi?id=1112962&action=edit
build failure on x86_64

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

--- Comment #4 from Dmitry Mikhirev  ---
The problem was in parallel running of tests. They need to be executed
sequentially.

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/teem.git/pla...

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
What about the first part of comment #2?

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

--- Comment #6 from Dmitry Mikhirev  ---
I'm sorry, you are right. I really missed some optional dependencies that are
visible in test log only. Now I added all of them except levmar because the
code using it is broken and does not compile.

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/teem.git/pla...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
+ latest version
+ package name is OK
+ Summary and %description are OK
+ scriptlets are OK
+ builds and installs OK
+ license is acceptable
+ license file is present, %license is used
+ %check is present
+ requires and provides look fine
+ fedora-review is happy
+ rpmlint finds nothing substantial

teem-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libteem.so.1.11.0
exit@GLIBC_2.2.5
You might want to investigate that.

Package is APPROVED.

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/teem

[Bug 1288645] Review Request: teem - Libraries for scientific raster data processing and visualizing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288645

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2016-02-02 16:10:42