https://bugzilla.redhat.com/show_bug.cgi?id=854386
Bug ID: 854386 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: rubygem-openstack-quantum-client - Ruby openstack quantum Client Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: alejandro.perez.torres@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client.spe... SRPM URL: http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client-0.1... Description: A simple gem to deal with openstack quantum Fedora Account System Username:aeperezt
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #1 from Alejandro_Perez alejandro.perez.torres@gmail.com --- rpmlint output:
rpmlint SPECS/rubygem-openstack-quantum-client.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-openstack-quantum-client-0.1.5-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint RPMS/noarch/rubygem-openstack-quantum-client-0.1.5-1.fc17.noarch.rpm rubygem-openstack-quantum-client.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=854386
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |guillermo.gomez@gmail.com Assignee|nobody@fedoraproject.org |guillermo.gomez@gmail.com Flags| |fedora-review?
--- Comment #2 from Guillermo Gómez guillermo.gomez@gmail.com --- I'll review.
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #3 from Guillermo Gómez guillermo.gomez@gmail.com --- 1) Unneeded macros, those are provided by rubygems-devel, remove please.
%global gem_dir /usr/share/rubygems %global gem_instdir %{gem_dir}/gems/%{gem_name}-%{version} %global gem_docdir %{gem_dir}/doc/%{gem_name}-%{version} %global gem_libdir %{gem_instdir}/lib
also, they point to wrong locations for the files.
2) Source0: https://rubygems.org/downloads/openstack-quantum-client-0.1.5.gem
Please use macros for name and version, sample:
Source0: http://rubygems.org/downloads/%%7Bgem_name%7D-%%7Bversion%7D.gem
3) BuildArch tag repeated in main pkg and doc subpkg. doc subpkg inherits the tag from main declaration. Remove the latest BuildArch tag please.
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #4 from Alejandro_Perez alejandro.perez.torres@gmail.com --- Hum I had take out unneeded macros, vefore you start the review forgot tu update the srpm on the link. Sorry on that.
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #5 from Guillermo Gómez guillermo.gomez@gmail.com --- Do we have new spec and srpm available?
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #6 from Alejandro_Perez alejandro.perez.torres@gmail.com --- Yes here it is
http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client-0.1...
rpmlint SRPMS/rubygem-openstack-quantum-client-0.1.5-2.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #7 from Guillermo Gómez guillermo.gomez@gmail.com --- Ruby: [!]: Specfile should use macros from rubygem-devel package. Note: The specfile doesn't use these macros: %doc %{gem_docdir}
%files doc %doc %{gem_instdir}/README.markdown %doc %{gem_dir}/doc << please use rubygem-devel package macros for this.
[!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff).
Diff spec file in url and in SRPM --------------------------------- --- /home/gomix/Fedpkg/fedora-review/854386-rubygem-openstack-quantum-client/srpm/rubygem-openstack-quantum-client.spec 2012-10-26 06:16:54.135068777 -0430 +++ /home/gomix/Fedpkg/fedora-review/854386-rubygem-openstack-quantum-client/srpm-unpacked/rubygem-openstack-quantum-client.spec 2012-10-26 06:16:56.549061667 -0430 @@ -2,5 +2,5 @@ Name: rubygem-%{gem_name} Version: 0.1.5 -Release: 1%{?dist} +Release: 2%{?dist} Summary: The main objective of this gem is to deal easily with openstack quantum
Heads up, this a false positive BUT, just to make the reviewer life happier, always include both links, srpm and spec (fedora-review has detected the old one in bz).
[?]: Empty changelog entry for version 0.1.5-2 ?
%changelog * Sun Oct 15 2012 Alejandro Pérez aeperezt@fedoraproject.org - 0.1.5-2 * Sun Sep 02 2012 Alejandro Pérez aeperezt@fedoraproject.org - 0.1.5-1 - Initial package
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #8 from Alejandro_Perez alejandro.perez.torres@gmail.com --- Thanks for the notice. it has been done.
http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client.spe...
http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client-0.1...
rpmlint SPECS/rubygem-openstack-quantum-client.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint SRPMS/rubygem-openstack-quantum-client-0.1.5-3.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint RPMS/noarch/rubygem-openstack-quantum-client-0.1.5-3.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=854386
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #9 from Guillermo Gómez guillermo.gomez@gmail.com --- Reviewed, nothing else to comment.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=854386
Alejandro_Perez alejandro.perez.torres@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Alejandro_Perez alejandro.perez.torres@gmail.com --- New Package SCM Request ======================= Package Name: rubygem-openstack-quantum-client Short Description: Ruby Openstack Quantum Interface Owners: aeperezt Branches: f18 f17 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- rubygem-openstack-quantum-client-0.1.5-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-openstack-quantum-client-0.1...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- rubygem-openstack-quantum-client-0.1.5-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-openstack-quantum-client-0.1...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- Package rubygem-openstack-quantum-client-0.1.5-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rubygem-openstack-quantum-client-0.1.5-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-18872/rubygem-openstack-... then log in and leave karma (feedback).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-12-05 02:00:30
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- rubygem-openstack-quantum-client-0.1.5-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854386
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- rubygem-openstack-quantum-client-0.1.5-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org