https://bugzilla.redhat.com/show_bug.cgi?id=996489
Bug ID: 996489 Summary: Review Request: rubygem-tins - Useful tools library in Ruby Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: axilleas@archlinux.gr QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://axilleas.fedorapeople.org/pkgs/rubygem-tins/rubygem-tins.spec SRPM URL: http://axilleas.fedorapeople.org/pkgs/rubygem-tins/rubygem-tins-0.8.3-1.fc19...
Description: All the stuff that isn't good/big enough for a real library.
Fedora Account System Username: axilleas
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Axilleas Pipinellis axilleas@archlinux.gr changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |972544, 993365, 996139
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jstribny@redhat.com Assignee|nobody@fedoraproject.org |jstribny@redhat.com Flags| |fedora-review?
--- Comment #1 from Josef Stribny jstribny@redhat.com --- I will take it for a review.
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Josef Stribny jstribny@redhat.com --- 1, Please remove the trailing white space: * after BuildRequires: rubygems-devel * after BuildRequires: rubygem(test-unit)
2, Please put the dot at the end of -doc subpackage description
3, Should the license be "X11 or MIT" (taken from the README)? Since only MIT is included as a standalone file and in the .gemspec, it's probably better to list only MIT. Maybe you can ask upstream for clarification?
Otherwise the spec is alright, it builds, installs and runs, rpmlint doesn't complaint and the issues mentioned above are minor so I am APPROVING the package. Please resolve the issues above before pushing.
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #3 from Axilleas Pipinellis axilleas@archlinux.gr --- (In reply to Josef Stribny from comment #2)
1, Please remove the trailing white space:
- after BuildRequires: rubygems-devel
- after BuildRequires: rubygem(test-unit)
Hmm, for some reason these are from gem2rpm, fixed.
2, Please put the dot at the end of -doc subpackage description
Fixed.
3, Should the license be "X11 or MIT" (taken from the README)? Since only MIT is included as a standalone file and in the .gemspec, it's probably better to list only MIT. Maybe you can ask upstream for clarification?
I filled an issue: https://github.com/flori/tins/issues/5
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Axilleas Pipinellis axilleas@archlinux.gr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Axilleas Pipinellis axilleas@archlinux.gr --- New Package SCM Request ======================= Package Name: rubygem-tins Short Description: Useful tools library in Ruby Owners: axilleas Branches: f19 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #6 from Vít Ondruch vondruch@redhat.com --- (In reply to Axilleas Pipinellis from comment #3)
(In reply to Josef Stribny from comment #2)
1, Please remove the trailing white space:
- after BuildRequires: rubygems-devel
- after BuildRequires: rubygem(test-unit)
Hmm, for some reason these are from gem2rpm, fixed.
Yes, that is gem2rpm thing. There might be appended version, in that case there would be space between the BR and version, since there is no version, just the space remains. Fix polishing this behavior is appreciated, but I have not come up yet with any solution I would like mysel
3, Should the license be "X11 or MIT" (taken from the README)? Since only MIT is included as a standalone file and in the .gemspec, it's probably better to list only MIT. Maybe you can ask upstream for clarification?
I filled an issue: https://github.com/flori/tins/issues/5
They are the same license, MIT for is the right one for Fedora.
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #7 from Axilleas Pipinellis axilleas@archlinux.gr --- A(In reply to Vít Ondruch from comment #6)
3, Should the license be "X11 or MIT" (taken from the README)? Since only MIT is included as a standalone file and in the .gemspec, it's probably better to list only MIT. Maybe you can ask upstream for clarification?
I filled an issue: https://github.com/flori/tins/issues/5
They are the same license, MIT for is the right one for Fedora.
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List
Anyhow, the author was kind enough to release a 0.8.4 version, which clarifies the license :)
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #8 from Mamoru TASAKA mtasaka@fedoraproject.org --- At least please fix changelog.
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #9 from Axilleas Pipinellis axilleas@archlinux.gr --- Crap, I forgot it.
How should I fix it now? I should do a version bump for it to rebuild and get the change to the repos, right?
Should I add two more changelogs, one about the version update (0.8.4-1) and another one (0.8.4-2) about the previous forgotten changelog?
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #10 from Mamoru TASAKA mtasaka@fedoraproject.org --- As this package has not pushed into F-19 stable yet, it is much better to bumping release, fixing changelog than to leave inconsistent changelog. Leaving this unfixed makes it harder to fix this later.
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #11 from Vít Ondruch vondruch@redhat.com --- Axilleas, you can now push the build into the stable and close this bug. BTW, since you pushed the update into stable Fedora via Bodhi, it is good to reverence this ticket there. Bodhi would take care about this BZ and closed it for you.
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Axilleas Pipinellis axilleas@archlinux.gr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-08-23 11:05:56
--- Comment #12 from Axilleas Pipinellis axilleas@archlinux.gr --- Hmm, I thought I did in the package update submission but seems I missed it... I pushed it to stable, thanks for reminding.
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Jan Klepek jan.klepek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | CC| |jan.klepek@gmail.com Flags|fedora-cvs+ |fedora-cvs?
--- Comment #13 from Jan Klepek jan.klepek@gmail.com --- Package SCM Request ======================= Package Name: rubygem-tins Short Description: Useful tools library in Ruby Owners: hpejakle Branches: el6 el5 InitialCC: axilleas
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #14 from Jan Klepek jan.klepek@gmail.com --- Package Change Request ====================== Package Name: rubygem-tins Short Description: Useful tools library in Ruby Owners: hpejakle Branches: el6 el5 InitialCC: axilleas
https://bugzilla.redhat.com/show_bug.cgi?id=996489
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=996489
--- Comment #15 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Corrected branch formatting.
package-review@lists.fedoraproject.org