[Bug 2258519] New: Review Request: frugally-deep - Header-only library for using Keras (TensorFlow) models in C++
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
Bug ID: 2258519 Summary: Review Request: frugally-deep - Header-only library for using Keras (TensorFlow) models in C++ Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: trix@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://trix.fedorapeople.org/frugally-deep.spec SRPM URL: https://trix.fedorapeople.org/frugally-deep-0.15.30-1.fc40.src.rpm
Would you like to build/train a model using Keras/Python? And would you like to run the prediction (forward pass) on your model in C++ without linking your application against TensorFlow? Then frugally-deep is exactly for you.
frugally-deep
* is a small header-only library written in modern and pure C++. * is very easy to integrate and use. * depends only on FunctionalPlus, Eigen and json - also header-only libraries. * supports inference (model.predict) not only for sequential models but also for computational graphs with a more complex topology, created with the functional API. * re-implements a (small) subset of TensorFlow, i.e., the operations needed to support prediction. * results in a much smaller binary size than linking against TensorFlow. * works out-of-the-box also when compiled into a 32-bit executable. (Of course, 64 bit is fine too.) * avoids temporarily allocating (potentially large chunks of) additional RAM during convolutions (by not materializing the im2col input matrix). * utterly ignores even the most powerful GPU in your system and uses only one CPU core per prediction. ;-) * but is quite fast on one CPU core, and you can run multiple predictions in parallel, thus utilizing as many CPUs as you like to improve the overall prediction throughput of your application/pipeline.
frugally-deep is a buildrequires for MIOpen, a ROCm AI/ML library needed for PyTorch
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
Tom Rix trix@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1011110 (ML-SIG) CC| |rocm-packagers-sig@lists.fe | |doraproject.org Flags| |fedora-review?
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1011110 [Bug 1011110] Machine Learning SIG - review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/Dobiasd/ | |frugally-deep Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6905815 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
Felix Wang topazus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |topazus@outlook.com Assignee|nobody@fedoraproject.org |topazus@outlook.com Flags|fedora-review? | Status|NEW |ASSIGNED
--- Comment #2 from Felix Wang topazus@outlook.com --- Taking this.
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
--- Comment #3 from Felix Wang topazus@outlook.com --- The package is header-only which should be simple to review.
License: MIT AND BSD-2-Clause # Main license is MIT # BSD-2-Clause is only for cmake/HunterGate.cmake
In my view, the cmake file do not need to be included in License field.
quoted from https://docs.fedoraproject.org/en-US/legal/license-field/
Licenses that cover files in the source code that are not copied into the binary RPM should be excluded from the License: tag.
%cmake -DCMAKE_INSTALL_DATADIR=%{_libdir}
Why does `-DCMAKE_INSTALL_DATADIR=%{_libdir}` needed here?
frugally-deep-devel.x86_64: W: only-non-binary-in-usr-lib
I do not know about this, but I think it is a minor issue.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs.
Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /var/lib/copr- rpmbuild/results/frugally-deep/upstream-unpacked/Source0/frugally- deep-0.15.30/include [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 15002 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: frugally-deep-devel-0.15.30-1.fc40.x86_64.rpm frugally-deep-0.15.30-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbtdsl4gq')] checks: 31, packages: 2
frugally-deep-devel.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "frugally-deep-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Source checksums ---------------- https://github.com/Dobiasd/frugally-deep/archive/refs/tags/v0.15.30.tar.gz#/... : CHECKSUM(SHA256) this package : 8932f7b42612598402269a54f957af09084dc2cb812d32887d991d6e45b280fb CHECKSUM(SHA256) upstream package : 8932f7b42612598402269a54f957af09084dc2cb812d32887d991d6e45b280fb
Requires -------- frugally-deep-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64)
Provides -------- frugally-deep-devel: cmake(frugally-deep) frugally-deep-devel frugally-deep-devel(x86-64) frugally-deep-static
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name frugally-deep --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, PHP, Haskell, Java, Perl, fonts, SugarActivity, R, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
--- Comment #4 from Tom Rix trix@redhat.com --- Spec URL: https://trix.fedorapeople.org/frugally-deep.spec SRPM URL: https://trix.fedorapeople.org/frugally-deep-0.15.30-2.fc40.src.rpm
Reduces the license to MIT Removes the unneeded cmake arg
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2008854 --> https://bugzilla.redhat.com/attachment.cgi?id=2008854&action=edit The .spec file difference from Copr build 6905815 to 6908640
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6908640 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
Felix Wang topazus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #7 from Felix Wang topazus@outlook.com --- LGTM. Approved. May I ask you to review one package review of mine if you are available? https://bugzilla.redhat.com/show_bug.cgi?id=2255947
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/frugally-deep
https://bugzilla.redhat.com/show_bug.cgi?id=2258519
Tom Rix trix@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2024-01-19 12:59:50
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com