https://bugzilla.redhat.com/show_bug.cgi?id=2258882
Bug ID: 2258882 Summary: Review Request: rust-totp-lite - Simple, correct TOTP library Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/rust-totp-lite.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-totp-lite-2.0.1-1.fc38.src.rpm
Description: A simple, correct TOTP library.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2258882
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/to | |tp-lite
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6913632 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2258882
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Would it be possible to port this from koibumi-base32 to a different crate? The base32 or data-encoding crates come to mind as possible alternatives.
koibumi-base32 is GPL licensed which is quite unusual for a Rust project. According to the README it also has a bit unusual behaviour (all lowercase, no padding support) when compared to "standard" base64 which might be unexpected.
https://bugzilla.redhat.com/show_bug.cgi?id=2258882
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Last Closed| |2024-07-04 22:22:58
--- Comment #3 from Michel Lind michel@michel-slm.name --- Turns out this is not actually needed as the package was not retired for long enough -- I filed for unretirement the same day I filed this... not sure exactly which one is first, and forgot to close this one. I suspect I did all the builds for missing packages locally, filed review requests for them, and then noticed it was actually recently retired.
Sorry for the noise! This should be a good todo - get upstream to switch to base32 (which rbw which uses totp-lite actually needs anyway). It's only a test dependency so should be easy to switch without affecting anything else.
https://bugzilla.redhat.com/show_bug.cgi?id=2258882
--- Comment #4 from Michel Lind michel@michel-slm.name --- For completeness - https://pagure.io/releng/issue/11893
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com