[Bug 474356] New: Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Summary: Review Request: trilead-ssh2 - SSH-2 protocol
                    implementation in pure Java
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ss...
SRPM URL:
http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ss...
Description: Trilead SSH-2 for Java is a library which implements the SSH-2
protocol in pure
Java (tested on J2SE 1.4.2 and 5.0). It allows one to connect to SSH servers
from within Java programs. It supports SSH sessions (remote command execution
and shell access), local and remote port forwarding, local stream forwarding,
X11 forwarding and SCP. There are no dependencies on any JCE provider, as all
crypto functionality is included.

This package is the newest version of ganymed-ssh2 that is not maintained
anymore and is required for newer versions of eclipse-subclipse that I am
updating. There is no direct source download link, the page
http://www.trilead.com/Download/Trilead_SSH_for_Java/ requires to check to
options

Is this kind of requests legal for Fedora "By downloading a Trilead software
product you are certifying that you are not a national of Iraq; Liberia;
Myanmar (Burma); Sierra Leone; Côte d'Ivoire; Sudan; Democratic Republic of the
Congo; Usbekistan; Belarus; Lebanon or any country (or an explicit mentioned
individual or group) to which the SECO (State Secretariat for Economic Affairs,
http://www.seco.admin.ch) has decided to impose sanctions against.
Please confirm by checking the above checkbox."

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235

--- Comment #1 from Jason Tibbitts   2008-12-03 12:58:48 EDT ---
You ask a legal question, so blocking FE-Legal.  It would be very much
preferable to be able to download a tarball directly.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Alexander Kurtakov   2008-12-19 08:12:25 EDT ---
How is the legal question going?
I would like to review this but I have no idea what to do with this FE-legal
thing.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #3 from Tom "spot" Callaway   2009-01-12 17:28:11 EDT ---
Well, we're still thinking about this one. Please be patient with us.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Tom "spot" Callaway   2009-01-12 18:18:58 EDT ---
After consulting with RH Legal, we've decided that the requirement for Fedora
to accept that restriction on behalf of our users in order to simply download
the source code is unacceptable.

Your only remaining recourse would be to ask upstream if they would lift that
restriction. Its a rather odd restriction, seeingly tied to Swiss Economic
Sanctions (not crypto related)?

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #5 from Robert Marcano   2009-01-13 07:54:03 EDT ---
First email sent, Hopefully they can do something to help

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #6 from Robert Marcano   2009-01-20 16:45:19 EDT ---
Second email sent, the first one has not been replied. Starting to reevaluate
http://www.eclipse.org/subversive/

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #7 from Robert Marcano   2009-01-22 07:54:05 EDT ---
Good news, response received:

"To make things short: we removed the export restriction clause
and the checkbox from the download page, downloaders also need
not to accecpt the BSD license anymore. There is now a direct
download link"

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #8 from Alexander Kurtakov   2009-01-22 07:58:51 EDT ---
Great news.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|182235                      |

--- Comment #9 from Tom "spot" Callaway   2009-01-22 10:06:50 EDT ---
Lifting FE-Legal, as there is no longer any problem with the restrictions
removed. Thanks for following up on this with upstream.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #10 from Alexander Kurtakov   2009-01-22 15:58:30 EDT ---
Rpmlint warnings for fix before going to formal review

* W: file-not-utf8 /usr/share/doc/trilead-ssh2-213/HISTORY.txt - Easily fixable
* W: obsolete-not-provided ganymed-ssh2 - eclipse-slide is requiring
ganymed-ssh2 so i guess we would be on the safe side to provide it
* W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 18)
* W: non-standard-group Development/Documentation

There is one more rpmlint warning but it is clearly a bug in rpmlint
W: libdir-macro-in-noarch-package %{_libdir}/gcj/%{name}

Also please fix Source0 to point to the download url.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #11 from Robert Marcano   2009-01-22 17:02:03 EDT ---
(In reply to comment #10)
> W: obsolete-not-provided ganymed-ssh2 - eclipse-slide is requiring
>
> ganymed-ssh2 so i guess we would be on the safe side to provide it

I missed this one, trilead-ssh2 is not binary/nor 100% source compatible (but
only a few package renames are needed), so both packages are needed until
eclipse-slide is updated (ganymed-ssh2 project is dead). I will ask the
developer about that

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #12 from Robert Marcano   2009-01-26 14:10:55 EDT ---
Updated:

http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ss...
http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ss...

Updated GCJ AOT to the latest guidelines (I still provides it even when people
is starting to not generate it, OpenJDK still is not fully ported outside
i386/x86_64

The only rpmlint warnings remaining are:

file-not-utf8 /usr/share/doc/trilead-ssh2-213/HISTORY.txt

I think this is a rpmlint bug, the only char I see on that document outside the
ASCII range is used for the name "Michaël" and I see it without errors on UTF-8

non-standard-group Development Documentation

This is as the Java packaging guidelines specfile template

libdir-macro-in-noarch-package %attr(-,root,root) %{_libdir}/gcj/%{name}

The same, GCJ AOT packaging guidelines

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #13 from Robert Marcano   2009-01-26 14:12:01 EDT ---
oops forgot, removed Obsoletes until eclipse-slide is updated

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #14 from Alexander Kurtakov   2009-02-04 04:32:51 EDT ---
I'll review this.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #15 from Alexander Kurtakov   2009-02-04 05:01:51 EDT ---
OK package named correctly
OK spec file named correctly
OK meets the Packaging Guidelines (except for above)
OK license is correct, approved and in %doc
OK license field in the package spec file matches the actual license
OK package MUST successfully compile and build into binary rpms on at least
one primary architecture (compiles on x86 cleanly)
OK owns all directories
OK doesn't contain any duplicate files
OK permissions are correctly set
OK clean section present
OK uses macros consistently
OK package contains code
OK no large documentation files 
OK if a package includes something as %doc, it must not affect the runtime of
the application. 
OK packages must not own files or directories already owned by other packages.
OK %install MUST run rm -rf %{buildroot}
OK all filenames must be valid UTF-8

The only remaining issue is 
file-not-utf8 /usr/share/doc/trilead-ssh2-213/HISTORY.txt
"Michaël" is not actually UTF-8 in this file.

Just put the next line in the %prep and we are good to go.
iconv -f ISO-8859-1 -t UTF-8 -o HISTORY.txt HISTORY.txt

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #16 from Alexander Kurtakov   2009-02-12 13:24:02 EDT ---
Robert,
I hope you have some time for this soon so I can go on with subclipse.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

--- Comment #17 from Robert Marcano   2009-02-16 07:24:31 EDT ---
done

http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ss...
http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ss...

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #18 from Alexander Kurtakov   2009-02-16 09:32:59 EDT ---
OK, There is nothing else holding this review.

This package is APPROVED.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Robert Marcano  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #19 from Robert Marcano   2009-02-16 10:15:35 EDT ---
New Package CVS Request
=======================
Package Name: trilead-ssh2
Short Description: Trilead SSH-2 for Java is a library which implements the
SSH-2 protocol in pure
Owners: robmv
Branches: F-10
InitialCC: robmv

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #20 from Kevin Fenzi   2009-02-16 16:08:07 EDT ---
cvs done.

Alexander: Please remember to assign reviews to yourself as reviewer.

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474356

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #21 from Alexander Kurtakov   2009-04-03 05:21:11 EDT ---
Package is in repos now.