Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Bug ID: 894570 Summary: Review Request: php-horde-Horde-Editor - Horde Editor API Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: fedora@famillecollet.com
Spec URL: https://raw.github.com/remicollet/remirepo/bc4bc2649ebe72a42b01fed7e5df16fad... SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Editor-2.0.1-1.remi.src.... Description: The Horde_Editor package provides an API to generate the code necessary for embedding javascript RTE editors in a web page.
Fedora Account System Username: remi
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nb@fedoraproject.org Depends On| |785476 (horde-serialize) Alias| |Horde_Editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #1 from Remi Collet fedora@famillecollet.com --- New version Spec: https://raw.github.com/remicollet/remirepo/3a8226fa9198aa2b54d16236c08f59959... Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Editor-2.0.2-1.remi.src....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|785476 (horde-serialize) |785436 (horde-exception), | |785449 (horde-browser), | |873408 Assignee|nobody@fedoraproject.org |shawn.iwinski@gmail.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 692994 --> https://bugzilla.redhat.com/attachment.cgi?id=692994&action=edit php-horde-Horde-Editor-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 894570 --mock-config fedora-rawhide-x86_64
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #3 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 692995 --> https://bugzilla.redhat.com/attachment.cgi?id=692995&action=edit phpci.log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(fedora@famillecol | |let.com)
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- One question before approval: How does the library itself (or the library user) know about the un-bundled library?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fedora@famillecol | |let.com) |
--- Comment #5 from Remi Collet fedora@famillecollet.com --- The user of this library will have to define a web alias.
AS the alias order is really important, all the needed alias will be defined in the main horde httpd configuration file (php-horde-horde is the main "framework" package for all the horde applications)
# Link to system Javascript Libraries Alias /horde/js/scriptaculous /usr/share/scriptaculous Alias /horde/js/prototype.js /usr/share/prototype/prototype.js Alias /horde/js/ckeditor /usr/share/ckeditor Alias /horde/js/syntaxhighlighter /usr/share/syntaxhighlighter
# Link to horde Alias /horde /usr/share/horde
I agree, this is a bit ugly, but I really want to avoid "symlinks" solution which is even more ugly (and raise lot of update issue)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Shawn Iwinski shawn.iwinski@gmail.com --- Thanks for the explanation Remi.
No blockers.
===== APPROVED =====
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Remi Collet fedora@famillecollet.com --- Thanks for the review
New Package SCM Request ======================= Package Name: php-horde-Horde-Editor Short Description: Horde Editor API Owners: remi nb Branches: f18 el8 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Corrected branch el8 to el6.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |785476 (horde-serialize)
--- Comment #9 from Remi Collet fedora@famillecollet.com --- I will differ the import, as Horde_Serialize not yet approved
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |908329 (Horde_Core)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-horde-Horde-Editor-2.0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Editor-2.0.3-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-horde-Horde-Editor-2.0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Editor-2.0.3-2.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-horde-Horde-Editor-2.0.3-2.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Bug 894570 depends on bug 785476, which changed state.
Bug 785476 Summary: Review Request: php-horde-Horde-Serialize - Data Encapulation API https://bugzilla.redhat.com/show_bug.cgi?id=785476
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-02-28 02:06:14
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-horde-Horde-Editor-2.0.3-2.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894570
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-horde-Horde-Editor-2.0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org