[Bug 529517] New: Review Request: kcm_touchpad - <short summary here>

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: kcm_touchpad - <short summary here>

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Summary: Review Request: kcm_touchpad - <short summary here>
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://rrix.fedorapeople.org/kcm_touchpad/kcm_touchpad.spec
SRPM URL:
http://rrix.fedorapeople.org/kcm_touchpad/kcm_touchpad-0.2.1-1.fc11.src.rpm
Description: 
A KDE System Settings module to to configure synaptics based touchpads.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1752332

[rrix@TheSwan rpmbuild]$ rpmlint RPMS/i586/kcm_touchpad-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Kevin Kofler will need to sponsor me on kmagnet (BUG:528096) before I can get a
CVS request on this package.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Ryan Rix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |kcm_touchpad - <short       |kcm_touchpad - Synaptics
                   |summary here>               |driver based touchpads
                   |                            |kcontrol module

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Ryan Rix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ryan Rix   2009-10-17 21:15:08 EDT ---
*** Bug 527860 has been marked as a duplicate of this bug. ***

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Kevin Kofler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Kevin Kofler   2009-10-26 13:58:11 EDT ---
FYI, Ryan is sponsored now, so any sponsored contributor can review and approve
this package.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #3 from Kevin Kofler   2009-10-26 14:00:07 EDT ---
In any case, the firs thing I notice is that this has redundant "Requires:
kdelibs4 >= 4.1 qt4 >= 4.4.0", please remove those. (Those versions have been
current since "forever", so the automatic soname deps should be sufficient.)

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Jaroslav Reznik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #4 from Jaroslav Reznik   2009-11-02 04:07:35 EDT ---
(In reply to comment #2)
> FYI, Ryan is sponsored now, so any sponsored contributor can review and approve
> this package.

Kevin,
I'll take it as I'm now helping some guy on local Linux forum to set up
synaptic. I've already asked him not to report bugs/feature requests to forum
but to bugzilla or IRC ;-)

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #5 from Jaroslav Reznik   2009-11-02 09:26:41 EDT ---
Package name OK
Summary OK
License OK
URL & Sources FIXME
Sources MD5 FIXME (new version, sources URL, see comment)
Buildroot OK
Requires - do not require kdelibs4 >= 4.1 qt4 >= 4.4.0
Description OK
File attributes OK
Documentation installed OK
Desktop file OK (KDE service desktop file, no need for validation)
Changelog OK

Rpmlint
SPEC & SRPM OK
RPMS OK

Builds 
Scratch OK
Local OK

Fixme:
Group should be User Interfaces/Desktops to match other KControl module
packages.
New version available - 0.3.0.
Sources URL - http://github.com/mishaaq/kcm_touchpad/tarball/kcm_touchpad-0.3.0
or 
  http://download.github.com/mishaaq-kcm_touchpad-000be4c.tar.gz.
Could you please update package, so I can check missing checks, thanks.
Do not use Requires.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #6 from Ryan Rix   2009-11-02 14:36:41 EDT ---
I will update tonight and post latest SRPM etc.

Thanks Jaroslav :)

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #7 from Ryan Rix   2009-11-03 16:55:18 EDT ---
Updated.
http://rrix.fedorapeople.org/kcm_touchpad/kcm_touchpad-0.3.0-1.fc12.src.rpm
http://rrix.fedorapeople.org/kcm_touchpad/kcm_touchpad.spec

http://koji.fedoraproject.org/koji/taskinfo?taskID=1786723

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #8 from Jaroslav Reznik   2009-11-04 03:24:52 EDT ---
Ryan,
please fix remaining issues - group and source url.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #9 from Ryan Rix   2009-11-04 21:58:49 EDT ---
http://rrix.fedorapeople.org/kcm_touchpad/kcm_touchpad-0.3.0-2.fc12.src.rpm
http://rrix.fedorapeople.org/kcm_touchpad/kcm_touchpad.spec

Source checksum unchanged, no koji scratch build submitted.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #10 from Jaroslav Reznik   2009-11-05 04:11:01 EDT ---
Hmm, looks like
http://github.com/mishaaq/kcm_touchpad/tarball/kcm_touchpad-0.3.0 is better
Source URL as they do some magic with waitdownload, download URLs... So the
question is how to handle correctly GitHub downloads? Could you update it?
Sorry, I thought it would work :(

Checksum is OK, once you change Source URL again, I'll approve it. Thanks.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #11 from Kevin Kofler   2009-11-05 05:27:13 EDT ---
That's not a good source URL, as it doesn't have the .tar.bz2. Another issue is
that these tarballs are generated on demand and thus don't have reproducible
checksums.

I think in this case it's safer to just leave the URL as a comment and add only
a specific downloaded tarball as Source0.

We also need to complain to upstream about this, those "autogenerate tarball"
features in repository browsers are not intended to serve as a substitute for
actual releases!

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #12 from Kevin Kofler   2009-11-05 05:30:07 EDT ---
To be more precise, that URL is a redirect, so it can't be used as a Source URL
at all. The last component of the Source URL MUST match the file name on disk.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #13 from Jaroslav Reznik   2009-11-05 06:10:09 EDT ---
Checksums are same - these released files are not regenerated, only redirected.
That's why asked my question. Maybe bringing it to fedora-devel is now the best
we can do regarding this issue. So thanks Kevin, I think your proposed solution
with comment is really best right now, but it's not solution as Source URLs are
checked occasionaly.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #14 from Kevin Kofler   2009-11-05 06:14:06 EDT ---
Unfortunately, there are several upstream servers where the download URLs are
unusable due to weird redirects like that. Our guidelines for source URLs
suggest using a comment for the real URL in such cases. Of course this means
they can't be automatically checked, but that's just life.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #15 from Ryan Rix   2009-11-09 19:16:15 EDT ---
Apologies, the bugzilla mail fell into my oblivion of an inbox. I am confused
in regards to what exactly I should be putting for Source0?

I currently have:
Source0:        http://download.github.com/mishaaq-kcm_touchpad-000be4c.tar.gz

As far as I can tell, this is a direct download (There is not a 301 or anything
reported in wget)

Jreznik suggested
http://github.com/mishaaq/kcm_touchpad/tarball/kcm_touchpad-0.3.0 which is a
302 to the above Source0

Which should I use to keep this review moving? The folder both of these tar.gz
extract to is mishaaq-kcm_touchpad-000be4c leading to ridiculous %setup -q -n
mishaaq-kcm_touchpad-000be4c in either case.

This situation in general sucks, and I'll ask upstream to clarify this in the
future.

Again, sorry for the delay

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #16 from Jaroslav Reznik   2009-11-10 03:18:50 EDT ---
If the first one is a direct download, then I think it's OK to let it there.
The second one is better from name point of view - it's in %{name}-%{version}
scheme. But it's redirect :( And it extracts to that not very nice directory...
It would be nice to ask upstream for real and proper release going with usual
release standards.

Other issues are solved, I think I can approve it. Kevin what do you think
about letting current sources URL?

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #17 from Kevin Kofler   2009-11-10 04:50:43 EDT ---
http://download.github.com/mishaaq-kcm_touchpad-000be4c.tar.gz is the correct
Source URL to use.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Jaroslav Reznik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #18 from Jaroslav Reznik   2009-11-10 06:03:16 EDT ---
Ok, thanks!

APPROVED

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #19 from Ryan Rix   2009-11-10 08:58:12 EDT ---
New Package CVS Request
=======================
Package Name: kcm_touchpad
Short Description: Synaptics driver based touchpads kcontrol module
Owners: rrix
Branches: F-10 F-11 F-12
InitialCC:

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Ryan Rix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #20 from Kevin Fenzi   2009-11-10 22:41:50 EDT ---
cvs done.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #21 from Fedora Update System   2009-11-12 18:43:14 EDT ---
kcm_touchpad-0.3.0-5.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/kcm_touchpad-0.3.0-5.fc12

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #22 from Fedora Update System   2009-11-12 18:43:20 EDT ---
kcm_touchpad-0.3.0-5.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/kcm_touchpad-0.3.0-5.fc11

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #23 from Fedora Update System   2009-11-16 02:35:42 EDT ---
kcm_touchpad-0.3.0-5.fc12 has been pushed to the Fedora 12 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kcm_touchpad'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11601

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #24 from Fedora Update System   2009-11-16 02:35:52 EDT ---
kcm_touchpad-0.3.0-5.fc11 has been pushed to the Fedora 11 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kcm_touchpad'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11605

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #25 from Fedora Update System   2009-12-03 00:04:32 EDT ---
kcm_touchpad-0.3.0-5.fc11 has been pushed to the Fedora 11 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |0.3.0-5.fc11
         Resolution|                            |ERRATA

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

--- Comment #26 from Fedora Update System   2009-12-03 00:12:30 EDT ---
kcm_touchpad-0.3.0-5.fc12 has been pushed to the Fedora 12 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 529517] Review Request: kcm_touchpad - Synaptics driver based touchpads kcontrol module

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529517

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|0.3.0-5.fc11                |0.3.0-5.fc12