[Bug 2163486] New: Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

Bug ID: 2163486
           Summary: Review Request: qt6-qtwebengine - QtWebEngine
                    components
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine.spec
SRPM URL:
https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine-6.4.2-1.fc...
Description: QtWebEngine components
Fedora Account System Username: jgrulich

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5285415
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

Jan Grulich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |qt6-qtwebengine
             Blocks|                            |1917559 (qt6-reviews)
                 CC|                            |[e-mail]

--- Comment #2 from Jan Grulich  ---
The failure in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2163486#c1
can be ignored. I just opened the review while the SRPM was being uploaded
(it's chromium, takes a while).

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1917559
[Bug 1917559] Qt6-related package review tracker

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]

--- Comment #3 from Neal Gompa  ---
Taking this review.

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #4 from Neal Gompa  ---
Spec review:
> %global rpm_macros_dir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d)

Drop this to just use "%{_rpmmacrodir}", since it's supported on all Fedora and
EPEL branches.
> %if 0%{?rhel} == 7
> BuildRequires: devtoolset-7-toolchain
> %endif

We're not supporting Qt6 on anything lower than EPEL 9, so we should be able to
drop any logic for RHEL < 9.
> %if 0%{?fedora} > 35 || 0%{?epel} > 9
> %filetriggerin -- %{_datadir}/hunspell
> %else
> %filetriggerin -- %{_datadir}/myspell
> %endif

This should be flipped:

%if 0%{?rhel} && 0%{?rhel} < 10
%filetriggerin -- %{_datadir}/myspell
%else
%filetriggerin -- %{_datadir}/hunspell
%endif

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #5 from Jan Grulich  ---
Fixed issues mentioned above.

Spec URL:
https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine.spec
SRPM URL:
https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine-6.4.2-1.fc...

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #6 from Neal Gompa  ---
> %if 0%{?fedora} || 0%{?epel} > 8
> # need libicu >= 65, only currently available on Fedora and EPEL 9
> %global use_system_libicu 1
> %endif

This is always going to happen, since we're only shipping on Fedora + RHEL 9.
Drop the unneeded conditionals.
> %if 0%{?fedora} || 0%{?epel} > 7
> # handled by qt6-srpm-macros, which defines %%qt6_qtwebengine_arches
> # FIXME use/update qt6_qtwebengine_arches
> # 32-bit arches not supported (https://bugreports.qt.io/browse/QTBUG-102143)
> ExclusiveArch: aarch64 x86_64
> %endif

Same here.
> %if 0%{?rhel} == 7
> . /opt/rh/devtoolset-7/enable
> %endif

Kill this entirely.
> %ldconfig_scriptlets

Kill this entirely.

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #7 from Jan Grulich  ---
Fixed issues mentioned above.

Spec URL:
https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine.spec
SRPM URL:
https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine-6.4.2-1.fc...

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Neal Gompa  ---
Review notes:

* Package is named appropriately
* Package builds and installs
* Package licensing is correct
* No serious issues from rpmlint

PACKAGE APPROVED.

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #9 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/qt6-qtwebengine

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #10 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5287101
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

--- Comment #11 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5287451
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2163486] Review Request: qt6-qtwebengine - QtWebEngine components

https://bugzilla.redhat.com/show_bug.cgi?id=2163486

Jan Grulich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2023-04-17 05:51:19