Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: kactivities - API for using and interacting with Activities
https://bugzilla.redhat.com/show_bug.cgi?id=757239
Summary: Review Request: kactivities - API for using and interacting with Activities Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://rdieter.fedorapeople.org/rpms/kactivities/kactivities.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kactivities/kactivities-4.7.80-1.fc16.s... Description: API for using and interacting with Activities
Package rename libkactivities -> kactivities mostly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757239
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews) Alias| |kactivities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757239
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tigcc.ticalc.org Flag| |fedora-review?
--- Comment #1 from Kevin Kofler kevin@tigcc.ticalc.org 2011-11-25 18:23:22 EST --- I'm taking this review.
This has been reviewed and approved very recently in bug #749055, the only thing which has changed is the name (due to upstream).
The Obsoletes look correct, but shouldn't we add matching Provides? (rpmlint will complain otherwise, and I think it can't hurt.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757239
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |kevin@tigcc.ticalc.org Flag|fedora-review? |fedora-review+
--- Comment #2 from Kevin Kofler kevin@tigcc.ticalc.org 2011-11-25 18:28:10 EST --- Obsoletes: libkactivities < 6.1-100 Provides: libkactivities = 6.1-100
[snip]
%package devel Summary: Developer files for %{name} Obsoletes: libkactivities-devel < 6.1-100 Provides: libkactivities-devel = 6.1-100
This is correct, the last libkactivities package was 6.1-2%{?dist} and had no Epoch, going to 100 allows for bugfix builds if needed.
Otherwise, the package hasn't changed since it got approved and I can't see anything wrong with it.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757239
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-cvs?
--- Comment #3 from Rex Dieter rdieter@math.unl.edu 2011-11-25 18:36:59 EST --- New Package SCM Request ======================= Package Name: kactivities Short Description: API for using and interacting with Activities Owners: than jreznik kkolfer ltinkl rdieter rnovacek Branches: f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757239
--- Comment #4 from Kevin Kofler kevin@tigcc.ticalc.org 2011-11-25 18:41:28 EST --- New Package SCM Request ======================= Package Name: kactivities Short Description: API for using and interacting with Activities Owners: than jreznik kkofler ltinkl rdieter rnovacek Branches: f16 InitialCC:
It helps if my name is spelled correctly. ;-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757239
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2011-11-27 17:08:28 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757239
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-11-29 09:47:31
--- Comment #6 from Rex Dieter rdieter@math.unl.edu 2011-11-29 09:47:31 EST --- imported, built. thanks!
package-review@lists.fedoraproject.org