https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Bug ID: 1363763 Summary: Review Request: nodejs-js-beautify - A jsbeautifier.org for node Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-beautify/nodejs-js-beaut... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-beautify/nodejs-js-beaut... Description: A jsbeautifier.org for node Fedora Account System Username: jsmith
Requesting a re-review, as this package was orphaned.
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1310124, 956806 | |(nodejs-reviews), 1269538 | |(IoT)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1310124 [Bug 1310124] Review Request: nodejs-chalk0 - Terminal string styling done right
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1310124 |1305718
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1305718 [Bug 1305718] Review Request: nodejs-preserve - Substitute tokens in the given `string` , then put them back https://bugzilla.redhat.com/show_bug.cgi?id=1310124 [Bug 1310124] Review Request: nodejs-chalk0 - Terminal string styling done right
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vanmeeuwen+fedora@kolabsys. | |com Assignee|nobody@fedoraproject.org |vanmeeuwen+fedora@kolabsys. | |com
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
--- Comment #1 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- No matching package to install: 'npm(benchmark)' No matching package to install: 'npm(jshint)'
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1352696, 1274736
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1274736 [Bug 1274736] Review Request: nodejs-benchmark - A benchmarking library https://bugzilla.redhat.com/show_bug.cgi?id=1352696 [Bug 1352696] Review Request: nodejs-jshint - Static analysis tool for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
--- Comment #2 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- Please correct the following rpmlint issues:
nodejs-jshint.noarch: W: hidden-file-or-dir /usr/share/doc/nodejs-jshint/examples/.jshintrc nodejs-jshint.noarch: W: hidden-file-or-dir /usr/share/doc/nodejs-jshint/examples/.customignore nodejs-jshint.noarch: W: hidden-file-or-dir /usr/share/doc/nodejs-jshint/examples/.jshintignore
nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/build /usr/bin/env node nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/jshint /usr/bin/env node nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/land /usr/bin/env node nodejs-jshint.noarch: E: wrong-script-interpreter /usr/lib/node_modules/jshint/bin/apply /usr/bin/env node
https://bugzilla.redhat.com/show_bug.cgi?id=1363763 Bug 1363763 depends on bug 1274736, which changed state.
Bug 1274736 Summary: Review Request: nodejs-benchmark - A benchmarking library https://bugzilla.redhat.com/show_bug.cgi?id=1274736
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1363763 Bug 1363763 depends on bug 1352696, which changed state.
Bug 1352696 Summary: Review Request: nodejs-jshint - Static analysis tool for JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=1352696
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1363763 Bug 1363763 depends on bug 1352696, which changed state.
Bug 1352696 Summary: Review Request: nodejs-jshint - Static analysis tool for JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=1352696
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|RAWHIDE |---
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
--- Comment #3 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- Sorry about comment #2...
I suspect these may be required for tests:
nodejs-js-beautify.noarch: E: zero-length /usr/lib/node_modules/js-beautify/js/test/resources/configerror/subDir1/subDir2/empty.txt nodejs-js-beautify.noarch: E: zero-length /usr/lib/node_modules/js-beautify/js/test/resources/indent11chars/subDir1/subDir2/empty.txt
nodejs-js-beautify.noarch: W: hidden-file-or-dir /usr/lib/node_modules/js-beautify/js/test/resources/configerror/.jsbeautifyrc nodejs-js-beautify.noarch: W: hidden-file-or-dir /usr/lib/node_modules/js-beautify/js/test/resources/indent11chars/.jsbeautifyrc
But I'm not sure whether these files need to be executable:
nodejs-js-beautify.noarch: E: script-without-shebang /usr/lib/node_modules/js-beautify/js/test/amd-beautify-tests.js nodejs-js-beautify.noarch: E: script-without-shebang /usr/lib/node_modules/js-beautify/js/test/node-beautify-tests.js
Also, wrong interpreter errors, but apparently the guidelines on that have not yet passed;
nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/lib/cli.js /usr/bin/env node nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/bin/css-beautify.js /usr/bin/env node nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/bin/js-beautify.js /usr/bin/env node nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/bin/html-beautify.js /usr/bin/env node nodejs-js-beautify.noarch: E: wrong-script-interpreter /usr/lib/node_modules/js-beautify/js/test/shell-smoke-test.sh /usr/bin/env bash
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1305718 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1305718 [Bug 1305718] Review Request: nodejs-preserve - Substitute tokens in the given `string` , then put them back
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1387531 (Node-RED)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED
https://bugzilla.redhat.com/show_bug.cgi?id=1363763
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1269538 (IoT) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1363763 Bug 1363763 depends on bug 1352696, which changed state.
Bug 1352696 Summary: Review Request: nodejs-jshint - Static analysis tool for JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=1352696
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CANTFIX
package-review@lists.fedoraproject.org