https://bugzilla.redhat.com/show_bug.cgi?id=2184719
Bug ID: 2184719 Summary: Review Request: rust-gdk4-wayland-sys - FFI bindings of GDK4 Wayland Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: klember@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://kalev.fedorapeople.org/rust-gdk4-wayland-sys.spec SRPM URL: https://kalev.fedorapeople.org/rust-gdk4-wayland-sys-0.6.3-1.fc39.src.rpm Description: FFI bindings of GDK4 Wayland. Fedora Account System Username: kalev
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99555853
https://bugzilla.redhat.com/show_bug.cgi?id=2184719
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2184722
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2184722 [Bug 2184722] Review Request: rust-gdk4-wayland - Rust bindings of the GDK 4 Wayland library
https://bugzilla.redhat.com/show_bug.cgi?id=2184719
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/gd | |k4-wayland-sys
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5745868 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2184719
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review+ Status|NEW |POST CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
I assume that you created a rust2rpm.conf file to add BuildRequires / Requires to the respective subpackages? Make sure to also import that.
https://bugzilla.redhat.com/show_bug.cgi?id=2184719
--- Comment #3 from Kalev Lember klember@redhat.com --- Thanks for the review! Yes, I created a rust2rpm.conf and have it in local git.
https://bugzilla.redhat.com/show_bug.cgi?id=2184719
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gdk4-wayland-sys
https://bugzilla.redhat.com/show_bug.cgi?id=2184719
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-29d8d479ae has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-29d8d479ae
https://bugzilla.redhat.com/show_bug.cgi?id=2184719
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-04-21 20:37:06
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-29d8d479ae has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org