[Bug 538673] New: Review Request: libunitstring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libunitstring - GNU Unicode string library

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Summary: Review Request: libunitstring - GNU Unicode string
                    library
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://www.pixelbeat.org/patches/libunistring/libunistring.spec
SRPM URL:
http://www.pixelbeat.org/patches/libunistring/libunistring-0.9.1-1.fc11.src....
Description: This is a new portable unicode library by Bruno Haible and is used
in Guile and soon to be used in coreutils. It's already included in debian and
mandrake.

[Bug 538673] Review Request: libunitstring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Pádraig Brady  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #1 from Pádraig Brady   2009-11-19 03:56:05 EDT ---
Oops, obviously the package name is libunistring not libunitstring.
Also adding Jim and Bruno to CC

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Jim Meyering  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
            Summary|Review Request:             |Review Request:
                   |libunitstring - GNU Unicode |libunistring - GNU Unicode
                   |string library              |string library

--- Comment #2 from Jim Meyering   2009-11-19 05:17:30 EDT ---
Thanks!  I'll take it.  Corrected the title.

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Parag AN(पराग)   2009-11-19 06:14:44 EDT ---
oops while working on this review I guess Jim already took this. Anyway here is
my review work
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1815778
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
75e9d6f79a321a62497f1808db35a1b52b7ba765  libunistring-0.9.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Package contains code, not content.
+ no .pc file present.
+ -devel subpackage present.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libunistring-0.9.1-1.fc13.i686 =>
Provides: libunistring.so.0
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4)
libunistring.so.0 rtld(GNU_HASH)
+ Package libunistring-devel-0.9.1-1.fc13.i686 =>
Requires: libunistring.so.0
+ Not a GUI application

Suggestions:
1) you can simply write description for -devel package as
Development files for programs using libunistring.

2) to preserve timestamps of upstream files that are copied as it is use
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

3)defattr for devel should be 
%defattr(-,root,root,-)

4) Good if you follow same way of writing macros as defined at
https://fedoraproject.org/wiki/Packaging/RPMMacros
though %_libdir is same as %{_libdir}

5) Use scriptlet format given at
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo including
changing Requires also.

6) I don't see any use of including 
Requires: pkgconfig
for -devel package. Please remove it.

7) you don't need 
BuildRequires: automake libtool
remove them.

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

--- Comment #4 from Jim Meyering   2009-11-19 06:25:23 EDT ---
Hi Parag, you're welcome to do the review.  I didn't know you'd started. 
Please reassign to yourself, if you can, or let me know and I'll do it.

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]         |[e-mail]
               Flag|                            |fedora-review?

--- Comment #5 from Parag AN(पराग)   2009-11-19 07:32:32 EDT ---
Thanks you. I will review this. Please feel free to comment if I miss anything
to check in this review.

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

--- Comment #6 from Pádraig Brady   2009-11-19 09:48:40 EDT ---
Thanks for the quick review. Update now at

http://www.pixelbeat.org/patches/libunistring/libunistring.spec
http://www.pixelbeat.org/patches/libunistring/libunistring-0.9.1-2.fc11.src....

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Ralf Corsepius  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Ralf Corsepius   2009-11-19 11:17:06 EDT ---
These
BuildRequires: glibc-devel texinfo
also not needed.

Please remove them.

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

--- Comment #8 from Parag AN(पराग)   2009-11-19 11:41:55 EDT ---
Thanks Ralf.

Pádraig can you please update again SRPM?
Also change following lines
rm -f ${RPM_BUILD_ROOT}/%{_infodir}/dir
rm -f ${RPM_BUILD_ROOT}/%{_libdir}/%{name}.la

to

rm -f $RPM_BUILD_ROOT/%{_infodir}/dir
rm -f $RPM_BUILD_ROOT/%{_libdir}/%{name}.la

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

--- Comment #9 from Pádraig Brady   2009-11-19 11:58:54 EDT ---
Now no BuildRequires at all and ${RPM_BUILD_ROOT} -> $RPM_BUILD_ROOT

http://www.pixelbeat.org/patches/libunistring/libunistring.spec
http://www.pixelbeat.org/patches/libunistring/libunistring-0.9.1-3.fc11.src....

cheers

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #10 from Parag AN(पराग)   2009-11-20 01:31:11 EDT ---
Looks ok now.
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1818869

APPROVED.

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Pádraig Brady  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #11 from Pádraig Brady   2009-11-20 10:59:02 EDT ---
New Package CVS Request
=======================
Package Name: libunistring
Short Description: GNU Unicode string library
Owners: pbrady meyering
Branches: F-11 F-12
InitialCC: i18n-team

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #12 from Dennis Gilmore   2009-11-20 17:38:16 EDT ---
CVS Done

[Bug 538673] Review Request: libunistring - GNU Unicode string library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538673

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #13 from Parag AN(पराग)   2009-12-09 01:16:17 EDT ---
This looks already built for all branches.