[Bug 1352837] New: Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Bug ID: 1352837
           Summary: Review Request: vassal - Game engine for building and
                    playing online adaptations of board games and card
                    games
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/vassal.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/vassal-3.2.16-1.fc25.src....
Description:
Vassal is a game engine for building and playing online adaptations of board
games and card games. Play live on the Internet or by email.
Fedora Account System Username: ignatenkobrain

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |vassal

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)
                 CC|                            |[e-mail]

--- Comment #1 from Igor Gnatenko  ---
*** Bug 1132266 has been marked as a duplicate of this bug. ***

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

--- Comment #2 from Igor Gnatenko  ---
Note that not all bundled jars are available in repos. I don't know how
properly make Provides: bundled() for them.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

jiri vanek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from jiri vanek  ---
(In reply to Igor Gnatenko from comment #2)
> Note that not all bundled jars are available in repos. I don't know how
> properly make Provides: bundled() for them.

As far as I can tell, you cant.
The only proper way is to pack all the bundleds and then build against them. Or
not anymore?

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

--- Comment #4 from Igor Gnatenko  ---
(In reply to jiri vanek from comment #3)
> (In reply to Igor Gnatenko from comment #2)
> > Note that not all bundled jars are available in repos. I don't know how
> > properly make Provides: bundled() for them.
>
> As far as I can tell, you cant.
> The only proper way is to pack all the bundleds and then build against them.
> Or not anymore?

Well, it's still not blocker to have bundled dependencies.

I don't know Java packaging guidelines much (and don't want to), so I just
built this package with as much as possible using system libraries.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

--- Comment #5 from jiri vanek  ---
Unless there was some change in guidelines, it is blocker to pack bundled
libraries. I would recommend you to check with java-maint group.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

--- Comment #6 from Igor Gnatenko  ---
(In reply to jiri vanek from comment #5)
> Unless there was some change in guidelines, it is blocker to pack bundled
> libraries. I would recommend you to check with java-maint group.

Then you didn't read new guidelines, it's allowed for ~3 months already.
Probably even more.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Ben Rosser  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1364745

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] (FE-GAMESIG) Games SIG tracker bug

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Jeremy Newton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Jeremy Newton  ---
Hi,

I can take this review if you're interested in review swapping with me

(In reply to Igor Gnatenko from comment #2)
> Note that not all bundled jars are available in repos. I don't know how
> properly make Provides: bundled() for them.

Although the bundling policy is looser now, you still require the "Provides:
bundled()" information for anything that you cannot unbundle. This makes it
easier to track bundled libraries, such as if the library is introduced into
fedora and it can be unbundled, or if a security issue exists and all bundled
versions must be patched, etc.

For example if you bundled "foo" with version "1.0.0":

Provides: bundled(foo) = 1.0.0

See the guidelines for details:
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

--- Comment #8 from Igor Gnatenko  ---
Let's swap.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

--- Comment #9 from Jeremy Newton  ---
Sounds good, I have the following available:
https://bugzilla.redhat.com/show_bug.cgi?id=1379765

But it doesn't build against rawhide, so I'll have to look into that. Although,
we can review this first.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Jeremy Newton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #10 from Jeremy Newton  ---
Please add the required bundled provides. Let me know if you need assistance. I
would think that everything printed by "find lib/ -print" would be bundled.

Let me know if you're still alright with review swapping #1379765

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

--- Comment #11 from Jeremy Newton  ---
If you're still interested, please let me know, I have the following available
for swap:

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

I'm just waiting on you to update the specs before I can review this.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Jeremy Newton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|[e-mail]         |[e-mail]

--- Comment #12 from Jeremy Newton  ---
I don't have any reviews to swap and I no longer have interested in reviewing
this. This is up for grabs again.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Ben Rosser  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(ignatenko@redhat.
                   |                            |com)

--- Comment #13 from Ben Rosser  ---
Hi Igor,

Somehow I missed this package on my previous pass through the FE-GAMESIG
tickets, apologies. :( Are you still interested in it? I can review if so.

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |WONTFIX
              Flags|needinfo?(ignatenko@redhat. |
                   |com)                        |
        Last Closed|                            |2018-08-22 03:29:59

--- Comment #14 from Igor Gnatenko  ---
Unfortunately I don't have time to work on these review requests anymore,
sorry.