https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Bug ID: 1483129 Summary: golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: athoscribeiro@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-neurosnap-sentences... SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-neurosnap-sentences... Description: Multilingual command line sentence tokenizer in Golang Fedora Account System Username: athoscr
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1480762
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1480762 [Bug 1480762] Review Request: golang-github-jdkato-prose - Golang library for text processing
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- %global import_path %{provider_prefix}
You should use this as import path, but use the upstream provided one, gopkg.in/neurosnap/sentences.v1
%global import_path gopkg.in/neurosnap/sentences.v1
And in the bottom of the spec:
%dir %{gopath}/src/gopkg.in/neurosnap/sentences.v1
Otherwise projects depending on this won't find it. Likewise you shouldn't patch the source in bug #1480762, it will find it once this is fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- s/should/shouldn't/
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #3 from Athos Ribeiro athoscribeiro@gmail.com --- What if some project decides to
import "github.com/neurosnap/sentences" ?
Note that upstream does so, here [1] and here [2]. So I see 3 possible options:
a) packaging this under both namespaces b) package only one of the namespaces and patch the source code and dependencies to stick to only one namespace
(a) seems to be a good option at first, but then if we pay closer attention to the namespace in 'gopkg.in/neurosnap/sentences.v1', it carries the package major version with it. So whenever they decide to bump the major version, we would need to package it again and retire the old namespace. I believe this is not a good approach for software distribution. That's why I opted to go with (b).
If you prefer, we could go with (a), but packaging only gopkg.in/neurosnap/sentences.v1 is not possible because upstream itself would not build without the github package. A third option (c) would be to send a patch upstream to make [1] and [2] import gopkg.in/neurosnap/sentences.v1
But then this would still be a problem if some other project we want to package ever decides to import the github path for some reason (I do not have a solution for this).
[1] https://github.com/neurosnap/sentences/blob/eaa759e51378560dd9b545de7502d7c9...
[2] https://github.com/neurosnap/sentences/blob/c4a4a02cd25ad0d1b1b623459a63fbec...
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- You can go with (a) and define a x_provider, x_provider_tld, x_project, x_repo and x_import_path for the second one, then add the list of provides with the second import_path, then do a symlink between the two:
ln -sT %{gopath}/src/%{import_path} %{buildroot}%{gopath}/src/%{x_import_path}
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #5 from Athos Ribeiro athoscribeiro@gmail.com --- You mean, packaging 2 different -devel subpackages, like the extra packages from golang.org/x/foo? That works for me. I will prepare sth and update the sources as soon as I can.
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #6 from Robert-André Mauchin zebob.m@gmail.com --- No. No need for two -devel packages, just one with the double provides and a symlink. I have a sample somewhere, see this spec: https://github.com/eclipseo/packaging/blob/master/golang-googlecode-image.sp...
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #7 from Athos Ribeiro athoscribeiro@gmail.com --- Makes sense!
I will apply the changes as soon as I can. Thanks for the input and example
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #8 from Athos Ribeiro athoscribeiro@gmail.com --- Hi Robert,
Here is the updated package. I have one point worth mentioning here:
- I am not sure what to do with the '/usr/share/gocode/src/gopkg.in' directry. Usually, the golang package owns the directories in that level, as it does with the /usr/share/gocode/src/github.com one. I will ping the golang package maintainers about it to check if they are willing to include such directory in the package. Currently, I am not owning it in this package.
Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-neurosnap-sentences... SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-neurosnap-sentences...
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Robert-André Mauchin (afk until Mon 11) zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #9 from Robert-André Mauchin (afk until Mon 11) zebob.m@gmail.com --- Everything seems in order, package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #10 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-neurosnap-sentences
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|golang-github-neurosnap-sen |Review Request: |tences - Multilingual |golang-github-neurosnap-sen |command line sentence |tences - Multilingual |tokenizer in Golang |command line sentence | |tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-09-11 15:10:39
package-review@lists.fedoraproject.org