[Bug 847558] New: Review Request: mate-icon-theme - Icon theme for MATE Desktop - package-review - Fedora Mailing-Lists

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Bug 847558] New: Review Request: mate-icon-theme - Icon theme for MATE Desktop

[Bug 824703] New: Review Request:...

[Bug 854458] New: Review Request:...

Red Hat Bugzilla

Sunday, 12 August 2012 Sun, 12 Aug '12

6:36 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Bug ID: 847558 QA Contact: extras-qa(a)fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting(a)redhat.com, package-review(a)lists.fedoraproject.org Assignee: nobody(a)fedoraproject.org Summary: Review Request: mate-icon-theme - Icon theme for MATE Desktop Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: dan.mashal(a)gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://vicodan.fedorapeople.org/matespec/mate-icon-theme.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-icon-theme-1.4.0-1.fc... Description: Icon theme for MATE Desktop -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Show replies by date

Red Hat Bugzilla

Sunday, 12 August Sun, 12 Aug

6:37 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |840149 (MATE-DE-tracker) Alias| |mate-icon-theme -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

6:41 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |845694 | |(mate-system-monitor) -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

6:46 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Rex Dieter <rdieter(a)math.unl.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter(a)math.unl.edu --- Comment #1 from Rex Dieter <rdieter(a)math.unl.edu> --- offhand, 1 move NOCONFIGURE=1 ./autogen.sh to %setup section 2. add icon-related scriptlets: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 3. make the package noarch (and drop %{_isa}) -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

7:10 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #2 from Dan Mashal <dan.mashal(a)gmail.com> --- Done. Please check it. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-icon-theme.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-icon-theme-1.4.0-2.fc... -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

7:27 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #3 from Rex Dieter <rdieter(a)math.unl.edu> --- Make the scriptlets reference mate instead of hicolor... -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

7:57 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #4 from Dan Mashal <dan.mashal(a)gmail.com> --- Fixed. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-icon-theme.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-icon-theme-1.4.0-3.fc... -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

Monday, 13 August Mon, 13 Aug

9:54 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 leigh scott <leigh123linux(a)googlemail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux(a)googlemail.co | |m Blocks| |844152 (mate-file-manager) -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

10:18 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Wolfgang Ulbrich <chat-to-me(a)raveit.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody(a)fedoraproject.org |chat-to-me(a)raveit.de -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

10:58 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #5 from Wolfgang Ulbrich <chat-to-me(a)raveit.de> --- Dan, in repo i have a subpackage -legacy. So, for updating my package from external repo, we need a subpackage here too. %package legacy Summary: Old names for icons in mate-icon-theme Group: User Interface/Desktops Requires: %{name} = %{version}-%{release} %description legacy This package contains symlinks to make the icons in mate-icon-theme available under old names. Under install after 'make install DESTDIR=%{buildroot}',we need this # Add scalable directories for symbolic icons (cd $RPM_BUILD_ROOT%{_datadir}/icons/mate mkdir -p scalable/actions mkdir -p scalable/apps mkdir -p scalable/devices mkdir -p scalable/emblems mkdir -p scalable/mimetypes mkdir -p scalable/places mkdir -p scalable/status ) (cd $RPM_BUILD_ROOT%{_datadir} find icons/mate \( -name gtk-* -or -type f \) -printf "%%%%{_datadir}/%%p\n" find icons/mate -type d -printf "%%%%dir %%%%{_datadir}/%%p\n" ) > files.txt (cd $RPM_BUILD_ROOT%{_datadir} find icons/mate \( -type l -and -not -name gtk-* \) -printf "%%%%{_datadir}/%%p\n" ) > legacy.txt In result you can use in file section %files -f files.txt %files legacy -f legacy.txt Also we need post postun and posttrans for legacy subpackage. %post legacy /bin/touch --no-create %{_datadir}/icons/mate &>/dev/null || : %postun legacy if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/mate &>/dev/null /usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/mate &>/dev/null || : fi %posttrans legacy /usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/mate &>/dev/null || : That's all ;) There is a white space beding this line NOCONFIGURE=1 ./autogen.sh But this is cosmetic. Add subpackage and i will approve your package. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

10:59 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #6 from Wolfgang Ulbrich <chat-to-me(a)raveit.de> --- sorry, i mean 'behind' -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

11:06 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #7 from Rex Dieter <rdieter(a)math.unl.edu> --- Can you provide some justification or purpose for this -legacy subpkg? what needs these symlinks? and why not just include them in the main package? -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

11:22 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #8 from Wolfgang Ulbrich <chat-to-me(a)raveit.de> --- I've talked with Rex, we don't need this subpackage, but you have to obsolete mate-icon-theme-legacy from my repo. This you can do after the package is approved. ;) -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

11:36 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #9 from Wolfgang Ulbrich <chat-to-me(a)raveit.de> --- Package is APPROVED Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [ ]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [ ]: MUST Package contains no bundled libraries. [ ]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [ ]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [ ]: MUST Package contains desktop file if it is a GUI application. [ ]: MUST Development files must be in a -devel package [ ]: MUST Package requires other packages for directories it uses. [ ]: MUST Package uses nothing in %doc for runtime. [ ]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [ ]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [ ]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* UNKNOWN" For detailed output of licensecheck see file: /home/rave/847558-mate-icon-theme/licensecheck.txt [ ]: MUST License file installed when any subpackage combination is installed. [ ]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [ ]: MUST Package is named according to the Package Naming Guidelines. [ ]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [ ]: MUST Package obeys FHS, except libexecdir and /usr/target. [ ]: MUST Package must own all directories that it creates. [ ]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [ ]: MUST Package is not relocatable. [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 [ ]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [ ]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: SHOULD Package functions as described. [ ]: SHOULD Latest version is packaged. [ ]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD The placement of pkgconfig(.pc) files are correct. [ ]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 See: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5 Rpmlint ------- Checking: mate-icon-theme-1.4.0-3.fc19.noarch.rpm mate-icon-theme-devel-1.4.0-3.fc19.noarch.rpm mate-icon-theme-1.4.0-3.fc19.src.rpm mate-icon-theme-devel.noarch: W: no-documentation mate-icon-theme.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 1) 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mate-icon-theme-devel mate-icon-theme-devel.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- mate-icon-theme-1.4.0-3.fc19.noarch.rpm (rpmlib, GLIBC filtered): /bin/sh mate-icon-theme-devel-1.4.0-3.fc19.noarch.rpm (rpmlib, GLIBC filtered): /usr/bin/pkg-config Provides -------- mate-icon-theme-1.4.0-3.fc19.noarch.rpm: mate-icon-theme = 1.4.0-3.fc19 mate-icon-theme-devel-1.4.0-3.fc19.noarch.rpm: mate-icon-theme-devel = 1.4.0-3.fc19 pkgconfig(mate-icon-theme) = 1.4.0 MD5-sum check ------------- http://pub.mate-desktop.org/releases/1.4/mate-icon-theme-1.4.0.tar.xz : MD5SUM this package : da3294f963b6e46751677294e82cf228 MD5SUM upstream package : da3294f963b6e46751677294e82cf228 Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09 Command line :/usr/bin/fedora-review -b 847558 External plugins: -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

11:37 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Wolfgang Ulbrich <chat-to-me(a)raveit.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

11:54 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-cvs? --- Comment #10 from Dan Mashal <dan.mashal(a)gmail.com> --- New Package SCM Request ======================= Package Name: mate-icon-theme Short Description: Icon theme for MATE Desktop Owners: vicodan rdieter raveit65 Branches: f16 f17 18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

11:55 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #11 from Jon Ciesla <limburgher(a)gmail.com> --- Git done (by process-git-requests). 18->f18. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

1:01 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Fedora Update System <updates(a)fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

1:01 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #12 from Fedora Update System <updates(a)fedoraproject.org> --- mate-icon-theme-1.4.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mate-icon-theme-1.4.0-3.fc16 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

1:01 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #13 from Fedora Update System <updates(a)fedoraproject.org> --- mate-icon-theme-1.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-icon-theme-1.4.0-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

Tuesday, 14 August Tue, 14 Aug

4:18 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #14 from Fedora Update System <updates(a)fedoraproject.org> --- mate-icon-theme-1.4.0-6.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mate-icon-theme-1.4.0-6.fc16 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

4:19 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #15 from Fedora Update System <updates(a)fedoraproject.org> --- mate-icon-theme-1.4.0-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-icon-theme-1.4.0-6.fc17 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

4:19 a.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Fedora Update System <updates(a)fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA --- Comment #16 from Fedora Update System <updates(a)fedoraproject.org> --- mate-icon-theme-1.4.0-3.fc16 has been pushed to the Fedora 16 testing repository. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

Sunday, 19 August Sun, 19 Aug

4:51 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Fedora Update System <updates(a)fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-08-19 17:51:07 --- Comment #17 from Fedora Update System <updates(a)fedoraproject.org> --- mate-icon-theme-1.4.0-6.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

4:51 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 --- Comment #18 from Fedora Update System <updates(a)fedoraproject.org> --- mate-icon-theme-1.4.0-6.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

Sunday, 26 August Sun, 26 Aug

11:10 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|844152 (mate-file-manager) | -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Red Hat Bugzilla

Friday, 19 October Fri, 19 Oct

2:25 p.m.

New subject: [Bug 847558] Review Request: mate-icon-theme - Icon theme for MATE Desktop

https://bugzilla.redhat.com/show_bug.cgi?id=847558 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|845694 | -- You are receiving this mail because: You are on the CC list for the bug.

Reply

4266

days inactive

4334

days old

package-review@lists.fedoraproject.org

Manage subscription

26 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla