[Bug 2244404] New: Review Request: python-imapclient - Easy-to-use, Pythonic and complete IMAP client library
6:31 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Bug ID: 2244404
Summary: Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: gui1ty(a)penguinpee.nl
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fed...
Description:
IMAPClient is an easy-to-use, Pythonic and complete IMAP client library.
Features:
- Arguments and return values are natural Python types
- IMAP server responses are fully parsed and readily usable
- IMAP unique message IDs (UIDs) are handled transparently
- Internationalised mailbox names are transparently handled
- Time zones are correctly handled
- Convenience methods are provided for commonly used functionality
- Exceptions are raised when errors occur
Python versions 2.7 and 3.4 through 3.9 are officially supported.
IMAPClient includes comprehensive units tests and automated functional
tests that can be run against a live IMAP server.
Fedora Account System Username: gui1ty
Copr Build:
https://copr.fedorainfracloud.org/coprs/gui1ty/extract-msg/build/6529511/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
6:44 a.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Sandro <gui1ty(a)penguinpee.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2244408
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2244408
[Bug 2244408] Review Request: extract-msg - Extracts emails and attachments
saved in M$ Outlook .msg files
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
2:21 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Benson Muite <benson_muite(a)emailplus.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
Assignee|nobody(a)fedoraproject.org |benson_muite(a)emailplus.org
CC| |benson_muite(a)emailplus.org
Status|NEW |ASSIGNED
Flags| |fedora-review?
--- Comment #1 from Benson Muite <benson_muite(a)emailplus.org> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Dist tag is present.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-Clause License", "*No
copyright*
BSD 3-Clause License". 27 files have unknown license. Detailed output
of licensecheck in /home/fedora/2244404-python-
imapclient/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 7722 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[-]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[ ]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define autorelease(e:s:pb:n)
%{?-p:0.}%{lua:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-imapclient-2.3.1-1.fc40.noarch.rpm
python-imapclient-2.3.1-1.fc40.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpfhflh34x')]
checks: 31, packages: 2
2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken
0.2 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken
0.1 s
Source checksums
----------------
https://github.com/mjs/imapclient/archive/2.3.1/imapclient-2.3.1.tar.gz :
CHECKSUM(SHA256) this package :
bb9b8b07a080652254ef01891cc1c8e506a35f5b21214ef7073a55fa10ecdfd6
CHECKSUM(SHA256) upstream package :
bb9b8b07a080652254ef01891cc1c8e506a35f5b21214ef7073a55fa10ecdfd6
Requires
--------
python3-imapclient (rpmlib, GLIBC filtered):
python(abi)
python3.12dist(six)
Provides
--------
python3-imapclient:
python-imapclient
python3-imapclient
python3.12-imapclient
python3.12dist(imapclient)
python3dist(imapclient)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2244404
Buildroot used: fedora-rawhide-aarch64
Active plugins: Python, Generic, Shell-api
Disabled plugins: fonts, C/C++, Haskell, Ocaml, Perl, SugarActivity, Java, R,
PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments:
a) Can the documentation and/or examples be packaged?
b) README needs an update, in particular:
Python versions 2.7 and 3.4 through 3.9 are officially supported.
Maybe upstream would accept a pull request.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
7:01 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
--- Comment #2 from Sandro <gui1ty(a)penguinpee.nl> ---
Thank you for the review.
Regarding your comments:
a) I added the examples. However, I am not going to add docs. I looked into it.
They use Sphinx for generating HTML docs. But that's essentially the same as
online on Read the Docs: https://imapclient.readthedocs.io/ (also mentioned in
README.rst). Sphinx generated documents are problematic with regards to the
license of the Javascript files. I also tried generating a man page. But that
ends up in the wrong section and I couldn't be bothered fixing that. Again,
because everything is available online.
b) I agree. It looks like this has been updated on master after 2.3.1 was
released. I patched README.rst so it is in agreement with the updated
description.
Spec URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fed...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
10:59 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
--- Comment #3 from Benson Muite <benson_muite(a)emailplus.org> ---
Is pdf documentation also problematic?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
3:53 a.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
--- Comment #4 from Sandro <gui1ty(a)penguinpee.nl> ---
(In reply to Benson Muite from comment #3)
Is pdf documentation also problematic?
Yes. You need to pull in a massive dependency stack of latex packages and what
not, since that's how Sphinx does it: rst --> tex --> pdf
I find that an unnecessary burden and ballooning of the build environment,
especially in cases where there is good online documentation.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
9:06 a.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Sandro <gui1ty(a)penguinpee.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(benson_muite@emai
| |lplus.org)
--- Comment #5 from Sandro <gui1ty(a)penguinpee.nl> ---
Ping?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:47 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Benson Muite <benson_muite(a)emailplus.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|needinfo?(benson_muite@emai |
|lplus.org) |
Status|ASSIGNED |POST
--- Comment #6 from Benson Muite <benson_muite(a)emailplus.org> ---
Not everybody has great online access. A separate offline docs package is very
helpful.
Not a must item though.
Upon import, please change
%doc *.rst examples
to
%doc NEWS.rst README.rst examples
as Authors.rst is in the dist-info directory.
Approved.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
4:46 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
--- Comment #7 from Sandro <gui1ty(a)penguinpee.nl> ---
(In reply to Benson Muite from comment #6)
Not everybody has great online access. A separate offline docs
package is
very helpful.
I agree. I provide docs where they are available or can easily be generated
without introducing new license requirements or bundled dependencies. But I
also feel there must be a balance between dependencies required for the docs
and for the package itself.
Not a must item though.
Upon import, please change
%doc *.rst examples
to
%doc NEWS.rst README.rst examples
as Authors.rst is in the dist-info directory.
Good point. I will change that before importing.
Approved.
Thanks for the review!
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
4:50 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
--- Comment #8 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org> ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-imapclient
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
5:09 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |MODIFIED
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2023-b50524e5e7 has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-b50524e5e7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
5:10 p.m.
New subject: [Bug 2244404] Review Request: python-imapclient - Easy-to-use,
Pythonic and complete IMAP client library
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
Last Closed| |2023-10-27 22:10:10
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2023-b50524e5e7 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244404
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
220
days inactive
231
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
bugzilla＠redhat.com