https://bugzilla.redhat.com/show_bug.cgi?id=1396331
Bug ID: 1396331 Summary: Review Request: elfio - C++ library for reading and generating ELF files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: orion@cora.nwra.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://www.cora.nwra.com/~orion/fedora/elfio.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/elfio-3.2-1.fc26.src.rpm Description: ELFIO is a small, header-only C++ library that provides a simple interface for reading and generating files in ELF binary format.
It is used as a standalone library - it is not dependant on any other product or project. Adhering to ISO C++, it compiles on a wide variety of architectures and compilers.
While the library is easy to use, some basic knowledge of the ELF binary format is required. Such Information can easily be found on the Web.
Fedora Account System Username: orion
https://bugzilla.redhat.com/show_bug.cgi?id=1396331
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ignatenko@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1396331
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #1 from Igor Gnatenko ignatenko@redhat.com --- Some issues to fix, but in general looks good.
[!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://downloads.sf.net/elfio/elfio-3.2.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
elfio-devel.noarch: W: spelling-error %description -l en_US dependant -> dependent, defendant, depend ant elfio-devel.noarch: E: zero-length /usr/share/doc/elfio-devel/ChangeLog elfio-devel.noarch: E: zero-length /usr/share/doc/elfio-devel/NEWS elfio.src: W: spelling-error %description -l en_US dependant -> dependent, defendant, depend ant
Missing BuildRequires: gcc-c++
make %{?_smp_mflags} -> %make_build
you could also run some "tests" in %check. Because elfdump is compiled anyway, just run it against, let's say %{_bindir}/make.
https://bugzilla.redhat.com/show_bug.cgi?id=1396331
--- Comment #2 from Orion Poplawski orion@cora.nwra.com --- Thanks for the review. Issues have been fixed.
* Sat Nov 19 2016 Orion Poplawski orion@cora.nwra.com - 3.2-2 - Fix source url - Add BR gcc-c++ - Add %%check - Other cleanup
https://bugzilla.redhat.com/show_bug.cgi?id=1396331
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/elfio
https://bugzilla.redhat.com/show_bug.cgi?id=1396331
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2016-11-23 20:44:38
--- Comment #4 from Orion Poplawski orion@cora.nwra.com --- Checked in and built. Thanks.
package-review@lists.fedoraproject.org