Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: urlwatch - A tool for monitoring webpages for updates
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Summary: Review Request: urlwatch - A tool for monitoring webpages for updates Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/urlwatch.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/urlwatch-1.7-1.fc9.src.rpm
Project URL: http://thpinfo.com/2008/urlwatch/
Description: This script is intended to help you watch URLs and get notified (via email or in your terminal) of any changes. The change notification will include the URL that has changed and a unified diff of what has changed.
The script supports the use of a filtering hook function to strip trivially-varying elements of a webpage.
Basic features
* Simple configuration (text file, one URL per line) * Easily hackable (clean Python implementation) * Can run as a cronjob and mail changes to you * Always outputs only plaintext - no HTML mails :) * Supports removing noise (always-changing website parts) * Example hooks to filter content in Python
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1066723
rpmlint output: [fab@laptop024 noarch]$ rpmlint urlwatch-1.7-1.fc9.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[fab@laptop024 SRPMS]$ rpmlint urlwatch-1.7-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Jochen Schmitt jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@herr-schmitt.de AssignedTo|nobody@fedoraproject.org |jochen@herr-schmitt.de Flag| |fedora-review+
--- Comment #1 from Jochen Schmitt jochen@herr-schmitt.de 2009-01-19 14:12:01 EDT --- God: + Basename of SPEC file matches with package name + Package name fits with maming guidelines + Consistently usage of rpm macros + Package contains no subpackages + Source tar ball could downloaed via spectool + Tar ball in package matches with upstream (md5sum: 29b3a00caad5f45c905ec621bec26687) + Package contains valid License tag + License tag has MIT as an valid OSS license + Package contains verbatin copy of the license text + Buildroot will be clean on the beginning of %install and %clean + Package has a %clean stanza + Local buidl works fine. + Local install works fine + Simple call to urlwatch works without crash + Local uninstall works fine + Build on koji works fine + Package will be build as noarch + Rpmlint has no complaints for source rpm + Rpmlint has no complaints for binary rpm + Files has proper file permissions + All packaged files are owned by the package + No packaged files are claimed by other packages + %doc stanza has small amount of files, so we need no separate doc subpackage
*** APPROVED ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@ispbrasil.com.br
--- Comment #2 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-01-19 14:34:14 EDT --- the license stated in urlwatch website is another.
http://thpinfo.com/2008/urlwatch/
"License urlwatch is released under the terms of the BSD license"
why MIT in spec file ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
--- Comment #3 from Fabian Affolter fabian@bernewireless.net 2009-01-19 16:00:10 EDT --- Itamar, you are right the license seems more to match the 'New BSD (no advertising, 3 clause)' than MIT. I will change the license tag to BSD before cvs import.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2009-01-19 16:00:55 EDT --- New Package CVS Request ======================= Package Name: urlwatch Short Description: A tool for monitoring webpages for updates Owners: fab Branches: F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2009-01-19 18:01:04 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-01-19 19:02:02 EDT --- urlwatch-1.7-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/urlwatch-1.7-2.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-01-19 19:02:05 EDT --- urlwatch-1.7-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/urlwatch-1.7-2.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
--- Comment #8 from Fabian Affolter fabian@bernewireless.net 2009-01-19 19:03:53 EDT --- Thanks for the review and the cvs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-01-21 16:27:35 EDT --- urlwatch-1.7-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update urlwatch'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0729
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-01-21 16:27:38 EDT --- urlwatch-1.7-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update urlwatch'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0731
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |NEXTRELEASE
--- Comment #11 from Fabian Affolter fabian@bernewireless.net 2009-02-20 06:57:57 EDT --- Was pushed to stable
https://admin.fedoraproject.org/updates/F10/FEDORA-2009-0729 https://admin.fedoraproject.org/updates/F9/FEDORA-2009-0731
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480646
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cassmodiah@fedoraproject.or | |g
--- Comment #12 from Jason Tibbitts tibbs@math.uh.edu 2009-04-01 18:18:31 EDT --- *** Bug 493299 has been marked as a duplicate of this bug. ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla