[Bug 1140002] New: Review Request: python-pymemcache - A comprehensive, fast, pure Python memcached client
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
Bug ID: 1140002 Summary: Review Request: python-pymemcache - A comprehensive, fast, pure Python memcached client Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nsaje@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://nsaje.fedorapeople.org/review/python-pymemcache.spec SRPM URL: https://nsaje.fedorapeople.org/review/python-pymemcache-1.2.5-1.fc20.src.rpm Description: A comprehensive, fast, pure Python memcached client Fedora Account System Username: nsaje Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7562805
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
Nejc Saje nsaje@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1140136
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1140136 [Bug 1140136] Review Request: python-tooz - Coordination library for distributed systems
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
--- Comment #1 from Haïkel Guémar karlthered@gmail.com --- Few points: * missing requirements to python-six and python3-six for python/python3 packages. * add %check and run tests for both python & python3 %check %{__python2} setup.py nosetests %if 0%{?with_python3} pushd %{py3dir} %{__python3} setup.py nosetests popd %endif * I tried the generated packages and they both worked against a running memcached.
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
--- Comment #2 from Nejc Saje nsaje@redhat.com --- Thanks for the super-quick review! Fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |karlthered@gmail.com Flags| |fedora-review+
--- Comment #3 from Haïkel Guémar karlthered@gmail.com --- Since this package complies with Fedora packaging guidelines, I hereby approve it into Fedora Packages Collection. Please submit a scm request.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/haikel/1140002-python- pymemcache/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pymemcache [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-pymemcache-1.2.5-1.fc22.noarch.rpm python3-pymemcache-1.2.5-1.fc22.noarch.rpm python-pymemcache-1.2.5-1.fc22.src.rpm python-pymemcache.noarch: W: spelling-error Summary(en_US) memcached -> schemed python-pymemcache.noarch: W: spelling-error %description -l en_US memcached -> schemed python-pymemcache.noarch: W: spelling-error %description -l en_US recv -> rec, rev, recd python-pymemcache.noarch: W: spelling-error %description -l en_US noreply -> no reply, no-reply, foreplay python-pymemcache.noarch: W: spelling-error %description -l en_US deserialization -> serialization, materialization, denationalization python3-pymemcache.noarch: W: spelling-error Summary(en_US) memcached -> schemed python3-pymemcache.noarch: W: spelling-error %description -l en_US memcached -> schemed python3-pymemcache.noarch: W: spelling-error %description -l en_US recv -> rec, rev, recd python3-pymemcache.noarch: W: spelling-error %description -l en_US noreply -> no reply, no-reply, foreplay python3-pymemcache.noarch: W: spelling-error %description -l en_US deserialization -> serialization, materialization, denationalization python-pymemcache.src: W: spelling-error Summary(en_US) memcached -> schemed python-pymemcache.src: W: spelling-error %description -l en_US memcached -> schemed python-pymemcache.src: W: spelling-error %description -l en_US recv -> rec, rev, recd python-pymemcache.src: W: spelling-error %description -l en_US noreply -> no reply, no-reply, foreplay python-pymemcache.src: W: spelling-error %description -l en_US deserialization -> serialization, materialization, denationalization 3 packages and 0 specfiles checked; 0 errors, 15 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint python-pymemcache python3-pymemcache python-pymemcache.noarch: W: spelling-error Summary(en_US) memcached -> schemed python-pymemcache.noarch: W: spelling-error %description -l en_US memcached -> schemed python-pymemcache.noarch: W: spelling-error %description -l en_US recv -> rec, rev, recd python-pymemcache.noarch: W: spelling-error %description -l en_US noreply -> no reply, no-reply, foreplay python-pymemcache.noarch: W: spelling-error %description -l en_US deserialization -> serialization, materialization, denationalization python3-pymemcache.noarch: W: spelling-error Summary(en_US) memcached -> schemed python3-pymemcache.noarch: W: spelling-error %description -l en_US memcached -> schemed python3-pymemcache.noarch: W: spelling-error %description -l en_US recv -> rec, rev, recd python3-pymemcache.noarch: W: spelling-error %description -l en_US noreply -> no reply, no-reply, foreplay python3-pymemcache.noarch: W: spelling-error %description -l en_US deserialization -> serialization, materialization, denationalization 2 packages and 0 specfiles checked; 0 errors, 10 warnings. # echo 'rpmlint-done:'
Requires -------- python-pymemcache (rpmlib, GLIBC filtered): python(abi) python-six
python3-pymemcache (rpmlib, GLIBC filtered): python(abi) python3-six
Provides -------- python-pymemcache: python-pymemcache
python3-pymemcache: python3-pymemcache
Source checksums ---------------- https://pypi.python.org/packages/source/p/pymemcache/pymemcache-1.2.5.tar.gz : CHECKSUM(SHA256) this package : d8b3d52909eedf975f21236b099510866df8f6cf3d68f67f763609fe2c5ea78b CHECKSUM(SHA256) upstream package : d8b3d52909eedf975f21236b099510866df8f6cf3d68f67f763609fe2c5ea78b
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
Nejc Saje nsaje@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Nejc Saje nsaje@redhat.com --- New Package SCM Request ======================= Package Name: python-pymemcache Short Description: A comprehensive, fast, pure Python memcached client Upstream URL: https://github.com/Pinterest/pymemcache Owners: nsaje Branches: f20 f21 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1140002
Nejc Saje nsaje@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2014-09-11 05:17:59
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla