https://bugzilla.redhat.com/show_bug.cgi?id=2214338
Bug ID: 2214338 Summary: Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-databake.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-databake-0.1.5-1.fc38.src.rpm
Description: Trait that lets structs represent themselves as (const) Rust expressions.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2214338 Bug 2214338 depends on bug 2214343, which changed state.
Bug 2214343 Summary: Review Request: rust-databake-derive - Custom derive for the databake crate https://bugzilla.redhat.com/show_bug.cgi?id=2214343
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2214338
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |h-k-81@hotmail.com Status|NEW |POST Flags| |fedora-review+ CC| |h-k-81@hotmail.com
--- Comment #2 from blinxen h-k-81@hotmail.com --- Taking this review
General comments:
- Package was generated with rust2rpm and the "-a" was added to all "%cargo*" commands
Since this package only builds in rawhide and fedora-review is currently broken in rawhide I can't paste the review template here. But this package fulfills all fedora packaging requirements.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2214338
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
Yeah I added the "-a" flag because otherwise tests don't compile (they require additional features to be enabled).
https://bugzilla.redhat.com/show_bug.cgi?id=2214338
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-databake
https://bugzilla.redhat.com/show_bug.cgi?id=2214338
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Fixed In Version| |rust-databake-0.1.5-1.fc39 Status|POST |CLOSED Last Closed| |2023-07-05 23:12:36
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-22be7fee6a
package-review@lists.fedoraproject.org