[Bug 2339019] New: Review Request: php-splitbrain-lesserphp - PHP library for compiling LESS stylesheets
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
Bug ID: 2339019 Summary: Review Request: php-splitbrain-lesserphp - PHP library for compiling LESS stylesheets Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-1/php-s... srpm: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-1/php-s... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=128210303
Description: LesserPHP is a compiler for LESS written in PHP. It is based on lessphp by leafo. The original has been abandoned in 2014. The fork by MarcusSchwarz has been mostly abandoned in 2021. This is an opinionated fork with the goal to modernize the code base enough to be somewhat easier to maintain without completely rewriting it.
FAS username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8552590 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Remi Collet fedora@famillecollet.com --- [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php/splitbrain
[!]: If the package is a rename of another package, proper Obsoletes and Provides are present. php-splitbrain-lesserphp.noarch: W: obsolete-not-provided php-lessphp
Don't obsolete it or provide it if it is fully compatible but in this case, you also have to package the old autoloader (a link to the new one ?)
[!]: Requires correct, justified where necessary.
Requires: php-cli >= 7.4.0
Please use php(language) >= 7.4.0, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-prov...
Requires: php-date Requires: php-pcre
Both can be removed, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-prov...
About composer.json stuff
1/ you have both a sed command and a patch, why ?
2/ better fix
is to move "tests" in "autoload-dev", which can be submitted to upstream: "autoload": { "psr-4": { "LesserPHP\": "src" } }, "autoload-dev": { "psr-4": { "LesserPHP\tests\": "tests" } },
3/ alternative
use "phpab --template fedora --output src/autoload.php src"
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Created attachment 2073993 --> https://bugzilla.redhat.com/attachment.cgi?id=2073993&action=edit review.txt
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
--- Comment #4 from Remi Collet fedora@famillecollet.com --- Created attachment 2073994 --> https://bugzilla.redhat.com/attachment.cgi?id=2073994&action=edit phpci.log
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
--- Comment #5 from Artur Frenszek-Iwicki fedora@svgames.pl ---
php-splitbrain-lesserphp.noarch: W: obsolete-not-provided php-lessphp
Don't obsolete it or provide it if it is fully compatible but in this case, you also have to package the old autoloader (a link to the new one ?)
Hmm. I want this package to obsolete php-marcusschwarz-lesserphp, which is unmaintained upstream. The package in question also has "Obsoletes: php-lessphp", even though it's not fully compatible. Should I make this obsolete only php-marcusschwarz-lesserphp and remove the php-lessphp bit?
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
--- Comment #6 from Remi Collet fedora@famillecollet.com --- php-lessphp is retired since F32, so no value in obsoleting it
php-marcusschwarz-lesserphp is in the repo
If php-splitbrain-lesserphp is fully compatible you can obsolete/provide it
but in this case it needs to be a true replacement:
- so same provides php-composer(....) which is commonly used - same autoloader path (or symlink to new path)
Else (not compatible), simply ignore the replacement and retire the old one when no more used
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
--- Comment #7 from Artur Frenszek-Iwicki fedora@svgames.pl --- Using dnf repoquery shows that the only package depending on php-marcusschwarz-lesserphp is dokuwiki, which will be dropping the dependency once I finally update it to a newer version. As such, I've removed the Obsoletes completely.
Note: Directories without known owners: /usr/share/php/splitbrain
Fixed.
Requires: php-cli >= 7.4.0Please use php(language) >= 7.4.0, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-prov... Requires: php-date Requires: php-pcre Both can be removed, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-prov...
Done.
About composer.json stuff 1/ you have both a sed command and a patch, why ?
I guess I tried sed first, then went for the patch and forgot to remove the sed call.
2/ better fix
Thanks!
spec: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-2/php-s... srpm: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-2/php-s... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=128656084
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://github.com/%%7Bvendor | |}/%{project}/
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8587805 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+
--- Comment #9 from Remi Collet fedora@famillecollet.com --- [x]: Package must own all directories that it creates. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary.
Package approved
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #10 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/php-splitbrain-lesserphp
https://bugzilla.redhat.com/show_bug.cgi?id=2339019
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |php-splitbrain-lesserphp-0. | |10.2-2.fc42 Status|RELEASE_PENDING |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2025-05-15 21:36:48
--- Comment #11 from Artur Frenszek-Iwicki fedora@svgames.pl --- https://bodhi.fedoraproject.org/updates/FEDORA-2025-e927711480
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com