[Bug 2132014] New: Review Request: indi - INDI Core Library

https://bugzilla.redhat.com/show_bug.cgi?id=2132014

Bug ID: 2132014
           Summary: Review Request: indi - INDI Core Library
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

SRPM: https://fedorapeople.org/~limb/review/indi/indi-1.9.8-1.fc37.src.rpm
SPEC: https://fedorapeople.org/~limb/review/indi/indi.spec

Description: INDI is a standard for astronomical instrumentation control. INDI
Library is an
Open Source POSIX implementation of the Instrument-Neutral-Device-Interface
protocol.

[Bug 2132014] Review Request: indi - INDI Core Library

https://bugzilla.redhat.com/show_bug.cgi?id=2132014

Gwyn Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Blocks|                            |2131498

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2131498
[Bug 2131498] stellarium-1.0 is available

[Bug 2132014] Review Request: indi - INDI Core Library

https://bugzilla.redhat.com/show_bug.cgi?id=2132014

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

[Bug 2132014] Review Request: indi - INDI Core Library

https://bugzilla.redhat.com/show_bug.cgi?id=2132014

Mattia Verga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Mattia Verga  ---
INDI is already packaged as "libindi"
https://src.fedoraproject.org/rpms/libindi

[Bug 2132014] Review Request: indi - INDI Core Library

https://bugzilla.redhat.com/show_bug.cgi?id=2132014

Gwyn Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |NOTABUG
        Last Closed|                            |2022-10-04 16:15:45

--- Comment #2 from Gwyn Ciesla  ---
Oh, fantastic, thank you! I can't believe I missed it. :)

[Bug 2132014] Review Request: indi - INDI Core Library

https://bugzilla.redhat.com/show_bug.cgi?id=2132014

--- Comment #3 from Dan Horák  ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK      source files match upstream:
            9fecacb362cc501faf87b89167fd8e859fd058f4  indi-1.9.8.tar.gz
OK      package meets naming and versioning guidelines.
OK*     specfile is properly named, is cleanly written and uses macros
consistently.
OK      dist tag is present.
BAD     license field matches the actual license.
OK      license is open source-compatible. License text included in package.
OK      latest version is being packaged.
OK      BuildRequires are proper.
Ok      compiler flags are appropriate.
OK      package builds in mock (Rawhide/ppc64le).
OK      debuginfo package looks complete.
OK*     rpmlint is silent.
OK      final provides and requires look sane.
OK*     %check is present and all tests pass.
OK      shared libraries are correctly added to the regular linker search
paths.
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      no scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      headers in devel subpackage
OK      pkgconfig file in devel subpackage
OK      no libtool .la droppings.
OK      not a GUI app.

- Source0 could be simplified to
%{url}/archive/v%{version}/%{name}-%{version}.tar.gz
- you can use %{_udevrulesdir} instead of /lib/udev/rules.d
- I believe the sources are mix of GPL/LGPL and per the updated guidelines all
should be listed in the License tag
(https://docs.fedoraproject.org/en-US/legal/license-field/#_conjunctive_and_l...)
- rpmlint complains about missing man pages (can be ignored) and some code
issues (worth reporting upstream I think)
    indi.ppc64le: W: no-manual-page-for-binary indi*
    indi.ppc64le: E: missing-call-to-setgroups-before-setuid
/usr/lib64/libindidriver.so.1.9.8
    indi.ppc64le: W: binary-or-shlib-calls-gethostbyname /usr/bin/indi_*
- there is a call with ctest, but it says "No tests were found!!!"

[Bug 2132014] Review Request: indi - INDI Core Library

https://bugzilla.redhat.com/show_bug.cgi?id=2132014

--- Comment #4 from Dan Horák  ---
Oh, no :-) I will take something else then :-)