[Bug 525795] New: Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Summary: Review Request: libgtkhotkey - Platform independent
                    hotkey handling for Gtk+ applications
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://krakoa.dk/fedora/libgtkhotkey.spec
SRPM URL: http://krakoa.dk/fedora/libgtkhotkey-0.2.1-1.fc11.src.rpm
Description: Platform independent hotkey handling for Gtk+ applications

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Mads Villadsen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |525796

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Guido Grazioli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Guido Grazioli   2009-09-26 08:38:44 EDT ---
Hello, your package doesnt build in koji:
http://koji.fedoraproject.org/koji/getfile?taskID=1709089

You need to BR: intltool (at least)

Your devel package must also Requires: pkgconfig as it includes a .pc file

Please not also that the spec file posted here has a small diff against the one
included in your srpm.

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

--- Comment #2 from Mads Villadsen   2009-09-26 16:43:19 EDT ---
Thanks for looking at this. I updated the spec file and src.rpm, and I tested
that it actually builds in koji this time.

http://krakoa.dk/fedora/libgtkhotkey.spec
http://krakoa.dk/fedora/libgtkhotkey-0.2.1-2.fc11.src.rpm

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

--- Comment #3 from Guido Grazioli   2009-09-27 05:52:43 EDT ---
Some other small issues, the doc dir under /usr/share/doc must be versioned
/usr/share/doc/%{name}-%{version}, and you should remove the generic INSTALL
file which is irrelevant.

Which is your packager account? If you have one i'll take the review, otherwise
i cannot sponsor you.

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

--- Comment #4 from Mads Villadsen   2009-09-27 08:03:36 EDT ---
The doc issue is now fixed, and I have gotten rid of the INSTALL file.

My packager account name is maxx.

http://krakoa.dk/fedora/libgtkhotkey.spec
http://krakoa.dk/fedora/libgtkhotkey-0.2.1-3.fc11.src.rpm

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Guido Grazioli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Guido Grazioli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Guido Grazioli   2009-09-27 11:22:01 EDT ---
OK - rpmlint output
4 packages and 1 specfiles checked; 0 errors, 0 warnings.
OK - The package must be named according to the Package Naming Guidelines.
OK - The spec file name must match the base package %{name}
OK - The package must meet the Packaging Guidelines
OK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
OK - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines (license is LGPLv3)
OK - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun 
OK - The package MUST successfully compile and build
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1711273
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible.
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL. 
bfdc73e68e9adbe0d506d31a25862914  gtkhotkey-0.2.1.tar.gz
NA - The spec file MUST handle locales properly (no translations)
NA - package not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
OK - The package must contain code, or permissable content 
NA - Large documentation files must go in a -doc subpackage (no large doc)
OK - If a package includes something as %doc, it must not affect the runtime of
the application
OK - Header files must be in a -devel package (devel package present)
NA - Static libraries must be in a -static package (no static package)
OK - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK - Packages must NOT contain any .la libtool archives
NA - Packages containing GUI applications MUST include a .desktop file 
OK - No file conflicts with other packages and no general names.
OK - At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK - All filenames in rpm packages must be valid UTF-8
OK - The package does not yet exist in Fedora. The Review Request is not a
duplicate.
OK - %{?dist} tag is used in release

Package APPROVED

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Mads Villadsen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Mads Villadsen   2009-09-27 13:43:09 EDT ---
New Package CVS Request
=======================
Package Name: libgtkhotkey
Short Description: Platform independent hotkey handling for Gtk+ applications
Owners: maxx
Branches: F-11
InitialCC: maxx

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #7 from Kevin Fenzi   2009-09-29 16:04:06 EDT ---
cvs done.

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

--- Comment #8 from Fedora Update System   2009-09-30 17:28:27 EDT ---
libgtkhotkey-0.2.1-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libgtkhotkey-0.2.1-3.fc11

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

--- Comment #9 from Fedora Update System   2009-10-03 14:58:22 EDT ---
libgtkhotkey-0.2.1-3.fc11 has been pushed to the Fedora 11 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 525795] Review Request: libgtkhotkey - Platform independent hotkey handling for Gtk+ applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525795

--- Comment #10 from Fedora Update System   2009-10-04 10:28:02 EDT ---
libgtkhotkey-0.2.1-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/libgtkhotkey-0.2.1-3.fc12