4:30 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
Bug ID: 1485494
Summary: Review Request: ghc-microlens - A tiny lens library
with no dependencies
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: quantum.analyst(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-microlens.spec
SRPM URL:
https://qulogic.fedorapeople.org/git-annex/ghc-microlens-0.4.8.0-1.git.41...
Description: This library is an extract from lens (with no dependencies). It's
not a toy lenses library, but merely a small one. It is compatible with lens,
and should have same performance. It also has better documentation.
Fedora Account System Username: qulogic
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21460567
PS, summary is long, but I'll cut it to just the first sentence after import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:30 p.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Hello,
The latest version is 0.4.8.1, please update the package.
The summary is too long, shorten it (rpmlint error: ghc-microlens.x86_64: E:
summary-too-long)
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "BSD (unspecified)", "Unknown or
generated".
3 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/ghc-microlens/review-ghc-
microlens/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 808960 bytes in 24 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: ghc-microlens-0.4.8.0-1.fc26.x86_64.rpm
ghc-microlens-devel-0.4.8.0-1.fc26.x86_64.rpm
ghc-microlens-0.4.8.0-1.fc26.src.rpm
ghc-microlens.x86_64: E: summary-too-long C A tiny lens library with no
dependencies. If you're writing an app, you probably want microlens-platform,
not this
ghc-microlens.x86_64: W: spelling-error %description -l en_US http -> HTTP
ghc-microlens.x86_64: W: spelling-error %description -l en_US hackage ->
package, hack age, hack-age
ghc-microlens.x86_64: W: spelling-error %description -l en_US haskell ->
Haskell
ghc-microlens.x86_64: W: no-documentation
ghc-microlens.src: E: summary-too-long C A tiny lens library with no
dependencies. If you're writing an app, you probably want microlens-platform,
not this
ghc-microlens.src: W: spelling-error %description -l en_US http -> HTTP
ghc-microlens.src: W: spelling-error %description -l en_US hackage -> package,
hack age, hack-age
ghc-microlens.src: W: spelling-error %description -l en_US haskell -> Haskell
3 packages and 0 specfiles checked; 2 errors, 7 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:08 p.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
--- Comment #2 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
Updated.
Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-microlens.spec
SRPM URL:
https://qulogic.fedorapeople.org/git-annex/ghc-microlens-0.4.8.1-2.git.0....
Description: This library is an extract from lens (with no dependencies). It's
not a toy lenses library, but merely a small one. It is compatible with lens,
and should have same performance. It also has better documentation.
Fedora Account System Username: qulogic
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21487982
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:23 a.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Okay, package accepted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:23 a.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
--- Comment #4 from Gwyn Ciesla <limburgher(a)gmail.com> ---
(fedrepo-req-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-microlens
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:13 a.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
Elliott Sales de Andrade <quantum.analyst(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1486584
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1486584
[Bug 1486584] Review Request: ghc-microlens-th - Automatic generation of
record lenses for microlens
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:55 a.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |ON_QA
--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org> ---
ghc-microlens-0.4.8.1-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0c66d6ee76
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:19 p.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
Elliott Sales de Andrade <quantum.analyst(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1488608
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1488608
[Bug 1488608] Review Request: ghc-persistent-sqlite - Backend for the
persistent library using sqlite3
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:51 p.m.
New subject: [Bug 1485494] Review Request:
ghc-microlens - A tiny lens library with no dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1485494
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2017-09-09 19:51:40
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
ghc-microlens-0.4.8.1-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2480
days inactive
2495
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
bugzilla＠redhat.com