[Bug 2178003] New: Review Request: jakartaee-migration - Tomcat Migration Tool for Jakarta EE
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
Bug ID: 2178003 Summary: Review Request: jakartaee-migration - Tomcat Migration Tool for Jakarta EE Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: huwang@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://huwang.fedorapeople.org/jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/jakartaee-migration-1.0.6-1.fc37.src.rpm Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #1 from huwang huwang@redhat.com --- The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=98648277
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://tomcat.apache.org/
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5634889 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #3 from huwang huwang@redhat.com --- *** Bug 2178000 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #4 from huwang huwang@redhat.com --- I have changed the package name to tomcat-jakartaee-migration and fixed the patch command.
Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.6-1.fc38.src.... Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang
The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109997254
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2002982 --> https://bugzilla.redhat.com/attachment.cgi?id=2002982&action=edit The .spec file difference from Copr build 5634889 to 6730978
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6730978 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline... - Not a valid SPDX expression 'ASL 2.0'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Read more: https://fedoraproject.org/wiki/Packaging:Java
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #7 from huwang huwang@redhat.com --- Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.8-1.fc38.src.... Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang
The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=113219331
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #8 from huwang huwang@redhat.com --- New Spec and SRPM URLs, fedora-review-service-build.
Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.8-1.fc38.src.... Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang
The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=113219331
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7005482 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7005484 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
Socrates Zappis szappis@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(huwang@redhat.com | |)
--- Comment #11 from Socrates Zappis szappis@redhat.com --- @huwang@redhat.com the License file that the check is complaining about can be located in the noarch rpm under "/usr/share/javadoc/tomcat-jakartaee-migration/legal/" . I believe you will fix that by adding the following to your specfile under the "%files javadoc" section:
"%license ADDITIONAL_LICENSE_INFO"
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
huwang huwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(huwang@redhat.com | |) |
--- Comment #12 from huwang huwang@redhat.com --- New Spec and SRPM URLs, fedora-review-service-build.
Spec URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration.spec SRPM URL: https://huwang.fedorapeople.org/tomcat-jakartaee-migration-1.0.8-1.fc38.src.... Description: The purpose of the tool is to take a web application written for Java EE 8 that runs on Apache Tomcat 9 and convert it automatically so it runs on Apache Tomcat 10 which implements Jakarta EE 9. Fedora Account System Username: huwang
The scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=114286662
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2019594 --> https://bugzilla.redhat.com/attachment.cgi?id=2019594&action=edit The .spec file difference from Copr build 7005484 to 7095095
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7095095 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #15 from Socrates Zappis szappis@redhat.com --- fedora-review-service-build
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #16 from Socrates Zappis szappis@redhat.com --- Retry with [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #17 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7106470 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
--- Comment #18 from Socrates Zappis szappis@redhat.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is properly handled * No serious issues from rpmlint
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
Socrates Zappis szappis@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
huwang huwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |jakartaee-migration - |tomcat-jakartaee-migration |Tomcat Migration Tool for |- Tomcat Migration Tool for |Jakarta EE |Jakarta EE
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
huwang huwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
huwang huwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |szappis@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2178003
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #19 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/tomcat-jakartaee-migration
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com