[Bug 823046] New: Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Summary: Review Request: php-symfony2-DependencyInjection -
                    Symfony2 DependencyInjection Component
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---

Spec URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-DependencyInje...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-DependencyInje...

Description:
The Dependency Injection component allows you to standardize and centralize the
way objects are constructed in your application.

For an introduction to Dependency Injection and service containers see
Service Container (http://symfony.com/doc/current/book/service_container.html).

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |814994(php-channel-symfony2
                   |                            |)

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #1 from Shawn Iwinski  ---
Updates per comments in bug 823043

- Removed BuildRoot
- Changed php require to php-common
- Added the following requires based on phpci results:
  php-ctype, php-dom, php-libxml, php-pcre, php-spl, php-simplexml
- Removed %defattr from %files section

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-DependencyInje...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-DependencyInje...

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #2 from Shawn Iwinski  ---
Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5

- Moved documentation to correct location

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-DependencyInje...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-DependencyInje...

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #3 from Shawn Iwinski  ---
Updated to upstream version 2.0.15 & updates per bug #817303

- Removed "BuildRequires: php-pear >= 1:1.4.9-1.2"
- Updated %prep section
- Removed cleaning buildroot from %install section
- Removed documentation move from %install section (fixed upstream)
- Removed %clean section
- Updated %doc in %files section

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-DependencyInje...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-DependencyInje...

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #589962|                            |review?
              Flags|                            |
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #4 from Remi Collet  ---
Created attachment 589962
  --> https://bugzilla.redhat.com/attachment.cgi?id=589962&action=edit
php-symfony2-DependencyInjection-review.txt

Generated by fedora-review 0.1.3

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #5 from Remi Collet  ---
SHOULD: From package.xml, there are 2 optionnal deps.
php-pear(pear.symfony.com/Config)
php-pear(pear.symfony.com/Yaml)

It's a packager choice to make this (mandatory) Requires.

If you choose to add this requires, you can also remove
%dir %{pear_phpdir}/Symfony/Component
%dir %{pear_phpdir}/Symfony

No blocker.

=== APPROVED ===

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #6 from Shawn Iwinski  ---
New Package SCM Request
=======================
Package Name: php-symfony2-DependencyInjection
Short Description: Symfony2 DependencyInjection Component
Owners: siwinski
Branches: f16 f17 el6
InitialCC:

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #8 from Remi Collet  ---
So for late error detection

DependencyInjection/Loader/schema/dic/services/services-1.0.xsd should be
installed as role="php", not as role="doc" as this path is referred in the code

In DependencyInjection/Loader/XmlFileLoader.php

$schemaLocations = array('http://symfony.com/schema/dic/services' 
   => str_replace('\', '/', __DIR__.'/schema/dic/services/services-1.0.xsd'));

Like for "Locale" this should be reported upstream, and role="data" is probably
a better solution.

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #9 from Shawn Iwinski  ---
(In reply to comment #8)
> So for late error detection
>
> DependencyInjection/Loader/schema/dic/services/services-1.0.xsd should be
> installed as role="php", not as role="doc" as this path is referred in the
> code
>
> In DependencyInjection/Loader/XmlFileLoader.php
>
> $schemaLocations = array('http://symfony.com/schema/dic/services' 
>    => str_replace('\', '/',
> __DIR__.'/schema/dic/services/services-1.0.xsd'));
>
> Like for "Locale" this should be reported upstream, and role="data" is
> probably a better solution.

Thanks for finding this Remi.  I will make sure to fix the issue before
proceeding.

I will get upstream to fix the package.xml role for the *.xsd file.  It will
take a code change to allow for role="data", but I will work with upstream to
fix the issue.  If role="data" will take some time to implement, is it fine to
revert to role="php" for now and plan on role="data" for a future enhancement?

I looked through all the other php-symfony2-* packages and it appears this same
error exists in version 2.0.15 for the Routing, Translation, and Validator
packages as well.  I will update those reviews with this information and work
with upstream to fix.

Since these fixes upstream will require a new release (probably 2.0.16), may I
just fix the package.xml in the spec file?

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #10 from Remi Collet  ---
(In reply to comment #9)
> If role="data" will take some time to implement, is it
> fine to revert to role="php" for now and plan on role="data" for a future
> enhancement?

Yes.
> Since these fixes upstream will require a new release (probably 2.0.16), may
> I just fix the package.xml in the spec file?

Yes

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |823042, 817303

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |823073

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #11 from Shawn Iwinski  ---
Fixed issue from comment #8 and commited --
http://pkgs.fedoraproject.org/gitweb/?p=php-symfony2-DependencyInjection.git...

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #12 from Fedora Update System  ---
php-symfony2-DependencyInjection-2.0.15-3.fc17 has been submitted as an update
for Fedora 17.
https://admin.fedoraproject.org/updates/php-symfony2-DependencyInjection-2.0...

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #13 from Fedora Update System  ---
php-symfony2-DependencyInjection-2.0.15-3.fc16 has been submitted as an update
for Fedora 16.
https://admin.fedoraproject.org/updates/php-symfony2-DependencyInjection-2.0...

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #14 from Fedora Update System  ---
php-symfony2-DependencyInjection-2.0.15-3.el6 has been submitted as an update
for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-symfony2-DependencyInjection-2.0...

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #15 from Fedora Update System  ---
php-symfony2-DependencyInjection-2.0.15-3.fc17 has been pushed to the Fedora 17
testing repository.

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2012-07-02 18:28:35

--- Comment #16 from Fedora Update System  ---
php-symfony2-DependencyInjection-2.0.15-3.fc16 has been pushed to the Fedora 16
stable repository.

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #17 from Fedora Update System  ---
php-symfony2-DependencyInjection-2.0.15-3.fc17 has been pushed to the Fedora 17
stable repository.

[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #18 from Fedora Update System  ---
php-symfony2-DependencyInjection-2.0.15-3.el6 has been pushed to the Fedora
EPEL 6 stable repository.