[Bug 2160509] New: Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Bug ID: 2160509
           Summary: Review Request: python-colored - Library for color and
                    formatting in terminal
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://[e-mail]/python-colored.spec
SRPM URL:
https://[e-mail]/python-colored-1.4.4-1.fc38....

Description:
Very simple Python library for color and formatting in terminal.
Collection of color codes and names for 256 color terminal setups.

Fedora Account System Username: [e-mail]

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

--- Comment #1 from Jonathan Wright  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=96058017

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

--- Comment #2 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5224090
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Jonathan Wright  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #3 from Jonathan Wright  ---
copr failure is unrelated.  It is due to fedora-create-review putting the wrong
FAS username in this ticket.

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

--- Comment #4 from Jonathan Wright  ---
Correct URLs:

Spec URL: https://jonathanspw.fedorapeople.org/python-colored.spec
SRPM URL:
https://jonathanspw.fedorapeople.org/python-colored-1.4.4-1.fc38.src.rpm

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Carl George 🤠  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
              Flags|                            |fedora-review?

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

--- Comment #5 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5255607
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #6 from Fedora Update System  ---
FEDORA-2023-30df91a05c has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-30df91a05c

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-01-19 20:54:53

--- Comment #7 from Fedora Update System  ---
FEDORA-2023-30df91a05c has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Carl George 🤠  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|ERRATA                      |---
             Status|CLOSED                      |ASSIGNED
           Keywords|                            |Reopened

--- Comment #8 from Carl George 🤠  ---
Optional suggestion, use the PyPI tarball instead of the GitLab one.  This is
not required by the guidelines, but I believe most Python packagers tend to
stick with PyPI tarballs unless it is missing tests or other necessary files.

-Source:        
https://gitlab.com/dslackw/colored/-/archive/%%7Bversion%7D/colored-%%7Bvers...
+Source:         %{pypi_source colored}

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_fi...

================================================================================

There is a build requirement for pytest, but it is not used to run the test, so
it should be removed.

-# for tests
-BuildRequires:  python3-pytest

================================================================================

Upstream's TravisCI config claims to run nosetests, but none of the files in
the tests directory contain valid unit tests.  They instead appear to be
scripts to run manually and visually compare the color output.  I can see the
only thing is %check is an import test.  I agree with that approach, but it
would also be useful to add a comment about why the upstream tests can't be
run.

================================================================================

The LICENSE.txt file is properly picked up by the Python metadata, so listing
it explicitly in %files produces a duplicate.  The explicit listing should be
removed to avoid this.

-%license LICENSE.txt

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Jonathan Wright  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail])

--- Comment #9 from Jonathan Wright  ---
(In reply to Carl George 🤠 from comment #8)
> Optional suggestion, use the PyPI tarball instead of the GitLab one.  This
> is not required by the guidelines, but I believe most Python packagers tend
> to stick with PyPI tarballs unless it is missing tests or other necessary
> files.
>
> -Source:        
> https://gitlab.com/dslackw/colored/-/archive/%%7Bversion%7D/colored-%%7Bvers....
> tar.gz
> +Source:         %{pypi_source colored}
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_source_files_from_pypi

I tend to go straight for GH to avoid such issues altogether.  I'd prefer to
stick to GH but will happily change it of course if policy ever changes (or
later on it seems like upstream maintains releases on PyPi better).
> There is a build requirement for pytest, but it is not used to run the test,
> so it should be removed.
>
> -# for tests
> -BuildRequires:  python3-pytest

Already removed in my local copy.  Looks like I uploaded a slightly outdated
one here by mistake.
> Upstream's TravisCI config claims to run nosetests, but none of the files in
> the tests directory contain valid unit tests.  They instead appear to be
> scripts to run manually and visually compare the color output.  I can see
> the only thing is %check is an import test.  I agree with that approach, but
> it would also be useful to add a comment about why the upstream tests can't
> be run.

Added a note.
> The LICENSE.txt file is properly picked up by the Python metadata, so
> listing it explicitly in %files produces a duplicate.  The explicit listing
> should be removed to avoid this.
>
> -%license LICENSE.txt

Good catch, fixed in my local copy.

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Carl George 🤠  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+
                   |needinfo?([e-mail])  |

--- Comment #10 from Carl George 🤠  ---
Package is approved.

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

--- Comment #11 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-colored

[Bug 2160509] Review Request: python-colored - Library for color and formatting in terminal

https://bugzilla.redhat.com/show_bug.cgi?id=2160509

Carl George 🤠  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
   Fixed In Version|                            |python-colored-1.4.4-1.fc38
             Status|POST                        |CLOSED
        Last Closed|2023-01-19 20:54:53         |2023-09-01 21:49:16

--- Comment #12 from Carl George 🤠  ---
https://bodhi.fedoraproject.org/updates/FEDORA-2023-d311a56496