[Bug 1774098] New: Review Request: gitfs - 0.5.2

https://bugzilla.redhat.com/show_bug.cgi?id=1774098

Bug ID: 1774098
           Summary: Review Request: gitfs - 0.5.2
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://github.com/presslabs/gitfs/releases/download/0.5.2/gitfs.spec
SRPM URL:
https://github.com/presslabs/gitfs/releases/download/0.5.2/gitfs-0.5.2-1.14....
Description: gitfs is a FUSE file system that fully integrates with git. You
can mount a remote repository's branch locally, and any subsequent changes made
to the files will be automatically committed to the remote.
Fedora Account System Username: vtemian

[Bug 1774098] Review Request: gitfs - 0.5.2

https://bugzilla.redhat.com/show_bug.cgi?id=1774098

Vlad Temian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1774098] Review Request: gitfs - 0.5.2

https://bugzilla.redhat.com/show_bug.cgi?id=1774098

Tom Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)
         Depends On|177841 (FE-NEEDSPONSOR)     |
           Doc Type|---                         |If docs needed, set a value

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1774098] Review Request: gitfs - 0.5.2

https://bugzilla.redhat.com/show_bug.cgi?id=1774098

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Robert-André Mauchin  ---
 - License is not a valid shourthand, see list here:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

License:        ASL 2.0

- Release start at 1

Release:        1

- Group: is not used in Fedora

- BR should indicate the Python3 version, unversioned is forbidden:

BuildRequires:  python3-devel
BuildRequires:  python3-setuptools
Requires:       python3-atomiclong
Requires:       python3-fusepy 
Requires:       python3-pygit2
Requires:       python3-raven
Requires:       python3-pycparser

- BuildRoot: is not used in Fedora

- You should remove preexisting egginfo

rm -rf gitfs.egg-info/

- python setup.py build → %py3_build

- python setup.py install --prefix=%{_prefix} --root=%{buildroot}  →
%py3_install

- %{buildroot}/var/lib/gitfs → %{buildroot}%{_sharedstatedir}/gitfs

- Not needed: %defattr(-,root,root,-)

- Should be python3 and globbing the entirety of %{python_sitelib}/ is
forbidden, be more specific instead:

%{python_sitelib}/gitfs/

- %changelog entries are not valid:

* Tue Nov 19 2019 Vlad Temian  - 0.5.1-1

Please read the Guidelines and specifically the Python ones:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

[Bug 1774098] Review Request: gitfs - FUSE userland filesytem for git

https://bugzilla.redhat.com/show_bug.cgi?id=1774098

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: gitfs -     |Review Request: gitfs -
                   |0.5.2                       |FUSE userland filesytem for
                   |                            |git

needinfo canceled: [Bug 1774098] Review Request: gitfs - FUSE userland filesytem for git

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Vlad Temian
's needinfo:
Bug 1774098: Review Request: gitfs - FUSE userland filesytem for git
https://bugzilla.redhat.com/show_bug.cgi?id=1774098

--- Comment #3 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.