[Bug 2372289] New: Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

Bug ID: 2372289
           Summary: Review Request: efitools - Tools to manipulate EFI
                    secure boot keys and signatures
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://in.waw.pl/~zbyszek/efitools.spec
SRPM URL: https://in.waw.pl/~zbyszek/efitools-1.9.2-16.fc43.src.rpm
Description:
This package installs a variety of tools for manipulating keys and binary
signatures on UEFI secure boot platforms. The tools provide access to the keys
and certificates stored in the secure variables of the UEFI firmware, usually
in the NVRAM area.

Fedora Account System Username: zbyszek

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #1 from Fedora Review Service  ---
There seems to be some problem with the following file.
SRPM URL: https://in.waw.pl/~zbyszek/efitools-1.9.2-16.fc43.src.rpm
Fetching it results in a 403 Forbidden error.
Please make sure the URL is correct and publicly available.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
https://in.waw.pl/~zbyszek/fedora/efitools.spec
https://in.waw.pl/~zbyszek/fedora/efitools-1.9.2-16.fc43.src.rpm

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://git.kernel.org/pub/
                   |                            |scm/linux/kernel/git/jejb/e
                   |                            |fitools.git

--- Comment #3 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9152990
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- Not a valid SPDX expression 'GPLv2 and LGPLv2 and BSD'. It seems that you are
using the old Fedora license abbreviations. Try `license-fedora2spdx' for
converting it to SPDX.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/efitools
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
https://in.waw.pl/~zbyszek/fedora/efitools.spec
https://in.waw.pl/~zbyszek/fedora/efitools-1.9.2-17.fc43.src.rpm

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #5 from Fedora Review Service  ---
Created attachment 2093660
  --> https://bugzilla.redhat.com/attachment.cgi?id=2093660&action=edit
The .spec file difference from Copr build 9152990 to 9153029

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #6 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9153029
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/efitools
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #7 from Luca Boccassi  ---
Any update on reintroducing efitools? Thanks

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]

--- Comment #8 from Neal Gompa  ---
Taking this review.

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Neal?

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #10 from Neal Gompa  ---
Spec review:

The main thing I see is the glob on man pages. Presuming the man pages are a
1:1 match for the executables, would something like this work in the files
section?

# Some small macro to list tools with manpages -- cribbed from libsolv
%define efi_tool() \
%{_bindir}/%{1}\        
%{_mandir}/man1/%{1}.1*

%efi_tool cert-to-efi-hash-list
%efi_tool cert-to-efi-sig-list
%efi_tool efi-readvar
%efi_tool efi-updatevar
%efi_tool efitool-mkusb
%efi_tool flash-var
%efi_tool hash-to-efi-sig-list
%efi_tool sig-list-to-certs
%efi_tool sign-efi-sig-list

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #11 from Zbigniew Jędrzejewski-Szmek  ---
Two man pages were missing. But otherwise this works nicely.

https://in.waw.pl/~zbyszek/fedora/efitools.spec
https://in.waw.pl/~zbyszek/fedora/efitools-1.9.2-18.fc43.src.rpm

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #12 from Fedora Review Service  ---
Created attachment 2103272
  --> https://bugzilla.redhat.com/attachment.cgi?id=2103272&action=edit
The .spec file difference from Copr build 9153029 to 9397601

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

--- Comment #13 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9397601
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/efitools
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #14 from Neal Gompa  ---
Review notes:

* Package follows the Fedora packaging guidelines
* Package licensing is correct and license data is installed
* Package builds and installs
* No serious issues from rpmlint

PACKAGE APPROVED.

[Bug 2372289] Review Request: efitools - Tools to manipulate EFI secure boot keys and signatures

https://bugzilla.redhat.com/show_bug.cgi?id=2372289

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #15 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/efitools